prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove .searchable navbar workaround since we no longer use searchable on link item detail

Browse source
This commit is contained in:
Satindar Dhillon 2022-08-08 10:15:22 -07:00
parent 752411e76f
commit b60fb42606
1 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
apple/OmnivoreKit/Sources/App/Views/LinkItemDetailView.swift
View file

@ -107,29 +107,19 @@ struct LinkItemDetailView: View {
)
}
// We always want this hidden but setting it to false initially
// fixes a bug where SwiftUI searchable will always show the nav bar
// if the search field is active when pushing.
@State var hideNavBar = false
var body: some View {
ZStack {
ZStack { // Using ZStack so .task can be used on if/else body
if isPDF {
fixedNavBarReader
.task {
await viewModel.loadItem(linkedItemObjectID: linkedItemObjectID, dataService: dataService)
hideNavBar = true
}
pdfContainerView
} else if let item = viewModel.item {
WebReaderContainerView(item: item)
}
}
.task {
await viewModel.loadItem(linkedItemObjectID: linkedItemObjectID, dataService: dataService)
hideNavBar = true
}
#if os(iOS)
.navigationBarHidden(hideNavBar)
.navigationBarHidden(true)
#endif
}
@ -203,7 +193,7 @@ struct LinkItemDetailView: View {
}
}
@ViewBuilder private var fixedNavBarReader: some View {
@ViewBuilder private var pdfContainerView: some View {
if let pdfItem = viewModel.pdfItem, let pdfURL = pdfItem.pdfURL {
#if os(iOS)
PDFViewer(viewModel: PDFViewerViewModel(pdfItem: pdfItem))