From f6b780d2ddafafdc88faba4cdec132c3f75cd4a1 Mon Sep 17 00:00:00 2001 From: gitstart-omnivore Date: Wed, 23 Mar 2022 19:33:32 +0000 Subject: [PATCH 01/12] fix props naming --- .../components/elements/images/EdgeIcon.tsx | 36 +++++------ .../elements/images/FirefoxIcon.tsx | 62 +++++++++---------- packages/web/pages/_app.tsx | 2 +- 3 files changed, 50 insertions(+), 50 deletions(-) diff --git a/packages/web/components/elements/images/EdgeIcon.tsx b/packages/web/components/elements/images/EdgeIcon.tsx index 36633c38d..991b73d2d 100644 --- a/packages/web/components/elements/images/EdgeIcon.tsx +++ b/packages/web/components/elements/images/EdgeIcon.tsx @@ -11,7 +11,7 @@ export function EdgeIcon(props: EdgeIconProps): JSX.Element { fill="none" xmlns="http://www.w3.org/2000/svg" > - + - - + + - - + + - - - - + + + + - - + + - - - - - + + + + + - - + + - + - - - + + + - - + + - - + + - - + + - - + + - - + + - - + + - - + + - - + + - - - + + + - - - + + + - - + + - - - + + + - + From 69ad032f4c74f59cb2bcb8f29557b5a185e905e2 Mon Sep 17 00:00:00 2001 From: gitstart-omnivore Date: Wed, 23 Mar 2022 19:49:35 +0000 Subject: [PATCH 02/12] fix props naming issue --- .../components/elements/images/ChromeIcon.tsx | 34 +++++++++++++++---- .../components/elements/images/SafariIcon.tsx | 6 ++-- 2 files changed, 30 insertions(+), 10 deletions(-) diff --git a/packages/web/components/elements/images/ChromeIcon.tsx b/packages/web/components/elements/images/ChromeIcon.tsx index d04634f9e..234c823b7 100644 --- a/packages/web/components/elements/images/ChromeIcon.tsx +++ b/packages/web/components/elements/images/ChromeIcon.tsx @@ -4,13 +4,33 @@ type ChromeIconProps = { export function ChromeIcon(props: ChromeIconProps): JSX.Element { return ( - - - - - - + + + + + + - ) } diff --git a/packages/web/components/elements/images/SafariIcon.tsx b/packages/web/components/elements/images/SafariIcon.tsx index f425e438d..c40b04861 100644 --- a/packages/web/components/elements/images/SafariIcon.tsx +++ b/packages/web/components/elements/images/SafariIcon.tsx @@ -30,7 +30,7 @@ export function SafariIcon(props: SafariIconProps): JSX.Element { - - + + From 7786a3f321a33071809a8f375b38e9c3964b0eee Mon Sep 17 00:00:00 2001 From: gitstart-omnivore Date: Mon, 28 Mar 2022 12:57:28 +0000 Subject: [PATCH 03/12] effected review changes --- .../elements/ExtensionsInstallHelp.tsx | 126 +++-- .../components/elements/MobileInstallHelp.tsx | 173 ++++--- .../web/components/elements/StyledText.tsx | 4 + packages/web/components/elements/Tooltip.tsx | 6 +- .../elements/images/InstallationIcon.tsx | 458 ++++++++++++++++++ .../elements/images/SaveArticleIcon.tsx | 41 ++ .../images/about/save-article-mobile.png | Bin 695763 -> 0 bytes .../static/images/about/save-article.png | Bin 70888 -> 0 bytes .../web/public/static/images/installation.png | Bin 11870 -> 0 bytes .../media/about/save-article-mobile.png | Bin 695763 -> 0 bytes .../static/media/about/save-article.png | Bin 70888 -> 0 bytes .../web/public/static/media/appStoreBadge.png | Bin 2458 -> 3938 bytes 12 files changed, 688 insertions(+), 120 deletions(-) create mode 100644 packages/web/components/elements/images/InstallationIcon.tsx create mode 100644 packages/web/components/elements/images/SaveArticleIcon.tsx delete mode 100644 packages/web/public/static/images/about/save-article-mobile.png delete mode 100644 packages/web/public/static/images/about/save-article.png delete mode 100644 packages/web/public/static/images/installation.png delete mode 100644 packages/web/public/static/media/about/save-article-mobile.png delete mode 100644 packages/web/public/static/media/about/save-article.png diff --git a/packages/web/components/elements/ExtensionsInstallHelp.tsx b/packages/web/components/elements/ExtensionsInstallHelp.tsx index f19495973..a7a8c82af 100644 --- a/packages/web/components/elements/ExtensionsInstallHelp.tsx +++ b/packages/web/components/elements/ExtensionsInstallHelp.tsx @@ -1,6 +1,6 @@ import React from 'react' import { Box, HStack } from '../elements/LayoutPrimitives' -import { StyledImg, StyledText } from '../elements/StyledText' +import { StyledText, StyledAnchor } from '../elements/StyledText' import { AngleDownIcon } from '../tokens/icons/AngleDownIcon' import { Button } from './Button' import { Dropdown, DropdownOption, DropdownSeparator } from './DropdownElements' @@ -8,6 +8,8 @@ import { ChromeIcon } from './images/ChromeIcon' import { EdgeIcon } from './images/EdgeIcon' import { FirefoxIcon } from './images/FirefoxIcon' import { SafariIcon } from './images/SafariIcon' +import Link from 'next/link' +import { SaveArticleIcon } from './images/SaveArticleIcon' const icons = { 'Google Chrome': , @@ -16,6 +18,13 @@ const icons = { Safari: , } +const extensionDownloadLinks = { + 'Google Chrome': 'https://omnivore.app/install/chrome', + Safari: 'https://omnivore.app/install/mac', + 'Microsoft Edge': 'https://omnivore.app/install/edge', + Firefox: 'https://omnivore.app/install/firefox', +} + const browserOptions = [ 'Google Chrome', 'Firefox', @@ -55,9 +64,7 @@ export default function ExtensionsInstallHelp(): JSX.Element { const [browserValue, setBrowserValue] = React.useState( browserOptions[0] ) - const handleBrowserUpdate = (e: any) => { - setBrowserValue(e) - } + return ( - + > + + + + - - Learn more - + + + Learn more + + - - Learn more about the browser extension here. - + + + Learn more about the browser extension here. + + @@ -244,10 +268,14 @@ export default function ExtensionsInstallHelp(): JSX.Element { ))}