prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: increment feed fetch failed count if rss feed is failed to fetch

Browse source
This commit is contained in:
Hongbo Wu 2024-01-09 11:22:20 +08:00
parent 202fe50ebc
commit a2ab8327ca
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/rss-handler/src/index.ts
View file

@ -78,7 +78,10 @@ const isFeedBlocked = async (feedUrl: string, redisClient: RedisClient) => {
return false
}
const blockFeed = async (feedUrl: string, redisClient: RedisClient) => {
const incrementFeedFailure = async (
feedUrl: string,
redisClient: RedisClient
) => {
const key = feedFetchFailedRedisKey(feedUrl)
try {
const result = await redisClient.incr(key)
@ -142,8 +145,8 @@ export const fetchAndChecksum = async (url: string) => {
return { url, content: dataStr, checksum: hash.digest('hex') }
} catch (error) {
console.log(error)
throw new Error(`Failed to fetch or hash content from ${url}.`)
console.log(`Failed to fetch or hash content from ${url}.`, error)
return null
}
}
@ -631,10 +634,16 @@ export const rssHandler = Sentry.GCPFunction.wrapHttpFunction(
}
const fetchResult = await fetchAndChecksum(feedUrl)
if (!fetchResult) {
console.error('Failed to fetch RSS feed', feedUrl)
await incrementFeedFailure(feedUrl, redisClient)
return res.status(500).send('FAILED_TO_FETCH_RSS_FEED')
}
const feed = await parseFeed(feedUrl, fetchResult.content)
if (!feed) {
console.error('Failed to parse RSS feed', feedUrl)
await blockFeed(feedUrl, redisClient)
await incrementFeedFailure(feedUrl, redisClient)
return res.status(500).send('INVALID_RSS_FEED')
}