From 9f7065c5c3f6cd8f4abf2bf5198bcfe06154b873 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Mon, 1 Jul 2024 11:51:57 +0800
Subject: [PATCH] do not update library item score if 0

---
 packages/api/src/jobs/score_library_item.ts | 26 ++++++++++-----------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/packages/api/src/jobs/score_library_item.ts b/packages/api/src/jobs/score_library_item.ts
index 2e89f9955..a3f0b9bd5 100644
--- a/packages/api/src/jobs/score_library_item.ts
+++ b/packages/api/src/jobs/score_library_item.ts
@@ -97,24 +97,22 @@ export const scoreLibraryItem = async (
     items: itemFeatures,
   })
 
-  logger.info('Scores', scores)
-  const score = scores[libraryItem.id]['score']
+  const score = scores[libraryItem.id].score
   if (!score) {
     logger.error('Failed to score library item', data)
-    throw new Error('Failed to score library item')
+  } else {
+    await updateLibraryItem(
+      libraryItem.id,
+      {
+        score,
+      },
+      userId,
+      undefined,
+      true
+    )
+    logger.info('Library item score updated', data)
   }
 
-  await updateLibraryItem(
-    libraryItem.id,
-    {
-      score,
-    },
-    userId,
-    undefined,
-    true
-  )
-  logger.info('Library item scored', data)
-
   try {
     await enqueueUpdateHomeJob({
       userId,