Merge pull request #3618 from omnivore-app/feature/text-direction-extension

Allow web extension to get the content text direction and save
This commit is contained in:
Hongbo Wu 2024-03-05 12:52:40 +08:00 committed by GitHub
commit 9b64d47618
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -134,6 +134,7 @@
contentCopyEl.style.left = '-2000px'
contentCopyEl.style.zIndex = '-2000'
contentCopyEl.innerHTML = document.body.innerHTML
const dir = document.dir
// Appending copy of the content to the DOM to enable computed styles capturing ability
// Without adding that copy to the DOM the `window.getComputedStyle` method will always return undefined.
@ -149,7 +150,7 @@
* capture them separately and concatenate them here with head and body tags
* preserved.
*/
const contentCopyHtml = `<html><head>${document.head.innerHTML}</head><body>${contentCopyEl.innerHTML}</body></html>`
const contentCopyHtml = `<html ${dir.toLowerCase() === 'rtl' ? 'dir="rtl"': ''}><head>${document.head.innerHTML}</head><body>${contentCopyEl.innerHTML}</body></html>`
// Cleaning up the copy element
contentCopyEl.remove()
return contentCopyHtml