From 96ddc100b5f28ed3f68550285ddfb6e0323c7613 Mon Sep 17 00:00:00 2001
From: Jackson Harper <jacksonh@gmail.com>
Date: Mon, 6 Mar 2023 16:21:20 +0800
Subject: [PATCH] Linting improvements

---
 .../patterns/LibraryCards/SearchModal.tsx     | 62 -------------------
 .../patterns/ReaderDropdownMenu.tsx           |  7 +--
 .../templates/article/ArticleContainer.tsx    |  2 +-
 .../article/ReaderSettingsControl.tsx         |  7 +--
 .../article/VerticalArticleActions.tsx        | 12 +---
 .../templates/homeFeed/EditItemModals.tsx     |  5 +-
 .../templates/homeFeed/HomeFeedContainer.tsx  |  7 +--
 7 files changed, 10 insertions(+), 92 deletions(-)
 delete mode 100644 packages/web/components/patterns/LibraryCards/SearchModal.tsx

diff --git a/packages/web/components/patterns/LibraryCards/SearchModal.tsx b/packages/web/components/patterns/LibraryCards/SearchModal.tsx
deleted file mode 100644
index 167c2e10c..000000000
--- a/packages/web/components/patterns/LibraryCards/SearchModal.tsx
+++ /dev/null
@@ -1,62 +0,0 @@
-import { ReactNode, useMemo, useRef, useState } from 'react'
-import { StyledText } from '../../elements/StyledText'
-import { Box, HStack, SpanBox, VStack } from '../../elements/LayoutPrimitives'
-import { Dropdown, DropdownOption } from '../../elements/DropdownElements'
-import { Button, IconButton } from '../../elements/Button'
-import {
-  CaretRight,
-  Circle,
-  DotsThree,
-  MagnifyingGlass,
-  Plus,
-  X,
-} from 'phosphor-react'
-import { useGetSubscriptionsQuery } from '../../../lib/networking/queries/useGetSubscriptionsQuery'
-import { useGetLabelsQuery } from '../../../lib/networking/queries/useGetLabelsQuery'
-import { Label } from '../../../lib/networking/fragments/labelFragment'
-import {
-  ModalContent,
-  ModalOverlay,
-  ModalRoot,
-} from '../../elements/ModalPrimitives'
-import { theme } from '../../tokens/stitches.config'
-import { FormInput } from '../../elements/FormElements'
-import { SearchBox } from '../../templates/homeFeed/LibraryHeader'
-
-type SearchModalProps = {
-  searchTerm: string | undefined
-  applySearchQuery: (searchTerm: string) => void
-
-  onOpenChange: (open: boolean) => void
-}
-
-export function SearchModal(props: SearchModalProps): JSX.Element {
-  return (
-    <ModalRoot defaultOpen onOpenChange={props.onOpenChange} css={{}}>
-      <ModalOverlay onClick={(e) => e.preventDefault()} />
-      <ModalContent
-        css={{
-          bg: '$grayBg',
-          width: '100%',
-          p: '10px',
-          height: '120px',
-          top: '70px',
-        }}
-        onInteractOutside={() => {
-          // remove focus from modal
-          ;(document.activeElement as HTMLElement).blur()
-        }}
-      >
-        <VStack distribution="start" css={{ p: '0px' }}>
-          <Box css={{ width: '100%' }}>
-            <SearchBox
-              {...props}
-              compact={true}
-              onClose={() => props.onOpenChange(false)}
-            />
-          </Box>
-        </VStack>
-      </ModalContent>
-    </ModalRoot>
-  )
-}
diff --git a/packages/web/components/patterns/ReaderDropdownMenu.tsx b/packages/web/components/patterns/ReaderDropdownMenu.tsx
index fc6f79dba..8d75e0258 100644
--- a/packages/web/components/patterns/ReaderDropdownMenu.tsx
+++ b/packages/web/components/patterns/ReaderDropdownMenu.tsx
@@ -1,14 +1,9 @@
-import { ReactNode, useMemo, useState } from 'react'
-import { HStack, VStack } from './../elements/LayoutPrimitives'
+import { ReactNode } from 'react'
 import {
   Dropdown,
   DropdownOption,
   DropdownSeparator,
 } from '../elements/DropdownElements'
-import { StyledText } from '../elements/StyledText'
-import { Button } from '../elements/Button'
-import { currentThemeName } from '../../lib/themeUpdater'
-import { Check } from 'phosphor-react'
 
 type DropdownMenuProps = {
   triggerElement: ReactNode
diff --git a/packages/web/components/templates/article/ArticleContainer.tsx b/packages/web/components/templates/article/ArticleContainer.tsx
index a43b5c510..217d9b19f 100644
--- a/packages/web/components/templates/article/ArticleContainer.tsx
+++ b/packages/web/components/templates/article/ArticleContainer.tsx
@@ -71,7 +71,7 @@ const RecommendationComments = (
         </StyledText>
       </HStack>
 
-      {props.recommendationsWithNotes.map((item, idx) => (
+      {props.recommendationsWithNotes.map((item) => (
         <VStack
           key={item.id}
           alignment="start"
diff --git a/packages/web/components/templates/article/ReaderSettingsControl.tsx b/packages/web/components/templates/article/ReaderSettingsControl.tsx
index 3a499e359..92265b912 100644
--- a/packages/web/components/templates/article/ReaderSettingsControl.tsx
+++ b/packages/web/components/templates/article/ReaderSettingsControl.tsx
@@ -1,14 +1,11 @@
-import { HStack, VStack, SpanBox, Box } from '../../elements/LayoutPrimitives'
+import { HStack, VStack, SpanBox } from '../../elements/LayoutPrimitives'
 import { Button } from '../../elements/Button'
 import { StyledText } from '../../elements/StyledText'
 import { styled, theme, ThemeId } from '../../tokens/stitches.config'
 import { ArrowsHorizontal, ArrowsInLineHorizontal, Check } from 'phosphor-react'
 import { TickedRangeSlider } from '../../elements/TickedRangeSlider'
 import { showSuccessToast } from '../../../lib/toastHelpers'
-import {
-  ReaderSettings,
-  useReaderSettings,
-} from '../../../lib/hooks/useReaderSettings'
+import { ReaderSettings } from '../../../lib/hooks/useReaderSettings'
 import { useCallback, useMemo, useState } from 'react'
 import { currentThemeName, updateTheme } from '../../../lib/themeUpdater'
 import { LineHeightIncreaseIcon } from '../../elements/images/LineHeightIncreaseIconProps'
diff --git a/packages/web/components/templates/article/VerticalArticleActions.tsx b/packages/web/components/templates/article/VerticalArticleActions.tsx
index b48a92292..cb04634ea 100644
--- a/packages/web/components/templates/article/VerticalArticleActions.tsx
+++ b/packages/web/components/templates/article/VerticalArticleActions.tsx
@@ -1,7 +1,5 @@
-import { Separator } from '@radix-ui/react-separator'
 import {
   ArchiveBox,
-  DotsThree,
   DotsThreeOutline,
   HighlighterCircle,
   Info,
@@ -12,15 +10,9 @@ import {
 } from 'phosphor-react'
 import { ArticleAttributes } from '../../../lib/networking/queries/useGetArticleQuery'
 import { Button } from '../../elements/Button'
-import { Box, HStack, SpanBox } from '../../elements/LayoutPrimitives'
+import { HStack } from '../../elements/LayoutPrimitives'
 import { TooltipWrapped } from '../../elements/Tooltip'
-import { styled, theme } from '../../tokens/stitches.config'
-import { useReaderSettings } from '../../../lib/hooks/useReaderSettings'
-import { useRef } from 'react'
-import { setLabelsMutation } from '../../../lib/networking/mutations/setLabelsMutation'
-import { Label } from '../../../lib/networking/fragments/labelFragment'
-import { SetLabelsModal } from './SetLabelsModal'
-import { DropdownMenu } from '../../patterns/DropdownMenu'
+import { theme } from '../../tokens/stitches.config'
 import { ReaderDropdownMenu } from '../../patterns/ReaderDropdownMenu'
 
 export type ArticleActionsMenuLayout = 'top' | 'side'
diff --git a/packages/web/components/templates/homeFeed/EditItemModals.tsx b/packages/web/components/templates/homeFeed/EditItemModals.tsx
index fb3cd96c0..2920a7944 100644
--- a/packages/web/components/templates/homeFeed/EditItemModals.tsx
+++ b/packages/web/components/templates/homeFeed/EditItemModals.tsx
@@ -14,7 +14,6 @@ import { StyledTextArea } from '../../elements/StyledTextArea'
 import { updatePageMutation } from '../../../lib/networking/mutations/updatePageMutation'
 import { showErrorToast, showSuccessToast } from '../../../lib/toastHelpers'
 import dayjs, { Dayjs } from 'dayjs'
-import { X } from 'phosphor-react'
 import { ArticleAttributes } from '../../../lib/networking/queries/useGetArticleQuery'
 import { CloseButton } from '../../elements/CloseButton'
 
@@ -72,7 +71,7 @@ export function EditLibraryItemModal(
         }
       })()
     },
-    []
+    [props]
   )
 
   return (
@@ -147,7 +146,7 @@ export function EditArticleModal(props: EditArticleModalProps): JSX.Element {
         }
       })()
     },
-    []
+    [props]
   )
 
   return (
diff --git a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx
index 70e11b38d..0dc7114a6 100644
--- a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx
+++ b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx
@@ -1,4 +1,4 @@
-import { Box, HStack, SpanBox, VStack } from './../../elements/LayoutPrimitives'
+import { Box, HStack, VStack } from './../../elements/LayoutPrimitives'
 import Dropzone from 'react-dropzone'
 import * as Progress from '@radix-ui/react-progress'
 import type {
@@ -21,10 +21,7 @@ import { AddLinkModal } from './AddLinkModal'
 import { styled, theme } from '../../tokens/stitches.config'
 import { ListLayoutIcon } from '../../elements/images/ListLayoutIcon'
 import { GridLayoutIcon } from '../../elements/images/GridLayoutIcon'
-import {
-  libraryListCommands,
-  searchBarCommands,
-} from '../../../lib/keyboardShortcuts/navigationShortcuts'
+import { libraryListCommands } from '../../../lib/keyboardShortcuts/navigationShortcuts'
 import { useKeyboardShortcuts } from '../../../lib/keyboardShortcuts/useKeyboardShortcuts'
 import { Toaster } from 'react-hot-toast'
 import { useFetchMore } from '../../../lib/hooks/useFetchMoreScroll'