From 9496827c6bca630bc53adb7bf25698364f6ff66e Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 12 Oct 2022 13:59:08 +0800
Subject: [PATCH] Add popular reads to new users based on client

---
 packages/api/src/events/user/user_created.ts |  3 +--
 packages/api/src/services/popular_reads.ts   | 24 +++++++++++++++-----
 2 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/packages/api/src/events/user/user_created.ts b/packages/api/src/events/user/user_created.ts
index eee714258..da6bbea76 100644
--- a/packages/api/src/events/user/user_created.ts
+++ b/packages/api/src/events/user/user_created.ts
@@ -126,7 +126,6 @@ export class AddPopularReadsToNewUser
   }
 
   async afterInsert(event: InsertEvent<Profile>): Promise<void> {
-    const isIOSUser = event.entity.user.source === 'APPLE'
-    await addPopularReadsForNewUser(event.entity.user.id, isIOSUser)
+    await addPopularReadsForNewUser(event.entity.user.id)
   }
 }
diff --git a/packages/api/src/services/popular_reads.ts b/packages/api/src/services/popular_reads.ts
index 116c59d2f..67748516b 100644
--- a/packages/api/src/services/popular_reads.ts
+++ b/packages/api/src/services/popular_reads.ts
@@ -96,7 +96,7 @@ export const addPopularRead = async (
 
 const addPopularReads = async (
   userId: string,
-  ...names: string[]
+  names: string[]
 ): Promise<AddPopularReadResult[]> => {
   const results: AddPopularReadResult[] = []
   for (const name of names) {
@@ -114,15 +114,27 @@ const addPopularReads = async (
 
 export const addPopularReadsForNewUser = async (
   userId: string,
-  isIOSUser = false
+  client = 'web'
 ): Promise<void> => {
-  await addPopularReads(
-    userId,
+  const defaultReads = [
     'omnivore_get_started',
     'power_read_it_later',
     'omnivore_organize',
-    isIOSUser ? 'omnivore_ios' : 'omnivore_android'
-  )
+  ]
+
+  switch (client) {
+    case 'web':
+      defaultReads.push('omnivore_web')
+      break
+    case 'ios':
+      defaultReads.push('omnivore_ios')
+      break
+    case 'android':
+      defaultReads.push('omnivore_android')
+      break
+  }
+
+  await addPopularReads(userId, defaultReads)
 }
 
 const popularReads = [