From 927ec54775427e4e9e1a32e841effcabff85f0d1 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Mon, 13 Jun 2022 22:46:49 -0700 Subject: [PATCH 1/5] Use a + {input.options?.map((label, index) => ( + + ))} + + ) } else { return ( - + {input.label} - + diff --git a/packages/web/pages/settings/api.tsx b/packages/web/pages/settings/api.tsx index 38430bf83..5e6fb8396 100644 --- a/packages/web/pages/settings/api.tsx +++ b/packages/web/pages/settings/api.tsx @@ -128,12 +128,31 @@ export default function Api(): JSX.Element { required: true, }, { - label: 'Expired on', + label: 'Expires in', name: 'expiredAt', required: true, - onChange: setExpiresAt, - type: 'date', - min: new Date().toISOString().split('T')[0], // today + onChange: (e) => { + var additionalDays = 0 + switch(e.target.value) { + case '7 days': + additionalDays = 7 + break + case '30 days': + additionalDays = 30 + break + case '90 days': + additionalDays = 90 + break + case '1 year': + additionalDays = 365 + break + } + var newExpires = new Date() + newExpires.setDate(newExpires.getDate() + additionalDays) + setExpiresAt(newExpires) + }, + type: 'select', + options: ['7 days', '30 days', '90 days', '1 year'], value: defaultExpiresAt, }, ]) diff --git a/packages/web/pages/settings/emails.tsx b/packages/web/pages/settings/emails.tsx index 229552e92..2232606e5 100644 --- a/packages/web/pages/settings/emails.tsx +++ b/packages/web/pages/settings/emails.tsx @@ -261,7 +261,7 @@ export default function EmailsPage(): JSX.Element { }} > Date: Mon, 13 Jun 2022 23:00:00 -0700 Subject: [PATCH 2/5] Linting fixes --- packages/web/pages/settings/api.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web/pages/settings/api.tsx b/packages/web/pages/settings/api.tsx index 5e6fb8396..340f6c26b 100644 --- a/packages/web/pages/settings/api.tsx +++ b/packages/web/pages/settings/api.tsx @@ -132,7 +132,7 @@ export default function Api(): JSX.Element { name: 'expiredAt', required: true, onChange: (e) => { - var additionalDays = 0 + let additionalDays = 0 switch(e.target.value) { case '7 days': additionalDays = 7 @@ -147,7 +147,7 @@ export default function Api(): JSX.Element { additionalDays = 365 break } - var newExpires = new Date() + const newExpires = new Date() newExpires.setDate(newExpires.getDate() + additionalDays) setExpiresAt(newExpires) }, From c69eb3b5758562adadf7a333feea94d6fb1a7b73 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Tue, 14 Jun 2022 09:59:58 -0700 Subject: [PATCH 3/5] Make checkboxs left aligned --- .../web/components/elements/FormElements.tsx | 41 +++++++++++-------- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/packages/web/components/elements/FormElements.tsx b/packages/web/components/elements/FormElements.tsx index f5a391d4a..2c26ec6b5 100644 --- a/packages/web/components/elements/FormElements.tsx +++ b/packages/web/components/elements/FormElements.tsx @@ -1,8 +1,8 @@ import { styled } from '../tokens/stitches.config' import { useState } from 'react' import Checkbox from './Checkbox' -import { Box, HStack, VStack } from './LayoutPrimitives' -import { StyledText } from './StyledText' +import { HStack, VStack } from './LayoutPrimitives' +import { Label } from '@radix-ui/react-dropdown-menu' export interface FormInputProps { name: string @@ -43,25 +43,30 @@ export function GeneralFormInput(props: FormInputProps): JSX.Element { const [input, setInput] = useState(props) if (props.type === 'checkbox') { + const StyledLabel = styled(Label, { + color: '$grayTextContrast', + fontSize: 13, + padding: '5px 10px', + cursor: 'default', + }) + return ( {input.options?.map((label, index) => ( - - {label} - - { - input.value[index] = arg - setInput(input) - props.onChange && - props.onChange( - input.options?.filter((_, i) => input.value[i]) - ) - }} - > - + + { + input.value[index] = arg + setInput(input) + props.onChange && + props.onChange( + input.options?.filter((_, i) => input.value[i]) + ) + }} + > + {label} ))} From 00bbb993bcd1092e83aab088bf33301c698f44a7 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Tue, 14 Jun 2022 10:01:20 -0700 Subject: [PATCH 4/5] Consistent naming --- packages/web/components/elements/Table.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web/components/elements/Table.tsx b/packages/web/components/elements/Table.tsx index 9dc16e45c..d854dedb3 100644 --- a/packages/web/components/elements/Table.tsx +++ b/packages/web/components/elements/Table.tsx @@ -123,7 +123,7 @@ export function Table(props: TableProps): JSX.Element { }, }} > - Add More + Create Date: Tue, 14 Jun 2022 10:14:37 -0700 Subject: [PATCH 5/5] Right align buttons, no need for a Cancel button --- packages/web/components/patterns/FormModal.tsx | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/web/components/patterns/FormModal.tsx b/packages/web/components/patterns/FormModal.tsx index 236f70e44..e9d56ac4a 100644 --- a/packages/web/components/patterns/FormModal.tsx +++ b/packages/web/components/patterns/FormModal.tsx @@ -82,19 +82,13 @@ export function FormModal(props: FormModalProps): JSX.Element { ))} -