From 87efb85a6e2657987fc37920a8ec80d6a90b5332 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 27 Jul 2022 13:11:04 +0800
Subject: [PATCH] Fix tests, Cont

---
 packages/api/test/routers/emails.test.ts | 31 ++++++++++--------------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/packages/api/test/routers/emails.test.ts b/packages/api/test/routers/emails.test.ts
index d313a75d3..26220d656 100644
--- a/packages/api/test/routers/emails.test.ts
+++ b/packages/api/test/routers/emails.test.ts
@@ -25,12 +25,6 @@ describe('Emails Router', () => {
 
     await createTestNewsletterEmail(user, newsletterEmail)
     token = process.env.PUBSUB_VERIFICATION_TOKEN!
-    sinon.replace(
-      sendNotification,
-      'sendMulticastPushNotifications',
-      sinon.fake.resolves(undefined)
-    )
-    sinon.replace(sendEmail, 'sendEmail', sinon.fake.resolves(true))
   })
 
   after(async () => {
@@ -45,15 +39,24 @@ describe('Emails Router', () => {
     const subject = 'test subject'
     const html = 'test html'
 
+    beforeEach(async () => {
+      sinon.replace(
+        sendNotification,
+        'sendMulticastPushNotifications',
+        sinon.fake.resolves(undefined)
+      )
+      sinon.replace(sendEmail, 'sendEmail', sinon.fake.resolves(true))
+    })
+
+    afterEach(() => {
+      sinon.restore()
+    })
+
     context('when email is a newsletter', () => {
       before(() => {
         sinon.replace(parser, 'isProbablyNewsletter', sinon.fake.resolves(true))
       })
 
-      after(() => {
-        sinon.restore()
-      })
-
       it('saves the email as a newsletter', async () => {
         const data = {
           message: {
@@ -81,10 +84,6 @@ describe('Emails Router', () => {
         sinon.replace(parser, 'isProbablyArticle', sinon.fake.resolves(true))
       })
 
-      after(() => {
-        sinon.restore()
-      })
-
       it('saves the email as an article', async () => {
         const data = {
           message: {
@@ -112,10 +111,6 @@ describe('Emails Router', () => {
         sinon.replace(parser, 'isProbablyArticle', sinon.fake.resolves(false))
       })
 
-      after(() => {
-        sinon.restore()
-      })
-
       it('forwards the email', async () => {
         const data = {
           message: {