From 826565a2c46cf79a405ae8340f1d05761c314789 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Wed, 21 Jun 2023 12:13:22 +0800 Subject: [PATCH] temporarily skip unsubscribing by url and mark them as unsubscribed automatically --- packages/api/src/services/subscriptions.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/api/src/services/subscriptions.ts b/packages/api/src/services/subscriptions.ts index d00d19f6c..59efb74ed 100644 --- a/packages/api/src/services/subscriptions.ts +++ b/packages/api/src/services/subscriptions.ts @@ -114,19 +114,14 @@ export const saveSubscription = async ({ export const unsubscribe = async (subscription: Subscription) => { let unsubscribed = false if (subscription.unsubscribeMailTo) { - // unsubscribe by sending email first + // unsubscribe by sending email unsubscribed = await sendUnsubscribeEmail( subscription.unsubscribeMailTo, subscription.newsletterEmail.address ) - } else if (subscription.unsubscribeHttpUrl) { - // unsubscribe by sending http request if no unsubscribeMailTo - unsubscribed = await sendUnsubscribeHttpRequest( - subscription.unsubscribeHttpUrl - ) - } else { - console.log('No unsubscribe method defined') } + // TODO: find a good way to unsubscribe by url if email fails or not provided + // because it often requires clicking a button on the page to unsubscribe if (!unsubscribed) { // update subscription status to unsubscribed if failed to unsubscribe