From 70d655f591c130d08d34cc527f50373ee708e2a9 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Thu, 9 Jun 2022 12:25:58 -0700 Subject: [PATCH] Add an uploadFileTest to verify GCS URLs are used for file:// objects --- .../OmnivoreKit/Sources/Models/DataModels/PDFItem.swift | 2 +- packages/api/test/resolvers/upload_file_request.test.ts | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/apple/OmnivoreKit/Sources/Models/DataModels/PDFItem.swift b/apple/OmnivoreKit/Sources/Models/DataModels/PDFItem.swift index 3380e48f1..fcfb3a23b 100644 --- a/apple/OmnivoreKit/Sources/Models/DataModels/PDFItem.swift +++ b/apple/OmnivoreKit/Sources/Models/DataModels/PDFItem.swift @@ -22,7 +22,7 @@ public struct PDFItem { objectID: item.objectID, itemID: item.unwrappedID, pdfURL: URL(string: item.unwrappedPageURLString), - localPdfURL: item.localPdfURL.flatMap { URL(string: $0) }, + localPdfURL: nil, // item.localPdfURL.flatMap { URL(string: $0) }, title: item.unwrappedID, slug: item.unwrappedSlug, readingProgress: item.readingProgress, diff --git a/packages/api/test/resolvers/upload_file_request.test.ts b/packages/api/test/resolvers/upload_file_request.test.ts index 150534524..7c19fb532 100644 --- a/packages/api/test/resolvers/upload_file_request.test.ts +++ b/packages/api/test/resolvers/upload_file_request.test.ts @@ -89,11 +89,18 @@ describe('uploadFileRequest API', () => { }) it('should create an article if create article is true', async () => { - const res = uploadFileRequest(authToken, 'https://www.google.com', clientRequestId, true).expect(200) + const res = await uploadFileRequest(authToken, 'https://www.google.com', clientRequestId, true) expect(res.body.data.uploadFileRequest.createdPageId).to.eql(clientRequestId) const page = await getPageById(clientRequestId) expect(page).to.be }) + + it('should not save a file:// URL', async () => { + const res = await uploadFileRequest(authToken, 'file://foo.bar', clientRequestId, true) + expect(res.body.data.uploadFileRequest.createdPageId).to.eql(clientRequestId) + const page = await getPageById(clientRequestId) + expect(page.url).to.startWith("https://") + }) }) }) })