From 15c964481a8d8a3a997ff314a23fc9d55124a0a1 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Mon, 26 Jun 2023 18:07:47 +0800 Subject: [PATCH 1/3] fix: tweet not saved * compare username ignoring case --- packages/content-handler/src/websites/nitter-handler.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/content-handler/src/websites/nitter-handler.ts b/packages/content-handler/src/websites/nitter-handler.ts index c938c9e96..b18a387df 100644 --- a/packages/content-handler/src/websites/nitter-handler.ts +++ b/packages/content-handler/src/websites/nitter-handler.ts @@ -288,7 +288,10 @@ export class NitterHandler extends ContentHandler { const tweet = parseTweet(item) // filter out replies - if (tweet && tweet.author.username.toLowerCase() === username) { + if ( + tweet && + tweet.author.username.toLowerCase() === username.toLowerCase() + ) { tweets.push(tweet) } } From 937be209282859664f89eb3cc0e8de9289435823 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Mon, 26 Jun 2023 21:11:04 +0800 Subject: [PATCH 2/3] fix: tweet format --- packages/content-handler/src/websites/nitter-handler.ts | 5 +---- packages/web/styles/articleInnerStyling.css | 5 +++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/content-handler/src/websites/nitter-handler.ts b/packages/content-handler/src/websites/nitter-handler.ts index b18a387df..257512cfc 100644 --- a/packages/content-handler/src/websites/nitter-handler.ts +++ b/packages/content-handler/src/websites/nitter-handler.ts @@ -381,10 +381,7 @@ export class NitterHandler extends ContentHandler { ) .join('\n') - tweetsContent += ` -

${text}

- ${includesHtml} - ` + tweetsContent += `

${text}

${includesHtml}` } const tweetUrl = ` diff --git a/packages/web/styles/articleInnerStyling.css b/packages/web/styles/articleInnerStyling.css index 902f255c6..e2ef4e586 100644 --- a/packages/web/styles/articleInnerStyling.css +++ b/packages/web/styles/articleInnerStyling.css @@ -586,3 +586,8 @@ on smaller screens we display the note icon -webkit-line-clamp: 2; overflow: hidden; } + +.article-inner-css ._omnivore_tweet_content { + white-space: pre-wrap; + overflow-wrap: break-word; +} From 607e22ce94a10260c040de4f657dd0b625e0886c Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Mon, 26 Jun 2023 21:46:52 +0800 Subject: [PATCH 3/3] fix: tweet with no text failed to save --- packages/content-handler/src/websites/nitter-handler.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/content-handler/src/websites/nitter-handler.ts b/packages/content-handler/src/websites/nitter-handler.ts index 257512cfc..d5a1a4e83 100644 --- a/packages/content-handler/src/websites/nitter-handler.ts +++ b/packages/content-handler/src/websites/nitter-handler.ts @@ -350,7 +350,7 @@ export class NitterHandler extends ContentHandler { '_normal', '_400x400' )}` - const description = _.escape(tweet.text) + const description = _.escape(tweet.text) || escapedTitle const imageDomain = domain.toLowerCase() === 'twitter.com' ? 'https://pbs.twimg.com' @@ -402,6 +402,7 @@ export class NitterHandler extends ContentHandler { +