From 64ee55d82990933fc8ceed2a3d349383e99844d6 Mon Sep 17 00:00:00 2001 From: Satindar Dhillon Date: Mon, 12 Sep 2022 22:16:31 -0700 Subject: [PATCH] remove tap handler on FeedCard --- .../App/Views/Home/Components/FeedCardNavigationLink.swift | 4 +--- .../Sources/Views/FeedItem/HomeFeedCardView.swift | 7 +------ 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/apple/OmnivoreKit/Sources/App/Views/Home/Components/FeedCardNavigationLink.swift b/apple/OmnivoreKit/Sources/App/Views/Home/Components/FeedCardNavigationLink.swift index 9a92b2fba..782a9cf82 100644 --- a/apple/OmnivoreKit/Sources/App/Views/Home/Components/FeedCardNavigationLink.swift +++ b/apple/OmnivoreKit/Sources/App/Views/Home/Components/FeedCardNavigationLink.swift @@ -26,9 +26,7 @@ struct FeedCardNavigationLink: View { .onAppear { Task { await viewModel.itemAppeared(item: item, dataService: dataService, audioSession: audioSession) } } - FeedCard(item: item) { - // TODO: remove closure - } + FeedCard(item: item) } } } diff --git a/apple/OmnivoreKit/Sources/Views/FeedItem/HomeFeedCardView.swift b/apple/OmnivoreKit/Sources/Views/FeedItem/HomeFeedCardView.swift index daac1fc81..71223ff7a 100644 --- a/apple/OmnivoreKit/Sources/Views/FeedItem/HomeFeedCardView.swift +++ b/apple/OmnivoreKit/Sources/Views/FeedItem/HomeFeedCardView.swift @@ -3,12 +3,10 @@ import SwiftUI import Utils public struct FeedCard: View { - let tapHandler: () -> Void @ObservedObject var item: LinkedItem - public init(item: LinkedItem, tapHandler: @escaping () -> Void) { + public init(item: LinkedItem) { self.item = item - self.tapHandler = tapHandler } public var body: some View { @@ -77,9 +75,6 @@ public struct FeedCard: View { } } .padding(.top, 8) - .onTapGesture { - tapHandler() - } } } .padding(.top, 10)