prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Allow setting margin on iPhone, fix bug with reset button

Browse source 
After resetting properties we need to call into web to update.
This commit is contained in:
Jackson Harper 2023-05-26 10:16:17 +08:00
parent 91c0271ea3
commit 5fa8660c8b
1 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
apple/OmnivoreKit/Sources/Views/FontSizeAdjustmentPopoverView.swift
View file

@ -222,20 +222,23 @@ public enum WebFont: String, CaseIterable {
var marginSlider: some View {
HStack {
let minValue = UIDevice.isIPad ? 40 : 70
let stepSize = UIDevice.isIPad ? 10 : 2
Button(action: {
storedMaxWidthPercentage = max(storedMaxWidthPercentage - 10, 40)
storedMaxWidthPercentage = max(storedMaxWidthPercentage - stepSize, minValue)
updateReaderPreferences()
}, label: { Image("margin-smaller", bundle: .module) })
.frame(width: 25, height: 25, alignment: .center)
CustomSlider(value: $storedMaxWidthPercentage, minValue: 40, maxValue: 100) { _ in
CustomSlider(value: $storedMaxWidthPercentage, minValue: minValue, maxValue: 100) { _ in
updateReaderPreferences()
}
.padding(.horizontal, 10)
.tint(Color(hex: "#D9D9D9"))
Button(action: {
storedMaxWidthPercentage = min(storedMaxWidthPercentage + 10, 100)
storedMaxWidthPercentage = min(storedMaxWidthPercentage + stepSize, 100)
updateReaderPreferences()
}, label: { Image("margin-larger", bundle: .module) })
@ -351,15 +354,13 @@ public enum WebFont: String, CaseIterable {
.padding(.vertical, 10)
Group {
if UIDevice.isIPad {
Text("Margin")
.font(Font.system(size: 14))
.frame(maxWidth: .infinity, alignment: .leading)
Text("Margin")
.font(Font.system(size: 14))
.frame(maxWidth: .infinity, alignment: .leading)
marginSlider
.padding(.top, 5)
.padding(.bottom, 10)
}
marginSlider
.padding(.top, 5)
.padding(.bottom, 10)
Text("Line Height")
.font(Font.system(size: 14))
@ -408,8 +409,9 @@ public enum WebFont: String, CaseIterable {
enableHighlightOnRelease = false
preferredFont = WebFont.inter.rawValue
prefersHighContrastText = true
enableHighlightOnRelease = false
updateReaderPreferences()
}, label: {
Text("Reset")
.font(Font.system(size: 12, weight: .bold))