From 5312c31ea747cd2c6e455ecab469caef9b79c35c Mon Sep 17 00:00:00 2001
From: Jackson Harper <jacksonh@gmail.com>
Date: Mon, 17 Oct 2022 20:45:04 +0800
Subject: [PATCH] Dont crash if a popular read is not available on signup

---
 .../api/src/routers/auth/mobile/sign_up.ts    |  1 +
 packages/api/src/services/popular_reads.ts    | 35 +++++++++++--------
 2 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/packages/api/src/routers/auth/mobile/sign_up.ts b/packages/api/src/routers/auth/mobile/sign_up.ts
index fea03ef97..9bfc36c78 100644
--- a/packages/api/src/routers/auth/mobile/sign_up.ts
+++ b/packages/api/src/routers/auth/mobile/sign_up.ts
@@ -72,6 +72,7 @@ export async function createMobileEmailSignUpResponse(
       json: {},
     }
   } catch (e) {
+    console.log('error', e)
     return signUpFailedPayload
   }
 }
diff --git a/packages/api/src/services/popular_reads.ts b/packages/api/src/services/popular_reads.ts
index db2933c3d..4adb3f569 100644
--- a/packages/api/src/services/popular_reads.ts
+++ b/packages/api/src/services/popular_reads.ts
@@ -32,22 +32,27 @@ const popularRead = (key: string): PopularRead | undefined => {
     return undefined
   }
 
-  const content = readFileSync(
-    path.resolve(__dirname, `popular_reads/${key}-content.html`),
-    'utf8'
-  )
-  const originalHtml = readFileSync(
-    path.resolve(__dirname, `./popular_reads/${key}-original.html`),
-    'utf8'
-  )
-  if (!content || !originalHtml) {
-    return undefined
-  }
+  try {
+    const content = readFileSync(
+      path.resolve(__dirname, `popular_reads/${key}-content.html`),
+      'utf8'
+    )
+    const originalHtml = readFileSync(
+      path.resolve(__dirname, `./popular_reads/${key}-original.html`),
+      'utf8'
+    )
+    if (!content || !originalHtml) {
+      return undefined
+    }
 
-  return {
-    ...metadata,
-    content,
-    originalHtml,
+    return {
+      ...metadata,
+      content,
+      originalHtml,
+    }
+  } catch (e) {
+    console.log('error adding popular read', e)
+    return undefined
   }
 }