prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve scaling of thumbnails, better placeholder while loading

Browse source
This commit is contained in:
Jackson Harper 2023-07-19 11:16:21 +08:00
parent 82a657b82e
commit 4f40afa5b7
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apple/Omnivore.xcodeproj/project.pbxproj
View file

@ -1400,7 +1400,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 12.0;
MARKETING_VERSION = 1.27.0;
MARKETING_VERSION = 1.28.0;
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = app.omnivore.app;
@ -1435,7 +1435,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 12.0;
MARKETING_VERSION = 1.27.0;
MARKETING_VERSION = 1.28.0;
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = app.omnivore.app;
PRODUCT_NAME = "$(TARGET_NAME)";
@ -1490,7 +1490,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.27.0;
MARKETING_VERSION = 1.28.0;
PRODUCT_BUNDLE_IDENTIFIER = app.omnivore.app;
PRODUCT_NAME = Omnivore;
PROVISIONING_PROFILE_SPECIFIER = "";
@ -1831,7 +1831,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.27.0;
MARKETING_VERSION = 1.28.0;
PRODUCT_BUNDLE_IDENTIFIER = app.omnivore.app;
PRODUCT_NAME = Omnivore;
PROVISIONING_PROFILE_SPECIFIER = "";

10
apple/OmnivoreKit/Sources/Views/FeedItem/LibraryFeatureCard.swift
View file

@ -37,11 +37,14 @@ public struct LibraryFeatureCard: View {
AsyncImage(url: imageURL) { phase in
switch phase {
case .empty:
EmptyView()
Color.systemBackground
.frame(width: 146, height: 90)
case let .success(image):
image.resizable()
.aspectRatio(contentMode: .fit)
.resizable()
.scaledToFill()
.frame(width: 146, height: 90)
.clipped()
case .failure:
fallbackImage
@ -50,7 +53,8 @@ public struct LibraryFeatureCard: View {
// we need to add this currently unused fallback
// to handle any new cases that might be added
// in the future:
EmptyView()
Color.systemBackground
.frame(width: 146, height: 90)
}
}
} else {