From 477b5d7d24a955d73e9c1c0007115d7830f79edd Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Fri, 11 Nov 2022 14:53:46 +0800
Subject: [PATCH] Fix typeorm issue

---
 packages/api/src/entity/newsletter_email.ts | 2 +-
 packages/api/src/services/create_user.ts    | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/api/src/entity/newsletter_email.ts b/packages/api/src/entity/newsletter_email.ts
index bdd4beac0..0399fbc7b 100644
--- a/packages/api/src/entity/newsletter_email.ts
+++ b/packages/api/src/entity/newsletter_email.ts
@@ -22,7 +22,7 @@ export class NewsletterEmail {
   user!: User
 
   @Column('varchar', { nullable: true })
-  confirmationCode?: string
+  confirmationCode?: string | null
 
   @CreateDateColumn()
   createdAt!: Date
diff --git a/packages/api/src/services/create_user.ts b/packages/api/src/services/create_user.ts
index 2d6267b6c..e23467e25 100644
--- a/packages/api/src/services/create_user.ts
+++ b/packages/api/src/services/create_user.ts
@@ -106,9 +106,7 @@ const validateInvite = async (
     return false
   }
   const membershipRepo = entityManager.getRepository(GroupMembership)
-  const numMembers = await membershipRepo.count({
-    where: { invite: invite },
-  })
+  const numMembers = await membershipRepo.countBy({ invite: { id: invite.id } })
   if (numMembers >= invite.maxMembers) {
     console.log('rejecting invite, too many users', invite, numMembers)
     return false