From 7f81771e4a14bfd2ed0b8a76ec4adb85c5c6d3cd Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Wed, 14 Jun 2023 12:58:21 +0800 Subject: [PATCH 1/2] Remove some debugging --- .../components/templates/article/HighlightsLayer.tsx | 11 ++++++----- .../web/components/templates/article/Notebook.tsx | 2 -- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/packages/web/components/templates/article/HighlightsLayer.tsx b/packages/web/components/templates/article/HighlightsLayer.tsx index 5c4ad6aa6..f79fc3cf2 100644 --- a/packages/web/components/templates/article/HighlightsLayer.tsx +++ b/packages/web/components/templates/article/HighlightsLayer.tsx @@ -76,13 +76,15 @@ export function HighlightsLayer(props: HighlightsLayerProps): JSX.Element { const focusedHighlightMousePos = useRef({ pageX: 0, pageY: 0 }) const [currentHighlightIdx, setCurrentHighlightIdx] = useState(0) - const [focusedHighlight, setFocusedHighlight] = - useState(undefined) + const [focusedHighlight, setFocusedHighlight] = useState< + Highlight | undefined + >(undefined) const [selectionData, setSelectionData] = useSelection(highlightLocations) - const [labelsTarget, setLabelsTarget] = - useState(undefined) + const [labelsTarget, setLabelsTarget] = useState( + undefined + ) const createHighlightFromSelection = useCallback( async ( @@ -346,7 +348,6 @@ export function HighlightsLayer(props: HighlightsLayerProps): JSX.Element { highlightModalAction: 'addComment', }) } else { - console.log('sending page tapped') window?.webkit?.messageHandlers.viewerAction?.postMessage({ actionID: 'pageTapped', }) diff --git a/packages/web/components/templates/article/Notebook.tsx b/packages/web/components/templates/article/Notebook.tsx index de2bc0b74..4410847a1 100644 --- a/packages/web/components/templates/article/Notebook.tsx +++ b/packages/web/components/templates/article/Notebook.tsx @@ -72,8 +72,6 @@ export function Notebook(props: NotebookProps): JSX.Element { ) const [, updateState] = useState({}) - console.log('props.showConfirmDeleteNote', props.showConfirmDeleteNote) - const annotationsReducer = ( state: AnnotationInfo, action: { From aaf6bb617ffb1bcef998a1f790c53742728301cc Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Wed, 14 Jun 2023 13:19:39 +0800 Subject: [PATCH 2/2] Remove backend events that we dont need to watch --- packages/api/src/resolvers/article/index.ts | 29 --------------------- 1 file changed, 29 deletions(-) diff --git a/packages/api/src/resolvers/article/index.ts b/packages/api/src/resolvers/article/index.ts index 8c3d51d83..00367ba0e 100644 --- a/packages/api/src/resolvers/article/index.ts +++ b/packages/api/src/resolvers/article/index.ts @@ -438,15 +438,6 @@ export const getArticleResolver: ResolverFn< format === ArticleFormat.Distiller || !!graphqlFields(info).article.originalHtml - analytics.track({ - userId: claims?.uid, - event: 'link_fetched', - properties: { - slug, - env: env.server.apiEnv, - }, - }) - // We allow the backend to use the ID instead of a slug to fetch the article const page = (await getPageByParam( @@ -900,15 +891,6 @@ export const searchResolver = authorized< const searchQuery = parseSearchQuery(params.query || undefined) - analytics.track({ - userId: claims.uid, - event: 'search', - properties: { - env: env.server.apiEnv, - ...searchQuery, - }, - }) - let results: SearchItemData[] let totalCount: number @@ -1036,17 +1018,6 @@ export const updatesSinceResolver = authorized< return { errorCodes: [UpdatesSinceErrorCode.Unauthorized] } } - analytics.track({ - userId: uid, - event: 'updatesSince', - properties: { - env: env.server.apiEnv, - since, - first, - after, - }, - }) - const sort = sortParamsToElasticSort(sortParams) const startCursor = after || ''