prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #554 from omnivore-app/fix/feed-list-spacing

Browse source 
Add some padding and min cell height on the iOS list view
This commit is contained in:
Jackson Harper 2022-05-05 12:07:47 -07:00 committed by GitHub
commit 4000f66ebf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
apple/OmnivoreKit/Sources/Views/FeedItem/HomeFeedCardView.swift
View file

@ -12,12 +12,11 @@ public struct FeedCard: View {
public var body: some View {
VStack {
HStack(alignment: .top, spacing: 6) {
VStack(alignment: .leading, spacing: 6) {
VStack(alignment: .leading, spacing: 4) {
Text(item.unwrappedTitle)
.font(.appSubheadline)
.font(.appCallout)
.foregroundColor(.appGrayTextContrast)
.lineLimit(2)
.frame(maxWidth: .infinity, alignment: .leading)
.fixedSize(horizontal: false, vertical: true)
if let author = item.author {
Text("By \(author)")
@ -34,7 +33,13 @@ public struct FeedCard: View {
.lineLimit(1)
}
}
.frame(maxWidth: .infinity)
.frame(
minWidth: 0,
maxWidth: .infinity,
minHeight: 0,
maxHeight: .infinity,
alignment: .topLeading
)
.multilineTextAlignment(.leading)
.padding(0)
@ -52,7 +57,7 @@ public struct FeedCard: View {
.frame(width: 80, height: 80)
.cornerRadius(6)
} else {
EmptyView()
EmptyView().frame(width: 80, height: 80, alignment: .top)
}
}
}
@ -68,8 +73,19 @@ public struct FeedCard: View {
Spacer()
}
}
.padding(.bottom, 5)
.padding(.top, 8)
.padding(.bottom, 2)
}
.padding(.top, 5)
.padding(.top, 16)
.padding(.bottom, 8)
.frame(
minWidth: nil,
idealWidth: nil,
maxWidth: nil,
minHeight: 70,
idealHeight: nil,
maxHeight: nil,
alignment: .topLeading
)
}
}