From c59cf9cf659f61d5bffcf47db735110b74f091e4 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 1 Jun 2022 19:01:14 +0800
Subject: [PATCH 01/15] Add labels in highlight properties

---
 .../db/elastic_migrations/index_settings.json | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/packages/db/elastic_migrations/index_settings.json b/packages/db/elastic_migrations/index_settings.json
index d5dca4841..fabe31d49 100644
--- a/packages/db/elastic_migrations/index_settings.json
+++ b/packages/db/elastic_migrations/index_settings.json
@@ -90,6 +90,27 @@
           },
           "updatedAt": {
             "type": "date"
+          },
+          "labels": {
+            "type": "nested",
+            "properties": {
+              "id": {
+                "type": "keyword"
+              },
+              "name": {
+                "type": "keyword",
+                "normalizer": "lowercase_normalizer"
+              },
+              "color": {
+                "type": "keyword"
+              },
+              "description": {
+                "type": "text"
+              },
+              "createdAt": {
+                "type": "date"
+              }
+            }
           }
         }
       },

From 04f7fdc31f162ce84cebb4ac57b798fd4eab54ef Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 1 Jun 2022 19:01:26 +0800
Subject: [PATCH 02/15] Add labels in highlight type

---
 packages/api/src/elastic/types.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/api/src/elastic/types.ts b/packages/api/src/elastic/types.ts
index 030c2a98e..78c298678 100644
--- a/packages/api/src/elastic/types.ts
+++ b/packages/api/src/elastic/types.ts
@@ -163,6 +163,7 @@ export interface Highlight {
   annotation?: string | null
   sharedAt?: Date | null
   updatedAt?: Date | null
+  labels?: Label[]
 }
 
 export interface Page {

From bdda54d54aee3ce4b9f2ca49a7e52d9ca295da33 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Mon, 6 Jun 2022 19:15:03 +0800
Subject: [PATCH 03/15] Add set Labels For Highlight data access method

---
 packages/api/src/elastic/labels.ts | 57 ++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/packages/api/src/elastic/labels.ts b/packages/api/src/elastic/labels.ts
index 4741fd9b0..e69f8312e 100644
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@@ -198,3 +198,60 @@ export const updateLabelInPage = async (
     return false
   }
 }
+
+export const setLabelsForHighlight = async (
+  highlightId: string,
+  labels: Label[],
+  ctx: PageContext
+): Promise<boolean> => {
+  try {
+    const { body } = await client.updateByQuery({
+      index: INDEX_ALIAS,
+      body: {
+        script: {
+          source: `ctx._source.highlights[0].labels = params.labels`,
+          lang: 'painless',
+          params: {
+            labels: labels,
+          },
+        },
+        query: {
+          nested: {
+            path: 'highlights',
+            query: {
+              term: {
+                'highlights.id': highlightId,
+              },
+            },
+          },
+        },
+      },
+      refresh: ctx.refresh,
+      conflicts: 'proceed', // ignore conflicts
+    })
+
+    if (!body.updated) {
+      return false
+    }
+
+    for (const label of labels) {
+      await ctx.pubsub.entityCreated<Label & { highlightId: string }>(
+        EntityType.LABEL,
+        { highlightId, ...label },
+        ctx.uid
+      )
+    }
+
+    return true
+  } catch (e) {
+    if (
+      e instanceof ResponseError &&
+      e.message === 'document_missing_exception'
+    ) {
+      console.log('highlight has been deleted', highlightId)
+      return false
+    }
+    console.error('failed to set labels for highlight in elastic', e)
+    return false
+  }
+}

From 9655a87bab5f04b028c62ea86f58c466c049479d Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Mon, 6 Jun 2022 19:15:10 +0800
Subject: [PATCH 04/15] Add test for set Labels For Highlight data access
 method

---
 packages/api/test/elastic/index.test.ts | 53 ++++++++++++++++++++++++-
 1 file changed, 52 insertions(+), 1 deletion(-)

diff --git a/packages/api/test/elastic/index.test.ts b/packages/api/test/elastic/index.test.ts
index c899c88e6..97fba7520 100644
--- a/packages/api/test/elastic/index.test.ts
+++ b/packages/api/test/elastic/index.test.ts
@@ -4,6 +4,7 @@ import { InFilter, ReadFilter } from '../../src/utils/search'
 import {
   ArticleSavingRequestStatus,
   Highlight,
+  Label,
   Page,
   PageContext,
   PageType,
@@ -18,7 +19,7 @@ import {
   searchPages,
   updatePage,
 } from '../../src/elastic/pages'
-import { addLabelInPage } from '../../src/elastic/labels'
+import { addLabelInPage, setLabelsForHighlight } from '../../src/elastic/labels'
 import {
   addHighlightToPage,
   searchHighlights,
@@ -250,4 +251,54 @@ describe('elastic api', () => {
       expect(searchResults[0].id).to.eq(highlightId)
     })
   })
+
+  describe('setLabelsForHighlight', () => {
+    const page = {
+      id: 'testPageId',
+      hash: 'test set labels for highlight hash',
+      userId: userId,
+      pageType: PageType.Article,
+      title: 'test set labels for highlight title',
+      content: '<p>test</p>',
+      slug: 'test set labels for highlight slug',
+      createdAt: new Date(),
+      savedAt: new Date(),
+      readingProgressPercent: 100,
+      readingProgressAnchorIndex: 0,
+      url: 'https://blog.omnivore.app/p/setting-labels-for-highlight',
+      state: ArticleSavingRequestStatus.Succeeded,
+    }
+    const highlightId = 'highlightId'
+    const label: Label = {
+      id: 'test label id',
+      name: 'test label',
+      color: '#07D2D1',
+    }
+
+    before(async () => {
+      // create a testing page
+      await createPage(page, ctx)
+
+      const highlightData: Highlight = {
+        patch: 'test set labels patch',
+        quote: 'test set labels quote',
+        shortId: 'test set labels shortId',
+        id: highlightId,
+        userId: page.userId,
+        createdAt: new Date(),
+      }
+
+      await addHighlightToPage(page.id, highlightData, ctx)
+    })
+
+    after(async () => {
+      await deletePage(page.id, ctx)
+    })
+
+    it('sets labels for highlights', async () => {
+      const result = await setLabelsForHighlight(highlightId, [label], ctx)
+
+      expect(result).to.be.true
+    })
+  })
 })

From 427b58eeddfec6cebe7ae5ab18cc42c1cbe36138 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Mon, 6 Jun 2022 19:15:51 +0800
Subject: [PATCH 05/15] Add set labels for highlight gql schema

---
 packages/api/src/generated/graphql.ts     | 14 ++++++++++++++
 packages/api/src/generated/schema.graphql |  6 ++++++
 packages/api/src/schema.ts                |  6 ++++++
 3 files changed, 26 insertions(+)

diff --git a/packages/api/src/generated/graphql.ts b/packages/api/src/generated/graphql.ts
index 7cff57dde..a98854237 100644
--- a/packages/api/src/generated/graphql.ts
+++ b/packages/api/src/generated/graphql.ts
@@ -883,6 +883,7 @@ export type Mutation = {
   setDeviceToken: SetDeviceTokenResult;
   setFollow: SetFollowResult;
   setLabels: SetLabelsResult;
+  setLabelsForHighlight: SetLabelsResult;
   setLinkArchived: ArchiveLinkResult;
   setShareArticle: SetShareArticleResult;
   setShareHighlight: SetShareHighlightResult;
@@ -1054,6 +1055,11 @@ export type MutationSetLabelsArgs = {
 };
 
 
+export type MutationSetLabelsForHighlightArgs = {
+  input: SetLabelsForHighlightInput;
+};
+
+
 export type MutationSetLinkArchivedArgs = {
   input: ArchiveLinkInput;
 };
@@ -1618,6 +1624,11 @@ export enum SetLabelsErrorCode {
   Unauthorized = 'UNAUTHORIZED'
 }
 
+export type SetLabelsForHighlightInput = {
+  highlightId: Scalars['ID'];
+  labelIds: Array<Scalars['ID']>;
+};
+
 export type SetLabelsInput = {
   labelIds: Array<Scalars['ID']>;
   pageId: Scalars['ID'];
@@ -2544,6 +2555,7 @@ export type ResolversTypes = {
   SetFollowSuccess: ResolverTypeWrapper<SetFollowSuccess>;
   SetLabelsError: ResolverTypeWrapper<SetLabelsError>;
   SetLabelsErrorCode: SetLabelsErrorCode;
+  SetLabelsForHighlightInput: SetLabelsForHighlightInput;
   SetLabelsInput: SetLabelsInput;
   SetLabelsResult: ResolversTypes['SetLabelsError'] | ResolversTypes['SetLabelsSuccess'];
   SetLabelsSuccess: ResolverTypeWrapper<SetLabelsSuccess>;
@@ -2845,6 +2857,7 @@ export type ResolversParentTypes = {
   SetFollowResult: ResolversParentTypes['SetFollowError'] | ResolversParentTypes['SetFollowSuccess'];
   SetFollowSuccess: SetFollowSuccess;
   SetLabelsError: SetLabelsError;
+  SetLabelsForHighlightInput: SetLabelsForHighlightInput;
   SetLabelsInput: SetLabelsInput;
   SetLabelsResult: ResolversParentTypes['SetLabelsError'] | ResolversParentTypes['SetLabelsSuccess'];
   SetLabelsSuccess: SetLabelsSuccess;
@@ -3588,6 +3601,7 @@ export type MutationResolvers<ContextType = ResolverContext, ParentType extends
   setDeviceToken?: Resolver<ResolversTypes['SetDeviceTokenResult'], ParentType, ContextType, RequireFields<MutationSetDeviceTokenArgs, 'input'>>;
   setFollow?: Resolver<ResolversTypes['SetFollowResult'], ParentType, ContextType, RequireFields<MutationSetFollowArgs, 'input'>>;
   setLabels?: Resolver<ResolversTypes['SetLabelsResult'], ParentType, ContextType, RequireFields<MutationSetLabelsArgs, 'input'>>;
+  setLabelsForHighlight?: Resolver<ResolversTypes['SetLabelsResult'], ParentType, ContextType, RequireFields<MutationSetLabelsForHighlightArgs, 'input'>>;
   setLinkArchived?: Resolver<ResolversTypes['ArchiveLinkResult'], ParentType, ContextType, RequireFields<MutationSetLinkArchivedArgs, 'input'>>;
   setShareArticle?: Resolver<ResolversTypes['SetShareArticleResult'], ParentType, ContextType, RequireFields<MutationSetShareArticleArgs, 'input'>>;
   setShareHighlight?: Resolver<ResolversTypes['SetShareHighlightResult'], ParentType, ContextType, RequireFields<MutationSetShareHighlightArgs, 'input'>>;
diff --git a/packages/api/src/generated/schema.graphql b/packages/api/src/generated/schema.graphql
index 53b41e78a..1a4f4da94 100644
--- a/packages/api/src/generated/schema.graphql
+++ b/packages/api/src/generated/schema.graphql
@@ -786,6 +786,7 @@ type Mutation {
   setDeviceToken(input: SetDeviceTokenInput!): SetDeviceTokenResult!
   setFollow(input: SetFollowInput!): SetFollowResult!
   setLabels(input: SetLabelsInput!): SetLabelsResult!
+  setLabelsForHighlight(input: SetLabelsForHighlightInput!): SetLabelsResult!
   setLinkArchived(input: ArchiveLinkInput!): ArchiveLinkResult!
   setShareArticle(input: SetShareArticleInput!): SetShareArticleResult!
   setShareHighlight(input: SetShareHighlightInput!): SetShareHighlightResult!
@@ -1172,6 +1173,11 @@ enum SetLabelsErrorCode {
   UNAUTHORIZED
 }
 
+input SetLabelsForHighlightInput {
+  highlightId: ID!
+  labelIds: [ID!]!
+}
+
 input SetLabelsInput {
   labelIds: [ID!]!
   pageId: ID!
diff --git a/packages/api/src/schema.ts b/packages/api/src/schema.ts
index 236056d1f..e2fc974f9 100755
--- a/packages/api/src/schema.ts
+++ b/packages/api/src/schema.ts
@@ -1714,6 +1714,11 @@ const schema = gql`
     NOT_FOUND
   }
 
+  input SetLabelsForHighlightInput {
+    highlightId: ID!
+    labelIds: [ID!]!
+  }
+
   # Mutations
   type Mutation {
     googleLogin(input: GoogleLoginInput!): LoginResult!
@@ -1782,6 +1787,7 @@ const schema = gql`
     setWebhook(input: SetWebhookInput!): SetWebhookResult!
     deleteWebhook(id: ID!): DeleteWebhookResult!
     revokeApiKey(id: ID!): RevokeApiKeyResult!
+    setLabelsForHighlight(input: SetLabelsForHighlightInput!): SetLabelsResult!
   }
 
   # FIXME: remove sort from feedArticles after all cached tabs are closed

From 93c0e53d1dc1dc35d57c74f261ca27b185a733c7 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 14:59:11 +0800
Subject: [PATCH 06/15] Generate setLabelsForHighlight graphql code

---
 packages/api/src/generated/graphql.ts     | 228 +++++++++++-----------
 packages/api/src/generated/schema.graphql |  82 ++++----
 2 files changed, 155 insertions(+), 155 deletions(-)

diff --git a/packages/api/src/generated/graphql.ts b/packages/api/src/generated/graphql.ts
index a98854237..6633d814f 100644
--- a/packages/api/src/generated/graphql.ts
+++ b/packages/api/src/generated/graphql.ts
@@ -111,8 +111,8 @@ export type Article = {
   readingProgressPercent: Scalars['Float'];
   savedAt: Scalars['Date'];
   savedByViewer?: Maybe<Scalars['Boolean']>;
-  sharedComment?: Maybe<Scalars['String']>;
   shareInfo?: Maybe<LinkShareInfo>;
+  sharedComment?: Maybe<Scalars['String']>;
   siteIcon?: Maybe<Scalars['String']>;
   siteName?: Maybe<Scalars['String']>;
   slug: Scalars['String'];
@@ -191,6 +191,11 @@ export type ArticleSavingRequestSuccess = {
   articleSavingRequest: ArticleSavingRequest;
 };
 
+export type ArticleSuccess = {
+  __typename?: 'ArticleSuccess';
+  article: Article;
+};
+
 export type ArticlesError = {
   __typename?: 'ArticlesError';
   errorCodes: Array<ArticlesErrorCode>;
@@ -208,11 +213,6 @@ export type ArticlesSuccess = {
   pageInfo: PageInfo;
 };
 
-export type ArticleSuccess = {
-  __typename?: 'ArticleSuccess';
-  article: Article;
-};
-
 export enum ContentReader {
   Pdf = 'PDF',
   Web = 'WEB'
@@ -774,6 +774,22 @@ export type LinkShareInfo = {
   title: Scalars['String'];
 };
 
+export type LogOutError = {
+  __typename?: 'LogOutError';
+  errorCodes: Array<LogOutErrorCode>;
+};
+
+export enum LogOutErrorCode {
+  LogOutFailed = 'LOG_OUT_FAILED'
+}
+
+export type LogOutResult = LogOutError | LogOutSuccess;
+
+export type LogOutSuccess = {
+  __typename?: 'LogOutSuccess';
+  message?: Maybe<Scalars['String']>;
+};
+
 export type LoginError = {
   __typename?: 'LoginError';
   errorCodes: Array<LoginErrorCode>;
@@ -800,22 +816,6 @@ export type LoginSuccess = {
   me: User;
 };
 
-export type LogOutError = {
-  __typename?: 'LogOutError';
-  errorCodes: Array<LogOutErrorCode>;
-};
-
-export enum LogOutErrorCode {
-  LogOutFailed = 'LOG_OUT_FAILED'
-}
-
-export type LogOutResult = LogOutError | LogOutSuccess;
-
-export type LogOutSuccess = {
-  __typename?: 'LogOutSuccess';
-  message?: Maybe<Scalars['String']>;
-};
-
 export type MergeHighlightError = {
   __typename?: 'MergeHighlightError';
   errorCodes: Array<MergeHighlightErrorCode>;
@@ -870,8 +870,8 @@ export type Mutation = {
   generateApiKey: GenerateApiKeyResult;
   googleLogin: LoginResult;
   googleSignup: GoogleSignupResult;
-  login: LoginResult;
   logOut: LogOutResult;
+  login: LoginResult;
   mergeHighlight: MergeHighlightResult;
   reportItem: ReportItemResult;
   revokeApiKey: RevokeApiKeyResult;
@@ -1237,8 +1237,8 @@ export type Query = {
   __typename?: 'Query';
   apiKeys: ApiKeysResult;
   article: ArticleResult;
-  articles: ArticlesResult;
   articleSavingRequest: ArticleSavingRequestResult;
+  articles: ArticlesResult;
   feedArticles: FeedArticlesResult;
   getFollowers: GetFollowersResult;
   getFollowing: GetFollowingResult;
@@ -1265,6 +1265,11 @@ export type QueryArticleArgs = {
 };
 
 
+export type QueryArticleSavingRequestArgs = {
+  id: Scalars['ID'];
+};
+
+
 export type QueryArticlesArgs = {
   after?: InputMaybe<Scalars['String']>;
   first?: InputMaybe<Scalars['Int']>;
@@ -1275,11 +1280,6 @@ export type QueryArticlesArgs = {
 };
 
 
-export type QueryArticleSavingRequestArgs = {
-  id: Scalars['ID'];
-};
-
-
 export type QueryFeedArticlesArgs = {
   after?: InputMaybe<Scalars['String']>;
   first?: InputMaybe<Scalars['Int']>;
@@ -1743,6 +1743,13 @@ export type SetWebhookSuccess = {
   webhook: Webhook;
 };
 
+export type ShareStats = {
+  __typename?: 'ShareStats';
+  readDuration: Scalars['Int'];
+  saveCount: Scalars['Int'];
+  viewCount: Scalars['Int'];
+};
+
 export type SharedArticleError = {
   __typename?: 'SharedArticleError';
   errorCodes: Array<SharedArticleErrorCode>;
@@ -1759,13 +1766,6 @@ export type SharedArticleSuccess = {
   article: Article;
 };
 
-export type ShareStats = {
-  __typename?: 'ShareStats';
-  readDuration: Scalars['Int'];
-  saveCount: Scalars['Int'];
-  viewCount: Scalars['Int'];
-};
-
 export type SignupError = {
   __typename?: 'SignupError';
   errorCodes: Array<Maybe<SignupErrorCode>>;
@@ -1847,6 +1847,12 @@ export type Subscription = {
   url?: Maybe<Scalars['String']>;
 };
 
+export enum SubscriptionStatus {
+  Active = 'ACTIVE',
+  Deleted = 'DELETED',
+  Unsubscribed = 'UNSUBSCRIBED'
+}
+
 export type SubscriptionsError = {
   __typename?: 'SubscriptionsError';
   errorCodes: Array<SubscriptionsErrorCode>;
@@ -1864,12 +1870,6 @@ export type SubscriptionsSuccess = {
   subscriptions: Array<Subscription>;
 };
 
-export enum SubscriptionStatus {
-  Active = 'ACTIVE',
-  Deleted = 'DELETED',
-  Unsubscribed = 'UNSUBSCRIBED'
-}
-
 export type UnsubscribeError = {
   __typename?: 'UnsubscribeError';
   errorCodes: Array<UnsubscribeErrorCode>;
@@ -2186,6 +2186,11 @@ export type UserPersonalization = {
 
 export type UserResult = UserError | UserSuccess;
 
+export type UserSuccess = {
+  __typename?: 'UserSuccess';
+  user: User;
+};
+
 export type UsersError = {
   __typename?: 'UsersError';
   errorCodes: Array<UsersErrorCode>;
@@ -2202,11 +2207,6 @@ export type UsersSuccess = {
   users: Array<User>;
 };
 
-export type UserSuccess = {
-  __typename?: 'UserSuccess';
-  user: User;
-};
-
 export type Webhook = {
   __typename?: 'Webhook';
   contentType: Scalars['String'];
@@ -2244,6 +2244,11 @@ export enum WebhookEvent {
 
 export type WebhookResult = WebhookError | WebhookSuccess;
 
+export type WebhookSuccess = {
+  __typename?: 'WebhookSuccess';
+  webhook: Webhook;
+};
+
 export type WebhooksError = {
   __typename?: 'WebhooksError';
   errorCodes: Array<WebhooksErrorCode>;
@@ -2261,11 +2266,6 @@ export type WebhooksSuccess = {
   webhooks: Array<Webhook>;
 };
 
-export type WebhookSuccess = {
-  __typename?: 'WebhookSuccess';
-  webhook: Webhook;
-};
-
 
 
 export type ResolverTypeWrapper<T> = Promise<T> | T;
@@ -2361,11 +2361,11 @@ export type ResolversTypes = {
   ArticleSavingRequestResult: ResolversTypes['ArticleSavingRequestError'] | ResolversTypes['ArticleSavingRequestSuccess'];
   ArticleSavingRequestStatus: ArticleSavingRequestStatus;
   ArticleSavingRequestSuccess: ResolverTypeWrapper<ArticleSavingRequestSuccess>;
+  ArticleSuccess: ResolverTypeWrapper<ArticleSuccess>;
   ArticlesError: ResolverTypeWrapper<ArticlesError>;
   ArticlesErrorCode: ArticlesErrorCode;
   ArticlesResult: ResolversTypes['ArticlesError'] | ResolversTypes['ArticlesSuccess'];
   ArticlesSuccess: ResolverTypeWrapper<ArticlesSuccess>;
-  ArticleSuccess: ResolverTypeWrapper<ArticleSuccess>;
   Boolean: ResolverTypeWrapper<Scalars['Boolean']>;
   ContentReader: ContentReader;
   CreateArticleError: ResolverTypeWrapper<CreateArticleError>;
@@ -2478,15 +2478,15 @@ export type ResolversTypes = {
   LabelsSuccess: ResolverTypeWrapper<LabelsSuccess>;
   Link: ResolverTypeWrapper<Link>;
   LinkShareInfo: ResolverTypeWrapper<LinkShareInfo>;
+  LogOutError: ResolverTypeWrapper<LogOutError>;
+  LogOutErrorCode: LogOutErrorCode;
+  LogOutResult: ResolversTypes['LogOutError'] | ResolversTypes['LogOutSuccess'];
+  LogOutSuccess: ResolverTypeWrapper<LogOutSuccess>;
   LoginError: ResolverTypeWrapper<LoginError>;
   LoginErrorCode: LoginErrorCode;
   LoginInput: LoginInput;
   LoginResult: ResolversTypes['LoginError'] | ResolversTypes['LoginSuccess'];
   LoginSuccess: ResolverTypeWrapper<LoginSuccess>;
-  LogOutError: ResolverTypeWrapper<LogOutError>;
-  LogOutErrorCode: LogOutErrorCode;
-  LogOutResult: ResolversTypes['LogOutError'] | ResolversTypes['LogOutSuccess'];
-  LogOutSuccess: ResolverTypeWrapper<LogOutSuccess>;
   MergeHighlightError: ResolverTypeWrapper<MergeHighlightError>;
   MergeHighlightErrorCode: MergeHighlightErrorCode;
   MergeHighlightInput: MergeHighlightInput;
@@ -2579,11 +2579,11 @@ export type ResolversTypes = {
   SetWebhookInput: SetWebhookInput;
   SetWebhookResult: ResolversTypes['SetWebhookError'] | ResolversTypes['SetWebhookSuccess'];
   SetWebhookSuccess: ResolverTypeWrapper<SetWebhookSuccess>;
+  ShareStats: ResolverTypeWrapper<ShareStats>;
   SharedArticleError: ResolverTypeWrapper<SharedArticleError>;
   SharedArticleErrorCode: SharedArticleErrorCode;
   SharedArticleResult: ResolversTypes['SharedArticleError'] | ResolversTypes['SharedArticleSuccess'];
   SharedArticleSuccess: ResolverTypeWrapper<SharedArticleSuccess>;
-  ShareStats: ResolverTypeWrapper<ShareStats>;
   SignupError: ResolverTypeWrapper<SignupError>;
   SignupErrorCode: SignupErrorCode;
   SignupInput: SignupInput;
@@ -2598,11 +2598,11 @@ export type ResolversTypes = {
   SubscribeResult: ResolversTypes['SubscribeError'] | ResolversTypes['SubscribeSuccess'];
   SubscribeSuccess: ResolverTypeWrapper<SubscribeSuccess>;
   Subscription: ResolverTypeWrapper<{}>;
+  SubscriptionStatus: SubscriptionStatus;
   SubscriptionsError: ResolverTypeWrapper<SubscriptionsError>;
   SubscriptionsErrorCode: SubscriptionsErrorCode;
   SubscriptionsResult: ResolversTypes['SubscriptionsError'] | ResolversTypes['SubscriptionsSuccess'];
   SubscriptionsSuccess: ResolverTypeWrapper<SubscriptionsSuccess>;
-  SubscriptionStatus: SubscriptionStatus;
   UnsubscribeError: ResolverTypeWrapper<UnsubscribeError>;
   UnsubscribeErrorCode: UnsubscribeErrorCode;
   UnsubscribeResult: ResolversTypes['UnsubscribeError'] | ResolversTypes['UnsubscribeSuccess'];
@@ -2663,21 +2663,21 @@ export type ResolversTypes = {
   UserErrorCode: UserErrorCode;
   UserPersonalization: ResolverTypeWrapper<UserPersonalization>;
   UserResult: ResolversTypes['UserError'] | ResolversTypes['UserSuccess'];
+  UserSuccess: ResolverTypeWrapper<UserSuccess>;
   UsersError: ResolverTypeWrapper<UsersError>;
   UsersErrorCode: UsersErrorCode;
   UsersResult: ResolversTypes['UsersError'] | ResolversTypes['UsersSuccess'];
   UsersSuccess: ResolverTypeWrapper<UsersSuccess>;
-  UserSuccess: ResolverTypeWrapper<UserSuccess>;
   Webhook: ResolverTypeWrapper<Webhook>;
   WebhookError: ResolverTypeWrapper<WebhookError>;
   WebhookErrorCode: WebhookErrorCode;
   WebhookEvent: WebhookEvent;
   WebhookResult: ResolversTypes['WebhookError'] | ResolversTypes['WebhookSuccess'];
+  WebhookSuccess: ResolverTypeWrapper<WebhookSuccess>;
   WebhooksError: ResolverTypeWrapper<WebhooksError>;
   WebhooksErrorCode: WebhooksErrorCode;
   WebhooksResult: ResolversTypes['WebhooksError'] | ResolversTypes['WebhooksSuccess'];
   WebhooksSuccess: ResolverTypeWrapper<WebhooksSuccess>;
-  WebhookSuccess: ResolverTypeWrapper<WebhookSuccess>;
 };
 
 /** Mapping between all available schema types and the resolvers parents */
@@ -2702,10 +2702,10 @@ export type ResolversParentTypes = {
   ArticleSavingRequestError: ArticleSavingRequestError;
   ArticleSavingRequestResult: ResolversParentTypes['ArticleSavingRequestError'] | ResolversParentTypes['ArticleSavingRequestSuccess'];
   ArticleSavingRequestSuccess: ArticleSavingRequestSuccess;
+  ArticleSuccess: ArticleSuccess;
   ArticlesError: ArticlesError;
   ArticlesResult: ResolversParentTypes['ArticlesError'] | ResolversParentTypes['ArticlesSuccess'];
   ArticlesSuccess: ArticlesSuccess;
-  ArticleSuccess: ArticleSuccess;
   Boolean: Scalars['Boolean'];
   CreateArticleError: CreateArticleError;
   CreateArticleInput: CreateArticleInput;
@@ -2796,13 +2796,13 @@ export type ResolversParentTypes = {
   LabelsSuccess: LabelsSuccess;
   Link: Link;
   LinkShareInfo: LinkShareInfo;
+  LogOutError: LogOutError;
+  LogOutResult: ResolversParentTypes['LogOutError'] | ResolversParentTypes['LogOutSuccess'];
+  LogOutSuccess: LogOutSuccess;
   LoginError: LoginError;
   LoginInput: LoginInput;
   LoginResult: ResolversParentTypes['LoginError'] | ResolversParentTypes['LoginSuccess'];
   LoginSuccess: LoginSuccess;
-  LogOutError: LogOutError;
-  LogOutResult: ResolversParentTypes['LogOutError'] | ResolversParentTypes['LogOutSuccess'];
-  LogOutSuccess: LogOutSuccess;
   MergeHighlightError: MergeHighlightError;
   MergeHighlightInput: MergeHighlightInput;
   MergeHighlightResult: ResolversParentTypes['MergeHighlightError'] | ResolversParentTypes['MergeHighlightSuccess'];
@@ -2877,10 +2877,10 @@ export type ResolversParentTypes = {
   SetWebhookInput: SetWebhookInput;
   SetWebhookResult: ResolversParentTypes['SetWebhookError'] | ResolversParentTypes['SetWebhookSuccess'];
   SetWebhookSuccess: SetWebhookSuccess;
+  ShareStats: ShareStats;
   SharedArticleError: SharedArticleError;
   SharedArticleResult: ResolversParentTypes['SharedArticleError'] | ResolversParentTypes['SharedArticleSuccess'];
   SharedArticleSuccess: SharedArticleSuccess;
-  ShareStats: ShareStats;
   SignupError: SignupError;
   SignupInput: SignupInput;
   SignupResult: ResolversParentTypes['SignupError'] | ResolversParentTypes['SignupSuccess'];
@@ -2941,17 +2941,17 @@ export type ResolversParentTypes = {
   UserError: UserError;
   UserPersonalization: UserPersonalization;
   UserResult: ResolversParentTypes['UserError'] | ResolversParentTypes['UserSuccess'];
+  UserSuccess: UserSuccess;
   UsersError: UsersError;
   UsersResult: ResolversParentTypes['UsersError'] | ResolversParentTypes['UsersSuccess'];
   UsersSuccess: UsersSuccess;
-  UserSuccess: UserSuccess;
   Webhook: Webhook;
   WebhookError: WebhookError;
   WebhookResult: ResolversParentTypes['WebhookError'] | ResolversParentTypes['WebhookSuccess'];
+  WebhookSuccess: WebhookSuccess;
   WebhooksError: WebhooksError;
   WebhooksResult: ResolversParentTypes['WebhooksError'] | ResolversParentTypes['WebhooksSuccess'];
   WebhooksSuccess: WebhooksSuccess;
-  WebhookSuccess: WebhookSuccess;
 };
 
 export type SanitizeDirectiveArgs = {
@@ -3041,8 +3041,8 @@ export type ArticleResolvers<ContextType = ResolverContext, ParentType extends R
   readingProgressPercent?: Resolver<ResolversTypes['Float'], ParentType, ContextType>;
   savedAt?: Resolver<ResolversTypes['Date'], ParentType, ContextType>;
   savedByViewer?: Resolver<Maybe<ResolversTypes['Boolean']>, ParentType, ContextType>;
-  sharedComment?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
   shareInfo?: Resolver<Maybe<ResolversTypes['LinkShareInfo']>, ParentType, ContextType>;
+  sharedComment?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
   siteIcon?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
   siteName?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
   slug?: Resolver<ResolversTypes['String'], ParentType, ContextType>;
@@ -3098,6 +3098,11 @@ export type ArticleSavingRequestSuccessResolvers<ContextType = ResolverContext,
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
+export type ArticleSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['ArticleSuccess'] = ResolversParentTypes['ArticleSuccess']> = {
+  article?: Resolver<ResolversTypes['Article'], ParentType, ContextType>;
+  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
+};
+
 export type ArticlesErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['ArticlesError'] = ResolversParentTypes['ArticlesError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['ArticlesErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -3113,11 +3118,6 @@ export type ArticlesSuccessResolvers<ContextType = ResolverContext, ParentType e
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
-export type ArticleSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['ArticleSuccess'] = ResolversParentTypes['ArticleSuccess']> = {
-  article?: Resolver<ResolversTypes['Article'], ParentType, ContextType>;
-  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
-};
-
 export type CreateArticleErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['CreateArticleError'] = ResolversParentTypes['CreateArticleError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['CreateArticleErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -3525,20 +3525,6 @@ export type LinkShareInfoResolvers<ContextType = ResolverContext, ParentType ext
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
-export type LoginErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LoginError'] = ResolversParentTypes['LoginError']> = {
-  errorCodes?: Resolver<Array<ResolversTypes['LoginErrorCode']>, ParentType, ContextType>;
-  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
-};
-
-export type LoginResultResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LoginResult'] = ResolversParentTypes['LoginResult']> = {
-  __resolveType: TypeResolveFn<'LoginError' | 'LoginSuccess', ParentType, ContextType>;
-};
-
-export type LoginSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LoginSuccess'] = ResolversParentTypes['LoginSuccess']> = {
-  me?: Resolver<ResolversTypes['User'], ParentType, ContextType>;
-  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
-};
-
 export type LogOutErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LogOutError'] = ResolversParentTypes['LogOutError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['LogOutErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -3553,6 +3539,20 @@ export type LogOutSuccessResolvers<ContextType = ResolverContext, ParentType ext
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
+export type LoginErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LoginError'] = ResolversParentTypes['LoginError']> = {
+  errorCodes?: Resolver<Array<ResolversTypes['LoginErrorCode']>, ParentType, ContextType>;
+  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
+};
+
+export type LoginResultResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LoginResult'] = ResolversParentTypes['LoginResult']> = {
+  __resolveType: TypeResolveFn<'LoginError' | 'LoginSuccess', ParentType, ContextType>;
+};
+
+export type LoginSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['LoginSuccess'] = ResolversParentTypes['LoginSuccess']> = {
+  me?: Resolver<ResolversTypes['User'], ParentType, ContextType>;
+  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
+};
+
 export type MergeHighlightErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['MergeHighlightError'] = ResolversParentTypes['MergeHighlightError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['MergeHighlightErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -3588,8 +3588,8 @@ export type MutationResolvers<ContextType = ResolverContext, ParentType extends
   generateApiKey?: Resolver<ResolversTypes['GenerateApiKeyResult'], ParentType, ContextType, RequireFields<MutationGenerateApiKeyArgs, 'input'>>;
   googleLogin?: Resolver<ResolversTypes['LoginResult'], ParentType, ContextType, RequireFields<MutationGoogleLoginArgs, 'input'>>;
   googleSignup?: Resolver<ResolversTypes['GoogleSignupResult'], ParentType, ContextType, RequireFields<MutationGoogleSignupArgs, 'input'>>;
-  login?: Resolver<ResolversTypes['LoginResult'], ParentType, ContextType, RequireFields<MutationLoginArgs, 'input'>>;
   logOut?: Resolver<ResolversTypes['LogOutResult'], ParentType, ContextType>;
+  login?: Resolver<ResolversTypes['LoginResult'], ParentType, ContextType, RequireFields<MutationLoginArgs, 'input'>>;
   mergeHighlight?: Resolver<ResolversTypes['MergeHighlightResult'], ParentType, ContextType, RequireFields<MutationMergeHighlightArgs, 'input'>>;
   reportItem?: Resolver<ResolversTypes['ReportItemResult'], ParentType, ContextType, RequireFields<MutationReportItemArgs, 'input'>>;
   revokeApiKey?: Resolver<ResolversTypes['RevokeApiKeyResult'], ParentType, ContextType, RequireFields<MutationRevokeApiKeyArgs, 'id'>>;
@@ -3681,8 +3681,8 @@ export type ProfileResolvers<ContextType = ResolverContext, ParentType extends R
 export type QueryResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['Query'] = ResolversParentTypes['Query']> = {
   apiKeys?: Resolver<ResolversTypes['ApiKeysResult'], ParentType, ContextType>;
   article?: Resolver<ResolversTypes['ArticleResult'], ParentType, ContextType, RequireFields<QueryArticleArgs, 'slug' | 'username'>>;
-  articles?: Resolver<ResolversTypes['ArticlesResult'], ParentType, ContextType, Partial<QueryArticlesArgs>>;
   articleSavingRequest?: Resolver<ResolversTypes['ArticleSavingRequestResult'], ParentType, ContextType, RequireFields<QueryArticleSavingRequestArgs, 'id'>>;
+  articles?: Resolver<ResolversTypes['ArticlesResult'], ParentType, ContextType, Partial<QueryArticlesArgs>>;
   feedArticles?: Resolver<ResolversTypes['FeedArticlesResult'], ParentType, ContextType, Partial<QueryFeedArticlesArgs>>;
   getFollowers?: Resolver<ResolversTypes['GetFollowersResult'], ParentType, ContextType, Partial<QueryGetFollowersArgs>>;
   getFollowing?: Resolver<ResolversTypes['GetFollowingResult'], ParentType, ContextType, Partial<QueryGetFollowingArgs>>;
@@ -3957,6 +3957,13 @@ export type SetWebhookSuccessResolvers<ContextType = ResolverContext, ParentType
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
+export type ShareStatsResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['ShareStats'] = ResolversParentTypes['ShareStats']> = {
+  readDuration?: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
+  saveCount?: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
+  viewCount?: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
+  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
+};
+
 export type SharedArticleErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['SharedArticleError'] = ResolversParentTypes['SharedArticleError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['SharedArticleErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -3971,13 +3978,6 @@ export type SharedArticleSuccessResolvers<ContextType = ResolverContext, ParentT
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
-export type ShareStatsResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['ShareStats'] = ResolversParentTypes['ShareStats']> = {
-  readDuration?: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
-  saveCount?: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
-  viewCount?: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
-  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
-};
-
 export type SignupErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['SignupError'] = ResolversParentTypes['SignupError']> = {
   errorCodes?: Resolver<Array<Maybe<ResolversTypes['SignupErrorCode']>>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -4227,6 +4227,11 @@ export type UserResultResolvers<ContextType = ResolverContext, ParentType extend
   __resolveType: TypeResolveFn<'UserError' | 'UserSuccess', ParentType, ContextType>;
 };
 
+export type UserSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['UserSuccess'] = ResolversParentTypes['UserSuccess']> = {
+  user?: Resolver<ResolversTypes['User'], ParentType, ContextType>;
+  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
+};
+
 export type UsersErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['UsersError'] = ResolversParentTypes['UsersError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['UsersErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -4241,11 +4246,6 @@ export type UsersSuccessResolvers<ContextType = ResolverContext, ParentType exte
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
-export type UserSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['UserSuccess'] = ResolversParentTypes['UserSuccess']> = {
-  user?: Resolver<ResolversTypes['User'], ParentType, ContextType>;
-  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
-};
-
 export type WebhookResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['Webhook'] = ResolversParentTypes['Webhook']> = {
   contentType?: Resolver<ResolversTypes['String'], ParentType, ContextType>;
   createdAt?: Resolver<ResolversTypes['Date'], ParentType, ContextType>;
@@ -4267,6 +4267,11 @@ export type WebhookResultResolvers<ContextType = ResolverContext, ParentType ext
   __resolveType: TypeResolveFn<'WebhookError' | 'WebhookSuccess', ParentType, ContextType>;
 };
 
+export type WebhookSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['WebhookSuccess'] = ResolversParentTypes['WebhookSuccess']> = {
+  webhook?: Resolver<ResolversTypes['Webhook'], ParentType, ContextType>;
+  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
+};
+
 export type WebhooksErrorResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['WebhooksError'] = ResolversParentTypes['WebhooksError']> = {
   errorCodes?: Resolver<Array<ResolversTypes['WebhooksErrorCode']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -4281,11 +4286,6 @@ export type WebhooksSuccessResolvers<ContextType = ResolverContext, ParentType e
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 
-export type WebhookSuccessResolvers<ContextType = ResolverContext, ParentType extends ResolversParentTypes['WebhookSuccess'] = ResolversParentTypes['WebhookSuccess']> = {
-  webhook?: Resolver<ResolversTypes['Webhook'], ParentType, ContextType>;
-  __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
-};
-
 export type Resolvers<ContextType = ResolverContext> = {
   AddPopularReadError?: AddPopularReadErrorResolvers<ContextType>;
   AddPopularReadResult?: AddPopularReadResultResolvers<ContextType>;
@@ -4305,10 +4305,10 @@ export type Resolvers<ContextType = ResolverContext> = {
   ArticleSavingRequestError?: ArticleSavingRequestErrorResolvers<ContextType>;
   ArticleSavingRequestResult?: ArticleSavingRequestResultResolvers<ContextType>;
   ArticleSavingRequestSuccess?: ArticleSavingRequestSuccessResolvers<ContextType>;
+  ArticleSuccess?: ArticleSuccessResolvers<ContextType>;
   ArticlesError?: ArticlesErrorResolvers<ContextType>;
   ArticlesResult?: ArticlesResultResolvers<ContextType>;
   ArticlesSuccess?: ArticlesSuccessResolvers<ContextType>;
-  ArticleSuccess?: ArticleSuccessResolvers<ContextType>;
   CreateArticleError?: CreateArticleErrorResolvers<ContextType>;
   CreateArticleResult?: CreateArticleResultResolvers<ContextType>;
   CreateArticleSavingRequestError?: CreateArticleSavingRequestErrorResolvers<ContextType>;
@@ -4385,12 +4385,12 @@ export type Resolvers<ContextType = ResolverContext> = {
   LabelsSuccess?: LabelsSuccessResolvers<ContextType>;
   Link?: LinkResolvers<ContextType>;
   LinkShareInfo?: LinkShareInfoResolvers<ContextType>;
-  LoginError?: LoginErrorResolvers<ContextType>;
-  LoginResult?: LoginResultResolvers<ContextType>;
-  LoginSuccess?: LoginSuccessResolvers<ContextType>;
   LogOutError?: LogOutErrorResolvers<ContextType>;
   LogOutResult?: LogOutResultResolvers<ContextType>;
   LogOutSuccess?: LogOutSuccessResolvers<ContextType>;
+  LoginError?: LoginErrorResolvers<ContextType>;
+  LoginResult?: LoginResultResolvers<ContextType>;
+  LoginSuccess?: LoginSuccessResolvers<ContextType>;
   MergeHighlightError?: MergeHighlightErrorResolvers<ContextType>;
   MergeHighlightResult?: MergeHighlightResultResolvers<ContextType>;
   MergeHighlightSuccess?: MergeHighlightSuccessResolvers<ContextType>;
@@ -4448,10 +4448,10 @@ export type Resolvers<ContextType = ResolverContext> = {
   SetWebhookError?: SetWebhookErrorResolvers<ContextType>;
   SetWebhookResult?: SetWebhookResultResolvers<ContextType>;
   SetWebhookSuccess?: SetWebhookSuccessResolvers<ContextType>;
+  ShareStats?: ShareStatsResolvers<ContextType>;
   SharedArticleError?: SharedArticleErrorResolvers<ContextType>;
   SharedArticleResult?: SharedArticleResultResolvers<ContextType>;
   SharedArticleSuccess?: SharedArticleSuccessResolvers<ContextType>;
-  ShareStats?: ShareStatsResolvers<ContextType>;
   SignupError?: SignupErrorResolvers<ContextType>;
   SignupResult?: SignupResultResolvers<ContextType>;
   SignupSuccess?: SignupSuccessResolvers<ContextType>;
@@ -4499,17 +4499,17 @@ export type Resolvers<ContextType = ResolverContext> = {
   UserError?: UserErrorResolvers<ContextType>;
   UserPersonalization?: UserPersonalizationResolvers<ContextType>;
   UserResult?: UserResultResolvers<ContextType>;
+  UserSuccess?: UserSuccessResolvers<ContextType>;
   UsersError?: UsersErrorResolvers<ContextType>;
   UsersResult?: UsersResultResolvers<ContextType>;
   UsersSuccess?: UsersSuccessResolvers<ContextType>;
-  UserSuccess?: UserSuccessResolvers<ContextType>;
   Webhook?: WebhookResolvers<ContextType>;
   WebhookError?: WebhookErrorResolvers<ContextType>;
   WebhookResult?: WebhookResultResolvers<ContextType>;
+  WebhookSuccess?: WebhookSuccessResolvers<ContextType>;
   WebhooksError?: WebhooksErrorResolvers<ContextType>;
   WebhooksResult?: WebhooksResultResolvers<ContextType>;
   WebhooksSuccess?: WebhooksSuccessResolvers<ContextType>;
-  WebhookSuccess?: WebhookSuccessResolvers<ContextType>;
 };
 
 export type DirectiveResolvers<ContextType = ResolverContext> = {
diff --git a/packages/api/src/generated/schema.graphql b/packages/api/src/generated/schema.graphql
index 1a4f4da94..461e8f74d 100644
--- a/packages/api/src/generated/schema.graphql
+++ b/packages/api/src/generated/schema.graphql
@@ -87,8 +87,8 @@ type Article {
   readingProgressPercent: Float!
   savedAt: Date!
   savedByViewer: Boolean
-  sharedComment: String
   shareInfo: LinkShareInfo
+  sharedComment: String
   siteIcon: String
   siteName: String
   slug: String!
@@ -155,6 +155,10 @@ type ArticleSavingRequestSuccess {
   articleSavingRequest: ArticleSavingRequest!
 }
 
+type ArticleSuccess {
+  article: Article!
+}
+
 type ArticlesError {
   errorCodes: [ArticlesErrorCode!]!
 }
@@ -170,10 +174,6 @@ type ArticlesSuccess {
   pageInfo: PageInfo!
 }
 
-type ArticleSuccess {
-  article: Article!
-}
-
 enum ContentReader {
   PDF
   WEB
@@ -684,6 +684,20 @@ type LinkShareInfo {
   title: String!
 }
 
+type LogOutError {
+  errorCodes: [LogOutErrorCode!]!
+}
+
+enum LogOutErrorCode {
+  LOG_OUT_FAILED
+}
+
+union LogOutResult = LogOutError | LogOutSuccess
+
+type LogOutSuccess {
+  message: String
+}
+
 type LoginError {
   errorCodes: [LoginErrorCode!]!
 }
@@ -708,20 +722,6 @@ type LoginSuccess {
   me: User!
 }
 
-type LogOutError {
-  errorCodes: [LogOutErrorCode!]!
-}
-
-enum LogOutErrorCode {
-  LOG_OUT_FAILED
-}
-
-union LogOutResult = LogOutError | LogOutSuccess
-
-type LogOutSuccess {
-  message: String
-}
-
 type MergeHighlightError {
   errorCodes: [MergeHighlightErrorCode!]!
 }
@@ -773,8 +773,8 @@ type Mutation {
   generateApiKey(input: GenerateApiKeyInput!): GenerateApiKeyResult!
   googleLogin(input: GoogleLoginInput!): LoginResult!
   googleSignup(input: GoogleSignupInput!): GoogleSignupResult!
-  login(input: LoginInput!): LoginResult!
   logOut: LogOutResult!
+  login(input: LoginInput!): LoginResult!
   mergeHighlight(input: MergeHighlightInput!): MergeHighlightResult!
   reportItem(input: ReportItemInput!): ReportItemResult!
   revokeApiKey(id: ID!): RevokeApiKeyResult!
@@ -888,8 +888,8 @@ type Profile {
 type Query {
   apiKeys: ApiKeysResult!
   article(slug: String!, username: String!): ArticleResult!
-  articles(after: String, first: Int, includePending: Boolean, query: String, sharedOnly: Boolean, sort: SortParams): ArticlesResult!
   articleSavingRequest(id: ID!): ArticleSavingRequestResult!
+  articles(after: String, first: Int, includePending: Boolean, query: String, sharedOnly: Boolean, sort: SortParams): ArticlesResult!
   feedArticles(after: String, first: Int, sharedByUser: ID, sort: SortParams): FeedArticlesResult!
   getFollowers(userId: ID): GetFollowersResult!
   getFollowing(userId: ID): GetFollowingResult!
@@ -1283,6 +1283,12 @@ type SetWebhookSuccess {
   webhook: Webhook!
 }
 
+type ShareStats {
+  readDuration: Int!
+  saveCount: Int!
+  viewCount: Int!
+}
+
 type SharedArticleError {
   errorCodes: [SharedArticleErrorCode!]!
 }
@@ -1297,12 +1303,6 @@ type SharedArticleSuccess {
   article: Article!
 }
 
-type ShareStats {
-  readDuration: Int!
-  saveCount: Int!
-  viewCount: Int!
-}
-
 type SignupError {
   errorCodes: [SignupErrorCode]!
 }
@@ -1379,6 +1379,12 @@ type Subscription {
   url: String
 }
 
+enum SubscriptionStatus {
+  ACTIVE
+  DELETED
+  UNSUBSCRIBED
+}
+
 type SubscriptionsError {
   errorCodes: [SubscriptionsErrorCode!]!
 }
@@ -1394,12 +1400,6 @@ type SubscriptionsSuccess {
   subscriptions: [Subscription!]!
 }
 
-enum SubscriptionStatus {
-  ACTIVE
-  DELETED
-  UNSUBSCRIBED
-}
-
 type UnsubscribeError {
   errorCodes: [UnsubscribeErrorCode!]!
 }
@@ -1690,6 +1690,10 @@ type UserPersonalization {
 
 union UserResult = UserError | UserSuccess
 
+type UserSuccess {
+  user: User!
+}
+
 type UsersError {
   errorCodes: [UsersErrorCode!]!
 }
@@ -1704,10 +1708,6 @@ type UsersSuccess {
   users: [User!]!
 }
 
-type UserSuccess {
-  user: User!
-}
-
 type Webhook {
   contentType: String!
   createdAt: Date!
@@ -1743,6 +1743,10 @@ enum WebhookEvent {
 
 union WebhookResult = WebhookError | WebhookSuccess
 
+type WebhookSuccess {
+  webhook: Webhook!
+}
+
 type WebhooksError {
   errorCodes: [WebhooksErrorCode!]!
 }
@@ -1757,7 +1761,3 @@ union WebhooksResult = WebhooksError | WebhooksSuccess
 type WebhooksSuccess {
   webhooks: [Webhook!]!
 }
-
-type WebhookSuccess {
-  webhook: Webhook!
-}

From eef3ee4114e94c791d2d19d5c1878b3227d6c843 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 14:59:27 +0800
Subject: [PATCH 07/15] Add getLabelsByIds service method

---
 packages/api/src/services/labels.ts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/packages/api/src/services/labels.ts b/packages/api/src/services/labels.ts
index bf9577b74..cb8432b06 100644
--- a/packages/api/src/services/labels.ts
+++ b/packages/api/src/services/labels.ts
@@ -66,3 +66,13 @@ export const addLabelToPage = async (
     ctx
   )
 }
+
+export const getLabelsByIds = async (
+  userId: string,
+  labelIds: string[]
+): Promise<Label[]> => {
+  return getRepository(Label).find({
+    where: { id: In(labelIds), user: { id: userId } },
+    select: ['id', 'name', 'color', 'description', 'createdAt'],
+  })
+}

From e9f4149c62761a6f19f8501176faf6dfe60f7e6b Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 14:59:46 +0800
Subject: [PATCH 08/15] Add setLabelsForHighlight resolver

---
 packages/api/src/resolvers/labels/index.ts | 84 ++++++++++++++++++++--
 1 file changed, 79 insertions(+), 5 deletions(-)

diff --git a/packages/api/src/resolvers/labels/index.ts b/packages/api/src/resolvers/labels/index.ts
index 54c0b3263..ca83ec3c2 100644
--- a/packages/api/src/resolvers/labels/index.ts
+++ b/packages/api/src/resolvers/labels/index.ts
@@ -12,6 +12,7 @@ import {
   MutationCreateLabelArgs,
   MutationDeleteLabelArgs,
   MutationSetLabelsArgs,
+  MutationSetLabelsForHighlightArgs,
   MutationUpdateLabelArgs,
   SetLabelsError,
   SetLabelsErrorCode,
@@ -24,16 +25,19 @@ import { analytics } from '../../utils/analytics'
 import { env } from '../../env'
 import { User } from '../../entity/user'
 import { Label } from '../../entity/label'
-import { ILike, In } from 'typeorm'
+import { ILike } from 'typeorm'
 import { getRepository, setClaims } from '../../entity/utils'
 import { createPubSubClient } from '../../datalayer/pubsub'
 import { AppDataSource } from '../../server'
 import { getPageById } from '../../elastic/pages'
 import {
   deleteLabelInPages,
+  setLabelsForHighlight,
   updateLabelInPage,
   updateLabelsInPage,
 } from '../../elastic/labels'
+import { getHighlightById } from '../../elastic/highlights'
+import { getLabelsByIds } from '../../services/labels'
 
 export const labelsResolver = authorized<LabelsSuccess, LabelsError>(
   async (_obj, _params, { claims: { uid }, log }) => {
@@ -223,11 +227,13 @@ export const setLabelsResolver = authorized<
         errorCodes: [SetLabelsErrorCode.NotFound],
       }
     }
+    if (page.userId !== uid) {
+      return {
+        errorCodes: [SetLabelsErrorCode.Unauthorized],
+      }
+    }
 
-    const labels = await getRepository(Label).find({
-      where: { id: In(labelIds), user: { id: user.id } },
-      select: ['id', 'name', 'color', 'description', 'createdAt'],
-    })
+    const labels = await getLabelsByIds(uid, labelIds)
     if (labels.length !== labelIds.length) {
       return {
         errorCodes: [SetLabelsErrorCode.NotFound],
@@ -334,3 +340,71 @@ export const updateLabelResolver = authorized<
     }
   }
 })
+
+export const setLabelsForHighlightResolver = authorized<
+  SetLabelsSuccess,
+  SetLabelsError,
+  MutationSetLabelsForHighlightArgs
+>(async (_, { input }, { claims: { uid }, log, pubsub }) => {
+  log.info('setLabelsForHighlightResolver')
+
+  const { highlightId, labelIds } = input
+
+  try {
+    const user = await getRepository(User).findOneBy({ id: uid })
+    if (!user) {
+      return {
+        errorCodes: [SetLabelsErrorCode.Unauthorized],
+      }
+    }
+
+    const highlight = await getHighlightById(highlightId)
+    if (!highlight) {
+      return {
+        errorCodes: [SetLabelsErrorCode.NotFound],
+      }
+    }
+    if (highlight.userId !== uid) {
+      return {
+        errorCodes: [SetLabelsErrorCode.Unauthorized],
+      }
+    }
+
+    const labels = await getLabelsByIds(uid, labelIds)
+    if (labels.length !== labelIds.length) {
+      return {
+        errorCodes: [SetLabelsErrorCode.NotFound],
+      }
+    }
+
+    // set labels in the highlights
+    const updated = await setLabelsForHighlight(highlightId, labels, {
+      pubsub,
+      uid,
+    })
+    if (!updated) {
+      return {
+        errorCodes: [SetLabelsErrorCode.NotFound],
+      }
+    }
+
+    analytics.track({
+      userId: uid,
+      event: 'labels_set_for_highlight',
+      properties: {
+        highlightId,
+        labelIds,
+        env: env.server.apiEnv,
+      },
+    })
+
+    return {
+      labels,
+    }
+  } catch (error) {
+    log.error(error)
+    return {
+      errorCodes: [SetLabelsErrorCode.BadRequest],
+    }
+  }
+})

From 4894b3cfd9a0b7a867da06b76eebc8628c868abb Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 15:00:05 +0800
Subject: [PATCH 09/15] Add setLabelsForHighlight in function_resolvers.ts

---
 packages/api/src/resolvers/function_resolvers.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/api/src/resolvers/function_resolvers.ts b/packages/api/src/resolvers/function_resolvers.ts
index 603383a1b..00b63e8f9 100644
--- a/packages/api/src/resolvers/function_resolvers.ts
+++ b/packages/api/src/resolvers/function_resolvers.ts
@@ -64,6 +64,7 @@ import {
   setBookmarkArticleResolver,
   setDeviceTokenResolver,
   setFollowResolver,
+  setLabelsForHighlightResolver,
   setLabelsResolver,
   setLinkArchivedResolver,
   setShareArticleResolver,
@@ -160,6 +161,7 @@ export const functionResolvers = {
     setWebhook: setWebhookResolver,
     deleteWebhook: deleteWebhookResolver,
     revokeApiKey: revokeApiKeyResolver,
+    setLabelsForHighlight: setLabelsForHighlightResolver,
   },
   Query: {
     me: getMeUserResolver,
@@ -581,4 +583,5 @@ export const functionResolvers = {
   ...resultResolveTypeResolver('Webhook'),
   ...resultResolveTypeResolver('ApiKeys'),
   ...resultResolveTypeResolver('RevokeApiKey'),
+  ...resultResolveTypeResolver('SetLabelsForHighlight'),
 }

From 145867fe055fb05b3295cab15fd5aa318a322c49 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 15:25:11 +0800
Subject: [PATCH 10/15] Add test for setLabelsForHighlight resolver

---
 .../api/src/resolvers/function_resolvers.ts   |  1 -
 packages/api/test/resolvers/labels.test.ts    | 95 ++++++++++++++++++-
 2 files changed, 94 insertions(+), 2 deletions(-)

diff --git a/packages/api/src/resolvers/function_resolvers.ts b/packages/api/src/resolvers/function_resolvers.ts
index 00b63e8f9..7b5b1c6e9 100644
--- a/packages/api/src/resolvers/function_resolvers.ts
+++ b/packages/api/src/resolvers/function_resolvers.ts
@@ -583,5 +583,4 @@ export const functionResolvers = {
   ...resultResolveTypeResolver('Webhook'),
   ...resultResolveTypeResolver('ApiKeys'),
   ...resultResolveTypeResolver('RevokeApiKey'),
-  ...resultResolveTypeResolver('SetLabelsForHighlight'),
 }
diff --git a/packages/api/test/resolvers/labels.test.ts b/packages/api/test/resolvers/labels.test.ts
index 6d7814fc7..0701cdc0b 100644
--- a/packages/api/test/resolvers/labels.test.ts
+++ b/packages/api/test/resolvers/labels.test.ts
@@ -9,11 +9,12 @@ import { Label } from '../../src/entity/label'
 import { expect } from 'chai'
 import 'mocha'
 import { User } from '../../src/entity/user'
-import { Page, PageContext } from '../../src/elastic/types'
+import { Highlight, Page, PageContext } from '../../src/elastic/types'
 import { getRepository } from '../../src/entity/utils'
 import { getPageById } from '../../src/elastic/pages'
 import { addLabelInPage } from '../../src/elastic/labels'
 import { createPubSubClient } from '../../src/datalayer/pubsub'
+import { addHighlightToPage } from '../../src/elastic/highlights'
 
 describe('Labels API', () => {
   const username = 'fakeUser'
@@ -440,4 +441,96 @@ describe('Labels API', () => {
       })
     })
   })
+
+  describe('Set labels for highlight', () => {
+    let query: string
+    let highlightId: string
+    let labelIds: string[] = []
+
+    beforeEach(() => {
+      query = `
+        mutation {
+          setLabelsForHighlight(
+            input: {
+              highlightId: "${highlightId}",
+              labelIds: [
+                "${labelIds[0]}",
+                "${labelIds[1]}"
+              ]
+            }
+          ) {
+            ... on SetLabelsSuccess {
+              labels {
+                id
+                name
+              }
+            }
+            ... on SetLabelsError {
+              errorCodes
+            }
+          }
+        }
+      `
+    })
+
+    context('when labels exists', () => {
+      before(async () => {
+        highlightId = 'highlight-id'
+        const highlight: Highlight = {
+          createdAt: new Date(),
+          id: highlightId,
+          patch: 'test patch',
+          quote: 'test quote',
+          shortId: 'test shortId',
+          userId: user.id,
+        }
+        await addHighlightToPage(page.id, highlight, ctx)
+        labelIds = [labels[0].id, labels[1].id]
+      })
+
+      it('should set labels for highlight', async () => {
+        const res = await graphqlRequest(query, authToken).expect(200)
+        expect(
+          res.body.data.setLabelsForHighlight.labels.map((l: any) => l.id)
+        ).to.eql(labelIds)
+      })
+    })
+
+    context('when labels not exist', () => {
+      before(async () => {
+        highlightId = 'highlight-id-2'
+        const highlight: Highlight = {
+          createdAt: new Date(),
+          id: highlightId,
+          patch: 'test patch',
+          quote: 'test quote',
+          shortId: 'test shortId',
+          userId: user.id,
+        }
+        await addHighlightToPage(page.id, highlight, ctx)
+        labelIds = [generateFakeUuid(), generateFakeUuid()]
+      })
+
+      it('should return error code NOT_FOUND', async () => {
+        const res = await graphqlRequest(query, authToken).expect(200)
+        expect(res.body.data.setLabelsForHighlight.errorCodes).to.eql([
+          'NOT_FOUND',
+        ])
+      })
+    })
+
+    context('when highlight not exist', () => {
+      before(() => {
+        highlightId = generateFakeUuid()
+        labelIds = [labels[0].id, labels[1].id]
+      })
+
+      it('should return error code NOT_FOUND', async () => {
+        const res = await graphqlRequest(query, authToken).expect(200)
+        expect(res.body.data.setLabelsForHighlight.errorCodes).to.eql([
+          'NOT_FOUND',
+        ])
+      })
+    })
+  })
 })

From 22c604c15b0f4a5f805f9a025cb40667f1bf0a85 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 15:33:43 +0800
Subject: [PATCH 11/15] Add deleteLabelForHighlights

---
 packages/api/src/elastic/labels.ts | 58 ++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/packages/api/src/elastic/labels.ts b/packages/api/src/elastic/labels.ts
index e69f8312e..687d8f0d2 100644
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@@ -255,3 +255,61 @@ export const setLabelsForHighlight = async (
     return false
   }
 }
+
+export const deleteLabelForHighlights = async (
+  userId: string,
+  label: string,
+  ctx: PageContext
+): Promise<boolean> => {
+  try {
+    const { body } = await client.updateByQuery({
+      index: INDEX_ALIAS,
+      body: {
+        script: {
+          source:
+            'ctx._source.highlights[0].labels.removeIf(label -> label.name == params.label)',
+          lang: 'painless',
+          params: {
+            label: label,
+          },
+        },
+        query: {
+          bool: {
+            filter: [
+              {
+                term: {
+                  userId,
+                },
+              },
+              {
+                nested: {
+                  path: 'highlights',
+                  query: {
+                    nested: {
+                      path: 'labels',
+                      query: {
+                        term: {
+                          'highlights.labels.name': label,
+                        },
+                      },
+                    },
+                  },
+                },
+              },
+            ],
+          },
+        },
+      },
+      refresh: ctx.refresh,
+      conflicts: 'proceed', // ignore conflicts
+    })
+
+    body.updated > 0 &&
+      (await ctx.pubsub.entityDeleted(EntityType.LABEL, label, ctx.uid))
+
+    return true
+  } catch (e) {
+    console.error('failed to delete a label for highlights in elastic', e)
+    return false
+  }
+}

From 0d67d0fb907e282480c993d5e129976b2fc350be Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 15:35:52 +0800
Subject: [PATCH 12/15] Delete labels for highlights when label is deleted

---
 packages/api/src/resolvers/labels/index.ts | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/api/src/resolvers/labels/index.ts b/packages/api/src/resolvers/labels/index.ts
index ca83ec3c2..27e9dd746 100644
--- a/packages/api/src/resolvers/labels/index.ts
+++ b/packages/api/src/resolvers/labels/index.ts
@@ -31,6 +31,7 @@ import { createPubSubClient } from '../../datalayer/pubsub'
 import { AppDataSource } from '../../server'
 import { getPageById } from '../../elastic/pages'
 import {
+  deleteLabelForHighlights,
   deleteLabelInPages,
   setLabelsForHighlight,
   updateLabelInPage,
@@ -38,6 +39,7 @@ import {
 } from '../../elastic/labels'
 import { getHighlightById } from '../../elastic/highlights'
 import { getLabelsByIds } from '../../services/labels'
+import { PageContext } from '../../elastic/types'
 
 export const labelsResolver = authorized<LabelsSuccess, LabelsError>(
   async (_obj, _params, { claims: { uid }, log }) => {
@@ -178,11 +180,13 @@ export const deleteLabelResolver = authorized<
       }
     }
 
-    // delete label in elastic pages
-    await deleteLabelInPages(uid, label.name, {
+    const ctx: PageContext = {
       pubsub: createPubSubClient(),
       uid,
-    })
+    }
+    // delete label in elastic pages and highlights
+    await deleteLabelInPages(uid, label.name, ctx)
+    await deleteLabelForHighlights(uid, label.name, ctx)
 
     analytics.track({
       userId: uid,

From a981e13c866a7c9caa4babc5c3752e2e5ce51c62 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 17:01:38 +0800
Subject: [PATCH 13/15] Add test case for deleteLabel

---
 packages/api/src/elastic/labels.ts         |  2 +-
 packages/api/test/resolvers/labels.test.ts | 29 +++++++++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/packages/api/src/elastic/labels.ts b/packages/api/src/elastic/labels.ts
index 687d8f0d2..ffbbeb3c8 100644
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@@ -286,7 +286,7 @@ export const deleteLabelForHighlights = async (
                   path: 'highlights',
                   query: {
                     nested: {
-                      path: 'labels',
+                      path: 'highlights.labels',
                       query: {
                         term: {
                           'highlights.labels.name': label,
diff --git a/packages/api/test/resolvers/labels.test.ts b/packages/api/test/resolvers/labels.test.ts
index 0701cdc0b..7b469f80e 100644
--- a/packages/api/test/resolvers/labels.test.ts
+++ b/packages/api/test/resolvers/labels.test.ts
@@ -14,7 +14,10 @@ import { getRepository } from '../../src/entity/utils'
 import { getPageById } from '../../src/elastic/pages'
 import { addLabelInPage } from '../../src/elastic/labels'
 import { createPubSubClient } from '../../src/datalayer/pubsub'
-import { addHighlightToPage } from '../../src/elastic/highlights'
+import {
+  addHighlightToPage,
+  getHighlightById,
+} from '../../src/elastic/highlights'
 
 describe('Labels API', () => {
   const username = 'fakeUser'
@@ -239,6 +242,30 @@ describe('Labels API', () => {
           expect(updatedPage?.labels).not.to.include(toDeleteLabel)
         })
       })
+
+      context('when a highlight has this label', () => {
+        const highlightId = 'testDeleteLabel'
+
+        before(async () => {
+          const highlight: Highlight = {
+            id: highlightId,
+            patch: 'test patch',
+            quote: 'test quote',
+            shortId: 'test shortId',
+            userId: user.id,
+            createdAt: new Date(),
+            labels: [toDeleteLabel],
+          }
+          await addHighlightToPage(page.id, highlight, ctx)
+        })
+
+        it('should update highlight', async () => {
+          await graphqlRequest(query, authToken).expect(200)
+          const updatedHighlight = await getHighlightById(highlightId)
+
+          expect(updatedHighlight?.labels).not.to.include(toDeleteLabel)
+        })
+      })
     })
 
     context('when label not exist', () => {

From 7c840f5b1eadd0fbb161a60050184102835f0329 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 17:25:33 +0800
Subject: [PATCH 14/15] Merge deleteLabel in page and highlight

---
 packages/api/src/elastic/labels.ts         | 95 +++++++---------------
 packages/api/src/resolvers/labels/index.ts | 12 +--
 2 files changed, 33 insertions(+), 74 deletions(-)

diff --git a/packages/api/src/elastic/labels.ts b/packages/api/src/elastic/labels.ts
index ffbbeb3c8..990c15449 100644
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@@ -94,7 +94,7 @@ export const updateLabelsInPage = async (
   }
 }
 
-export const deleteLabelInPages = async (
+export const deleteLabel = async (
   userId: string,
   label: string,
   ctx: PageContext
@@ -104,8 +104,12 @@ export const deleteLabelInPages = async (
       index: INDEX_ALIAS,
       body: {
         script: {
-          source:
-            'ctx._source.labels.removeIf(label -> label.name == params.label)',
+          source: `if (ctx._source.highlights != null) {
+                     ctx._source.highlights[0].labels.removeIf(label -> label.name == params.label)
+                   }
+                   if (ctx._source.labels != null) {
+                     ctx._source.labels.removeIf(label -> label.name == params.label)
+                   }`,
           lang: 'painless',
           params: {
             label: label,
@@ -113,12 +117,12 @@ export const deleteLabelInPages = async (
         },
         query: {
           bool: {
-            filter: [
-              {
-                term: {
-                  userId,
-                },
+            must: {
+              term: {
+                userId,
               },
+            },
+            should: [
               {
                 nested: {
                   path: 'labels',
@@ -129,11 +133,28 @@ export const deleteLabelInPages = async (
                   },
                 },
               },
+              {
+                nested: {
+                  path: 'highlights',
+                  query: {
+                    nested: {
+                      path: 'highlights.labels',
+                      query: {
+                        term: {
+                          'highlights.labels.name': label,
+                        },
+                      },
+                    },
+                  },
+                },
+              },
             ],
+            minimum_should_match: 1,
           },
         },
       },
       refresh: ctx.refresh,
+      conflicts: 'proceed', // ignore conflicts
     })
 
     body.updated > 0 &&
@@ -255,61 +276,3 @@ export const setLabelsForHighlight = async (
     return false
   }
 }
-
-export const deleteLabelForHighlights = async (
-  userId: string,
-  label: string,
-  ctx: PageContext
-): Promise<boolean> => {
-  try {
-    const { body } = await client.updateByQuery({
-      index: INDEX_ALIAS,
-      body: {
-        script: {
-          source:
-            'ctx._source.highlights[0].labels.removeIf(label -> label.name == params.label)',
-          lang: 'painless',
-          params: {
-            label: label,
-          },
-        },
-        query: {
-          bool: {
-            filter: [
-              {
-                term: {
-                  userId,
-                },
-              },
-              {
-                nested: {
-                  path: 'highlights',
-                  query: {
-                    nested: {
-                      path: 'highlights.labels',
-                      query: {
-                        term: {
-                          'highlights.labels.name': label,
-                        },
-                      },
-                    },
-                  },
-                },
-              },
-            ],
-          },
-        },
-      },
-      refresh: ctx.refresh,
-      conflicts: 'proceed', // ignore conflicts
-    })
-
-    body.updated > 0 &&
-      (await ctx.pubsub.entityDeleted(EntityType.LABEL, label, ctx.uid))
-
-    return true
-  } catch (e) {
-    console.error('failed to delete a label for highlights in elastic', e)
-    return false
-  }
-}
diff --git a/packages/api/src/resolvers/labels/index.ts b/packages/api/src/resolvers/labels/index.ts
index 27e9dd746..f11c35c80 100644
--- a/packages/api/src/resolvers/labels/index.ts
+++ b/packages/api/src/resolvers/labels/index.ts
@@ -31,15 +31,13 @@ import { createPubSubClient } from '../../datalayer/pubsub'
 import { AppDataSource } from '../../server'
 import { getPageById } from '../../elastic/pages'
 import {
-  deleteLabelForHighlights,
-  deleteLabelInPages,
+  deleteLabel,
   setLabelsForHighlight,
   updateLabelInPage,
   updateLabelsInPage,
 } from '../../elastic/labels'
 import { getHighlightById } from '../../elastic/highlights'
 import { getLabelsByIds } from '../../services/labels'
-import { PageContext } from '../../elastic/types'
 
 export const labelsResolver = authorized<LabelsSuccess, LabelsError>(
   async (_obj, _params, { claims: { uid }, log }) => {
@@ -180,13 +178,11 @@ export const deleteLabelResolver = authorized<
       }
     }
 
-    const ctx: PageContext = {
+    // delete label in elastic pages and highlights
+    await deleteLabel(uid, labelId, {
       pubsub: createPubSubClient(),
       uid,
-    }
-    // delete label in elastic pages and highlights
-    await deleteLabelInPages(uid, label.name, ctx)
-    await deleteLabelForHighlights(uid, label.name, ctx)
+    })
 
     analytics.track({
       userId: uid,

From 2dcab66af2809c9bcce21cbadbe7f8ebcce33015 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 8 Jun 2022 17:39:38 +0800
Subject: [PATCH 15/15] Update labels for both pages and highlights

---
 packages/api/src/elastic/labels.ts         | 41 ++++++++++++++++------
 packages/api/src/resolvers/labels/index.ts | 11 ++----
 2 files changed, 34 insertions(+), 18 deletions(-)

diff --git a/packages/api/src/elastic/labels.ts b/packages/api/src/elastic/labels.ts
index 990c15449..58cd9ab83 100644
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@@ -95,7 +95,6 @@ export const updateLabelsInPage = async (
 }
 
 export const deleteLabel = async (
-  userId: string,
   label: string,
   ctx: PageContext
 ): Promise<boolean> => {
@@ -119,7 +118,7 @@ export const deleteLabel = async (
           bool: {
             must: {
               term: {
-                userId,
+                userId: ctx.uid,
               },
             },
             should: [
@@ -167,7 +166,7 @@ export const deleteLabel = async (
   }
 }
 
-export const updateLabelInPage = async (
+export const updateLabel = async (
   label: Label,
   ctx: PageContext
 ): Promise<boolean> => {
@@ -176,8 +175,14 @@ export const updateLabelInPage = async (
       index: INDEX_ALIAS,
       body: {
         script: {
-          source: `ctx._source.labels.removeIf(l -> l.id == params.label.id);
-                   ctx._source.labels.add(params.label)`,
+          source: `if (ctx._source.labels != null) {
+                     ctx._source.labels.removeIf(l -> l.id == params.label.id);
+                     ctx._source.labels.add(params.label)
+                   }
+                   if (ctx._source.highlights != null) {
+                     ctx._source.highlights[0].labels.removeIf(l -> l.id == params.label.id);
+                     ctx._source.highlights[0].labels.add(params.label)
+                   }`,
           lang: 'painless',
           params: {
             label: label,
@@ -185,12 +190,12 @@ export const updateLabelInPage = async (
         },
         query: {
           bool: {
-            filter: [
-              {
-                term: {
-                  userId: ctx.uid,
-                },
+            must: {
+              term: {
+                userId: ctx.uid,
               },
+            },
+            should: [
               {
                 nested: {
                   path: 'labels',
@@ -201,7 +206,23 @@ export const updateLabelInPage = async (
                   },
                 },
               },
+              {
+                nested: {
+                  path: 'highlights',
+                  query: {
+                    nested: {
+                      path: 'highlights.labels',
+                      query: {
+                        term: {
+                          'highlights.labels.id': label.id,
+                        },
+                      },
+                    },
+                  },
+                },
+              },
             ],
+            minimum_should_match: 1,
           },
         },
       },
diff --git a/packages/api/src/resolvers/labels/index.ts b/packages/api/src/resolvers/labels/index.ts
index f11c35c80..0a0bd1566 100644
--- a/packages/api/src/resolvers/labels/index.ts
+++ b/packages/api/src/resolvers/labels/index.ts
@@ -33,7 +33,7 @@ import { getPageById } from '../../elastic/pages'
 import {
   deleteLabel,
   setLabelsForHighlight,
-  updateLabelInPage,
+  updateLabel,
   updateLabelsInPage,
 } from '../../elastic/labels'
 import { getHighlightById } from '../../elastic/highlights'
@@ -179,7 +179,7 @@ export const deleteLabelResolver = authorized<
     }
 
     // delete label in elastic pages and highlights
-    await deleteLabel(uid, labelId, {
+    await deleteLabel(labelId, {
       pubsub: createPubSubClient(),
       uid,
     })
@@ -322,15 +322,10 @@ export const updateLabelResolver = authorized<
       }
     }
 
-    const updated = await updateLabelInPage(label, {
+    await updateLabel(label, {
       pubsub,
       uid,
     })
-    if (!updated) {
-      return {
-        errorCodes: [UpdateLabelErrorCode.BadRequest],
-      }
-    }
 
     return { label }
   } catch (error) {