prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add some new requirements to selecting scrollable elements

Browse source 
1. The element must have some height to its bounding rect, this
can prevent strange things like meta tags from being used as the
anchor.

2. The element must be a <p> tag: the intent is to take the user
to a readable position, so this should fit better and eliminates
using things like outer container elements that could span the
entire document.
This commit is contained in:
Jackson Harper 2023-04-10 17:10:20 +08:00
parent 4c5c47c746
commit 22e0a0cbe4
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/web/lib/anchorElements.ts
View file

@ -11,12 +11,16 @@ export const getTopOmnivoreAnchorElement = (
): string | undefined => {
let topVisibleRect: Element | undefined = undefined
const anchors = Array.from(
document.querySelectorAll(`[data-omnivore-anchor-idx]`)
document.querySelectorAll(`p[data-omnivore-anchor-idx]`)
).reverse()
for (const anchor of anchors) {
const rect = anchor.getBoundingClientRect()
if (rect.top >= 0 && rect.bottom <= articleContentElement.clientHeight) {
if (
rect.height > 0 &&
rect.top >= 50 &&
rect.bottom <= articleContentElement.clientHeight
) {
if (
topVisibleRect &&
topVisibleRect.getBoundingClientRect().top < rect.top