prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do debouncing in scrollWatcher instead of using lodash

Browse source
This commit is contained in:
Jackson Harper 2023-03-10 14:27:38 +08:00
parent 4d2698145a
commit 2192c563a7
1 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/web/components/templates/article/Article.tsx
View file

@ -8,7 +8,6 @@ import { MutableRefObject, useEffect, useMemo, useRef, useState } from 'react'
import { Tweet } from 'react-twitter-widgets'
import { render } from 'react-dom'
import { isDarkTheme } from '../../../lib/themeUpdater'
import debounce from 'lodash/debounce'
import { ArticleMutations } from '../../../lib/articleActions'
export type ArticleProps = {
@ -38,22 +37,6 @@ export function Article(props: ArticleProps): JSX.Element {
useReadingProgressAnchor(articleContentRef, setReadingAnchorIndex)
const debouncedSetReadingProgress = useMemo(
() =>
debounce((readingProgress: number) => {
setReadingProgress(readingProgress)
}, 2000),
[]
)
// Stop the invocation of the debounced function
// after unmounting
useEffect(() => {
return () => {
debouncedSetReadingProgress.cancel()
}
}, [])
useEffect(() => {
;(async () => {
if (!readingProgress) return
@ -99,7 +82,7 @@ export function Article(props: ArticleProps): JSX.Element {
window.scrollY,
window.document.scrollingElement.scrollHeight
)
debouncedSetReadingProgress(adjustedReadingProgress * 100)
setReadingProgress(adjustedReadingProgress * 100)
}
}, 2500)