prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1185 from omnivore-app/fix/add-lookup-menu-to-pdf

Browse source 
Add the Lookup (define) menu item to PDF
This commit is contained in:
Jackson Harper 2022-09-12 12:19:43 +08:00 committed by GitHub
commit 1fafcd84bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apple/OmnivoreKit/Sources/App/PDFSupport/PDFViewer.swift
View file

@ -88,6 +88,7 @@ import Utils
}
.onShouldShowMenuItemsForSelectedText(perform: { pageView, menuItems, selectedText in
let copy = menuItems.first(where: { $0.identifier == "Copy" })
let define = menuItems.first(where: { $0.identifier == "Define" })
let highlight = MenuItem(title: "Highlight", block: {
_ = coordinator.highlightSelection(
pageView: pageView,
@ -101,7 +102,8 @@ import Utils
// shareLink = ShareLink(id: UUID(), url: shareURL)
// }
// })
return [copy, highlight /* , share */ ].compactMap { $0 }
define?.title = "Lookup"
return [copy, highlight, define].compactMap { $0 }
})
.onShouldShowMenuItemsForSelectedAnnotations(perform: { _, menuItems, annotations in
var result = [MenuItem]()