refactor: update router function signatures to explicitly return express.Router

packages/api/src/routers/ai_summary_router.ts

@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
-import { htmlToSpeechFile } from '@omnivore/text-to-speech-handler/build/src/htmlToSsml'
+// import { htmlToSpeechFile } from '@omnivore/text-to-speech-handler/build/src/htmlToSsml'
 import cors from 'cors'
 import express from 'express'
 import { userRepository } from '../repository/user'
@@ -8,7 +8,7 @@ import { getClaimsByToken } from '../utils/auth'
 import { corsConfig } from '../utils/corsConfig'
 import { getAISummary } from '../services/ai-summaries'
 
-export function aiSummariesRouter() {
+export function aiSummariesRouter(): express.Router {
   const router = express.Router()
 
   // Get an indexed summary for an individual library item

packages/api/src/routers/article_router.ts

@@ -25,7 +25,7 @@ interface SpeechInput {
 }
 const outputFormats = ['mp3', 'speech-marks', 'speech']
 
-export function articleRouter() {
+export function articleRouter(): express.Router {
   const router = express.Router()
 
   router.options('/save', cors<express.Request>({ ...corsConfig, maxAge: 600 }))

packages/api/src/routers/auth/auth_router.ts

@@ -107,7 +107,7 @@ export const isValidSignupRequest = (obj: any): obj is SignupRequest => {
   )
 }
 
-export function authRouter() {
+export function authRouter(): express.Router {
   const router = express.Router()
 
   router.post('/apple-redirect', curriedAuthHandler('APPLE', false))

packages/api/src/routers/auth/mobile/mobile_auth_router.ts

@@ -15,7 +15,7 @@ import { env } from '../../../env'
 import { corsConfig } from '../../../utils/corsConfig'
 import cors from 'cors'
 
-export function mobileAuthRouter() {
+export function mobileAuthRouter(): express.Router {
   const router = express.Router()
 
   router.post('/sign-in', async (req, res) => {

packages/api/src/routers/content_router.ts

@@ -12,7 +12,7 @@ import {
   isFileExists,
 } from '../utils/uploads'
 
-export function contentRouter() {
+export function contentRouter(): express.Router {
   const router = Router()
 
   interface GetContentRequest {

packages/api/src/routers/digest_router.ts

@@ -43,7 +43,7 @@ interface CreateDigestRequest {
   libraryItemIds?: string[]
 }
 
-export function digestRouter() {
+export function digestRouter(): express.Router {
   const router = express.Router()
 
   router.options('/v1', cors<express.Request>({ ...corsConfig, maxAge: 600 }))

packages/api/src/routers/explain_router.ts

@@ -9,7 +9,7 @@ import { getAISummary } from '../services/ai-summaries'
 import { explainText } from '../services/explain'
 import { FeatureName, findGrantedFeatureByName } from '../services/features'
 
-export function explainRouter() {
+export function explainRouter(): express.Router {
   const router = express.Router()
 
   // Get an indexed summary for an individual library item

packages/api/src/routers/export_router.ts

@@ -13,7 +13,7 @@ import { corsConfig } from '../utils/corsConfig'
 import { queueExportJob } from '../utils/createTask'
 import { logger } from '../utils/logger'
 
-export function exportRouter() {
+export function exportRouter(): express.Router {
   const router = Router()
 
   // eslint-disable-next-line @typescript-eslint/no-misused-promises

packages/api/src/routers/integration_router.ts

@@ -7,7 +7,7 @@ import { getClaimsByToken } from '../utils/auth'
 import { corsConfig } from '../utils/corsConfig'
 import { logger } from '../utils/logger'
 
-export function integrationRouter() {
+export function integrationRouter(): express.Router {
   const router = express.Router()
   // request token from pocket
   router.post(

packages/api/src/routers/notification_router.ts

@@ -18,7 +18,7 @@ interface Notification {
   notificationType?: PushNotificationType
 }
 
-export function notificationRouter() {
+export function notificationRouter(): express.Router {
   const router = express.Router()
 
   router.options('/send', cors<express.Request>({ ...corsConfig, maxAge: 600 }))

packages/api/src/routers/page_router.ts

@@ -34,7 +34,7 @@ import {
   generateUploadSignedUrl,
 } from '../utils/uploads'
 
-export function pageRouter() {
+export function pageRouter(): express.Router {
   const router = express.Router()
 
   // Create a page from an uploaded PDF document

packages/api/src/routers/shortcuts_router.ts

@@ -13,7 +13,7 @@ import { getClaimsByToken, getTokenByRequest } from '../utils/auth'
 import { corsConfig } from '../utils/corsConfig'
 import { logger } from '../utils/logger'
 
-export function shortcutsRouter() {
+export function shortcutsRouter(): express.Router {
   const router = express.Router()
 
   router.get(

packages/api/src/routers/svc/content.ts

@@ -9,7 +9,7 @@ import {
   updateContentForFileItem,
 } from '../../services/update_pdf_content'
 
-export function contentServiceRouter() {
+export function contentServiceRouter(): express.Router {
   const router = express.Router()
 
   router.post('/search', async (req, res) => {

packages/api/src/routers/svc/email_attachment.ts

@@ -24,7 +24,7 @@ import {
   getStorageFileDetails,
 } from '../../utils/uploads'
 
-export function emailAttachmentRouter() {
+export function emailAttachmentRouter(): express.Router {
   const router = express.Router()
 
   // eslint-disable-next-line @typescript-eslint/no-misused-promises

packages/api/src/routers/svc/emails.ts

@@ -34,7 +34,7 @@ function isEmailMessage(data: any): data is EmailMessage {
   return 'from' in data && 'to' in data
 }
 
-export function emailsServiceRouter() {
+export function emailsServiceRouter(): express.Router {
   const router = express.Router()
 
   // eslint-disable-next-line @typescript-eslint/no-misused-promises

packages/api/src/routers/svc/following.ts

@@ -49,7 +49,7 @@ function isSaveFollowingItemRequest(
 
 const FOLDER = 'following'
 
-export function followingServiceRouter() {
+export function followingServiceRouter(): express.Router {
   const router = express.Router()
 
   router.post(

packages/api/src/routers/svc/links.ts

@@ -18,7 +18,7 @@ type PruneMessage = {
   ttlInDays?: number
 }
 
-export function linkServiceRouter() {
+export function linkServiceRouter(): express.Router {
   const router = express.Router()
 
   router.post(

packages/api/src/routers/svc/newsletters.ts

@@ -30,7 +30,7 @@ const isNewsletterMessage = (data: any): data is NewsletterMessage => {
   )
 }
 
-export function newsletterServiceRouter() {
+export function newsletterServiceRouter(): express.Router {
   const router = express.Router()
 
   // eslint-disable-next-line @typescript-eslint/no-misused-promises

packages/api/src/routers/svc/rss_feed.ts

@@ -5,7 +5,7 @@ import { readPushSubscription } from '../../pubsub'
 import { redisDataSource } from '../../redis_data_source'
 import { logger } from '../../utils/logger'
 
-export function rssFeedRouter() {
+export function rssFeedRouter(): express.Router {
   const router = express.Router()
 
   router.post(

packages/api/src/routers/svc/upload.ts

@@ -9,7 +9,7 @@ import { readPushSubscription } from '../../pubsub'
 import { logger } from '../../utils/logger'
 import { uploadToBucket } from '../../utils/uploads'
 
-export function uploadServiceRouter() {
+export function uploadServiceRouter(): express.Router {
   const router = express.Router()
 
   router.post(

packages/api/src/routers/svc/user.ts

@@ -31,7 +31,7 @@ const getCleanupMessage = (msgStr: string): CleanupMessage => {
   }
 }
 
-export function userServiceRouter() {
+export function userServiceRouter(): express.Router {
   const router = express.Router()
 
   router.post('/prune', cors<express.Request>(corsConfig), async (req, res) => {

packages/api/src/routers/svc/webhooks.ts

@@ -8,7 +8,7 @@ import { readPushSubscription } from '../../pubsub'
 import { authTrx } from '../../repository'
 import { logger } from '../../utils/logger'
 
-export function webhooksServiceRouter() {
+export function webhooksServiceRouter(): express.Router {
   const router = express.Router()
 
   router.post(

packages/api/src/routers/task_router.ts

@@ -7,7 +7,7 @@ import { corsConfig } from '../utils/corsConfig'
 import { logger } from '../utils/logger'
 import { JobState } from 'bullmq'
 
-export function taskRouter() {
+export function taskRouter(): express.Router {
   const router = express.Router()
 
   router.get(

packages/api/src/routers/text_to_speech.ts

@@ -9,7 +9,7 @@ import { getClaimsByToken } from '../utils/auth'
 import { corsConfig } from '../utils/corsConfig'
 import { logger } from '../utils/logger'
 
-export function textToSpeechRouter() {
+export function textToSpeechRouter(): express.Router {
   const router = express.Router()
 
   router.options('/', cors<express.Request>({ ...corsConfig, maxAge: 600 }))

packages/api/src/routers/user_router.ts

@@ -9,7 +9,7 @@ import { corsConfig } from '../utils/corsConfig'
 import { logger } from '../utils/logger'
 import { sendEmail } from '../utils/sendEmail'
 
-export function userRouter() {
+export function userRouter(): express.Router {
   const router = express.Router()
 
   router.post(