diff --git a/android/Omnivore/app/src/main/java/app/omnivore/omnivore/AppModule.kt b/android/Omnivore/app/src/main/java/app/omnivore/omnivore/AppModule.kt index 246dcdd96..7acc7aad2 100644 --- a/android/Omnivore/app/src/main/java/app/omnivore/omnivore/AppModule.kt +++ b/android/Omnivore/app/src/main/java/app/omnivore/omnivore/AppModule.kt @@ -32,6 +32,7 @@ object AppModule { ): Analytics { val writeKey = app.getString(R.string.segment_write_key) + // TODO: abstract analytics to custom class return Analytics(writeKey, app.applicationContext) { trackApplicationLifecycleEvents = true application = app.applicationContext diff --git a/android/Omnivore/app/src/main/java/app/omnivore/omnivore/ui/reader/WebReader.kt b/android/Omnivore/app/src/main/java/app/omnivore/omnivore/ui/reader/WebReader.kt index debcfefbb..7b4417258 100644 --- a/android/Omnivore/app/src/main/java/app/omnivore/omnivore/ui/reader/WebReader.kt +++ b/android/Omnivore/app/src/main/java/app/omnivore/omnivore/ui/reader/WebReader.kt @@ -270,7 +270,7 @@ class OmnivoreWebView(context: Context) : WebView(context) { // Called when the user selects a contextual menu item override fun onActionItemClicked(mode: ActionMode, item: MenuItem): Boolean { return when (item.itemId) { - R.id.annotateHighlight -> { + R.id.annotateHighlight, R.id.annotate -> { val script = "var event = new Event('annotate');document.dispatchEvent(event);" evaluateJavascript(script) { mode.finish() diff --git a/android/Omnivore/app/src/main/res/menu/pdf_text_selection_menu.xml b/android/Omnivore/app/src/main/res/menu/pdf_text_selection_menu.xml index 37f081f74..3e0b9a8c0 100644 --- a/android/Omnivore/app/src/main/res/menu/pdf_text_selection_menu.xml +++ b/android/Omnivore/app/src/main/res/menu/pdf_text_selection_menu.xml @@ -1,6 +1,12 @@