From 0e4a1fcefde48b1283abdb5d33301a849ce623fe Mon Sep 17 00:00:00 2001 From: gitstart-omnivore Date: Thu, 24 Mar 2022 23:10:31 +0000 Subject: [PATCH] effected review corrections --- packages/web/components/patterns/LinkedItemCard.tsx | 13 ++++++------- .../templates/homeFeed/HomeFeedContainer.tsx | 7 +++---- packages/web/components/tokens/stitches.config.ts | 6 ++++-- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/web/components/patterns/LinkedItemCard.tsx b/packages/web/components/patterns/LinkedItemCard.tsx index 4dbac4b77..6e951e308 100644 --- a/packages/web/components/patterns/LinkedItemCard.tsx +++ b/packages/web/components/patterns/LinkedItemCard.tsx @@ -88,7 +88,6 @@ export function GridLinkedItemCard(props: LinkedItemCardProps): JSX.Element { onClick={() => { props.handleAction('showDetail') }} - className="grid-item-card" > {props.item.description} - {/* {props.item.image && ( */} + {props.item.image && ( { - // (e.target as HTMLElement).style.display = 'none' + (e.target as HTMLElement).style.display = 'none' }} /> - {/* )} */} + )} { - Labels.map(({text, color}, index) => diff --git a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx index c8ac93657..de901747f 100644 --- a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx +++ b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx @@ -1,7 +1,6 @@ import { Box, HStack, VStack } from './../../elements/LayoutPrimitives' import { useGetLibraryItemsQuery } from '../../../lib/networking/queries/useGetLibraryItemsQuery' import { useGetViewerQuery } from '../../../lib/networking/queries/useGetViewerQuery' -import { isDarkTheme } from '../../../lib/themeUpdater' import type { LibraryItem, LibraryItemsQueryInput, @@ -572,12 +571,12 @@ function HomeFeedGrid(props: HomeFeedContentProps): JSX.Element { }, '&:focus': { '> div': { - boxShadow: isDarkTheme() ? '$cardItemDarkShadow' : '$cardItemLightShadow', + boxShadow: layout === 'LIST_LAYOUT' ? 'none' : '$cardItemShadow', } }, '&:hover': { - '> div.grid-item-card': { - boxShadow: isDarkTheme() ? '$cardItemDarkShadow' : '$cardItemLightShadow', + '> div': { + boxShadow: layout === 'LIST_LAYOUT' ? 'none' : '$cardItemShadow', } }, }} diff --git a/packages/web/components/tokens/stitches.config.ts b/packages/web/components/tokens/stitches.config.ts index 69650c19b..2546910a7 100644 --- a/packages/web/components/tokens/stitches.config.ts +++ b/packages/web/components/tokens/stitches.config.ts @@ -111,8 +111,7 @@ export const { styled, css, theme, getCssText, globalCss, keyframes, config } = borderStyles: {}, shadows: { panelShadow: '0px 4px 18px rgba(120, 123, 134, 0.12)', - cardItemLightShadow: '0px 8px 32px rgba(32, 31, 29, 0.33)', - cardItemDarkShadow: '0px 8px 32px rgba(255, 255, 255, 0.33)', + cardItemShadow: '0px 8px 32px rgba(32, 31, 29, 0.33)', }, zIndices: {}, transitions: {}, @@ -213,6 +212,9 @@ const darkThemeSpec = { avatarBg: '#000000', avatarFont: 'rgba(255, 255, 255, 0.8)', }, + shadows: { + cardItemShadow: '0px 8px 32px rgba(255, 255, 255, 0.33)', + }, } // Dark and Darker theme now match each other.