Change order of ctx arguments

packages/import-handler/src/csv.ts

@@ -7,7 +7,7 @@ import { parse } from '@fast-csv/parse'
 import { Stream } from 'stream'
 import { ImportContext } from '.'
 
-export const importCsv = async (stream: Stream, ctx: ImportContext) => {
+export const importCsv = async (ctx: ImportContext, stream: Stream) => {
   const parser = parse()
   stream.pipe(parser)
   for await (const row of parser) {

packages/import-handler/src/index.ts

@@ -1,7 +1,3 @@
-import {
-  EventFunction,
-  CloudFunctionsContext,
-} from '@google-cloud/functions-framework/build/src/functions'
 import { Storage } from '@google-cloud/storage'
 import { importCsv } from './csv'
 import * as path from 'path'
@@ -44,10 +40,7 @@ export type ImportContext = {
   contentHandler: ContentHandler
 }
 
-type importHandlerFunc = (
-  stream: Stream,
-  handler: ImportContext
-) => Promise<void>
+type importHandlerFunc = (ctx: ImportContext, stream: Stream) => Promise<void>
 
 interface StorageEvent {
   name: string
@@ -188,20 +181,20 @@ const handleEvent = async (data: StorageEvent) => {
       return
     }
 
-    const countFailed = 0
-    const countImported = 0
-    await handler(stream, {
+    const ctx = {
       userId,
       countImported: 0,
       countFailed: 0,
       urlHandler,
       contentHandler,
-    })
+    }
 
-    if (countImported <= 1) {
+    await handler(ctx, stream)
+
+    if (ctx.countImported <= 1) {
       await sendImportFailedEmail(userId)
     } else {
-      await sendImportCompletedEmail(userId, countImported, countFailed)
+      await sendImportCompletedEmail(userId, ctx.countImported, ctx.countFailed)
     }
   }
 }

packages/import-handler/src/matterHistory.ts

@@ -21,8 +21,8 @@ import { ImportContext } from '.'
 export type UrlHandler = (url: URL) => Promise<void>
 
 export const importMatterHistoryCsv = async (
-  stream: Stream,
-  ctx: ImportContext
+  ctx: ImportContext,
+  stream: Stream
 ): Promise<void> => {
   const parser = parse({
     headers: true,
@@ -202,8 +202,8 @@ const handleMatterHistoryRow = async (
 }
 
 export const importMatterArchive = async (
-  stream: Stream,
-  ctx: ImportContext
+  ctx: ImportContext,
+  stream: Stream
 ): Promise<void> => {
   const archiveDir = await unarchive(stream)
 

packages/import-handler/test/csv/csv.test.ts

@@ -19,7 +19,7 @@ describe('Load a simple CSV file', () => {
       return Promise.resolve()
     }
 
-    await importCsv(stream, stub)
+    await importCsv(stub, stream)
     expect(stub.countFailed).to.equal(0)
     expect(stub.countImported).to.equal(2)
     expect(urls).to.eql([

packages/import-handler/test/matter/matter_importer.test.ts

@@ -23,7 +23,7 @@ describe('Load a simple _matter_history file', () => {
       return Promise.resolve()
     }
 
-    await importMatterHistoryCsv(stream, stub)
+    await importMatterHistoryCsv(stub, stream)
     expect(stub.countFailed).to.equal(0)
     expect(stub.countImported).to.equal(1)
     expect(urls).to.eql([