From 0a8db1e4773b40f8846ba0ccc36a63f3932873ba Mon Sep 17 00:00:00 2001
From: Satindar Dhillon <satindar@gmail.com>
Date: Wed, 23 Feb 2022 15:39:03 -0800
Subject: [PATCH] remove extra public calls in registration view model

---
 .../Binders/Scenes/RegistrationScene.swift    | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/apple/OmnivoreKit/Sources/Binders/Scenes/RegistrationScene.swift b/apple/OmnivoreKit/Sources/Binders/Scenes/RegistrationScene.swift
index 9139fc21c..f33a07db4 100644
--- a/apple/OmnivoreKit/Sources/Binders/Scenes/RegistrationScene.swift
+++ b/apple/OmnivoreKit/Sources/Binders/Scenes/RegistrationScene.swift
@@ -6,20 +6,21 @@ import SwiftUI
 import Utils
 import Views
 
-public final class RegistrationViewModel: ObservableObject {
-  @Published public var loginError: LoginError?
-  @Published public var createProfileViewModel: CreateProfileViewModel?
-  @Published public var newAppleSignupViewModel: NewAppleSignupViewModel?
+// TODO: remove this view model
+final class RegistrationViewModel: ObservableObject {
+  @Published var loginError: LoginError?
+  @Published var createProfileViewModel: CreateProfileViewModel?
+  @Published var newAppleSignupViewModel: NewAppleSignupViewModel?
 
-  public enum Action {
+  enum Action {
     case googleButtonTapped
     case appleSignInCompleted(result: Result<ASAuthorization, Error>)
   }
 
-  public var subscriptions = Set<AnyCancellable>()
-  public let performActionSubject = PassthroughSubject<Action, Never>()
+  var subscriptions = Set<AnyCancellable>()
+  let performActionSubject = PassthroughSubject<Action, Never>()
 
-  public init() {}
+  init() {}
 }
 
 extension RegistrationViewModel {
@@ -132,11 +133,11 @@ private func presentingViewController() -> PlatformViewController? {
   #endif
 }
 
-public struct RegistrationView: View {
+struct RegistrationView: View {
   @Environment(\.horizontalSizeClass) var horizontalSizeClass
   @ObservedObject private var viewModel: RegistrationViewModel
 
-  public init(viewModel: RegistrationViewModel) {
+  init(viewModel: RegistrationViewModel) {
     self.viewModel = viewModel
   }
 
@@ -176,7 +177,7 @@ public struct RegistrationView: View {
     }
   }
 
-  public var body: some View {
+  var body: some View {
     if let createProfileViewModel = viewModel.createProfileViewModel {
       CreateProfileView(viewModel: createProfileViewModel)
     } else if let newAppleSignupViewModel = viewModel.newAppleSignupViewModel {