Merge pull request #955 from omnivore-app/fix/duplicate-save

check if page saved by adding links before creating by extension
This commit is contained in:
Hongbo Wu 2022-07-13 11:57:20 +08:00 committed by GitHub
commit 098771f566
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -329,20 +329,15 @@ export const createArticleResolver = authorized<
)
}
// create new page in elastic
if (!pageId) {
const newPageId = await createPage(articleToSave, { ...ctx, uid })
if (!newPageId) {
return pageError(
{
errorCodes: [CreateArticleErrorCode.ElasticError],
},
ctx,
pageId
)
}
articleToSave.id = newPageId
} else {
if (
pageId ||
(pageId = (
await getPageByParam({
userId: uid,
url: articleToSave.url,
})
)?.id)
) {
// update existing page's state from processing to succeeded
articleToSave.archivedAt = archive ? saveTime : null
const updated = await updatePage(pageId, articleToSave, {
@ -359,6 +354,19 @@ export const createArticleResolver = authorized<
pageId
)
}
} else {
// create new page in elastic
const newPageId = await createPage(articleToSave, { ...ctx, uid })
if (!newPageId) {
return pageError(
{
errorCodes: [CreateArticleErrorCode.ElasticError],
},
ctx,
pageId
)
}
articleToSave.id = newPageId
}
log.info(