prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1981 from omnivore-app/fix/rule

Browse source 
Disable push notification action in rules engine
This commit is contained in:
Hongbo Wu 2023-04-05 14:41:02 +08:00 committed by GitHub
commit 00d0cc2dd1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
packages/rule-handler/src/rule.ts
View file

@ -1,9 +1,8 @@
import { NotificationData, sendNotification } from './notification'
import { getAuthToken, PubSubData } from './index'
import axios, { AxiosResponse } from 'axios'
import { filterPage } from './filter'
import { getAuthToken, PubSubData } from './index'
import { setLabels } from './label'
import { archivePage, markPageAsRead } from './page'
import { filterPage } from './filter'
export enum RuleActionType {
AddLabel = 'ADD_LABEL',
@ -141,25 +140,25 @@ export const triggerActions = async (
filteredPage.readingProgressPercent < 100 &&
actionPromises.push(markPageAsRead(apiEndpoint, authToken, data.id))
)
case RuleActionType.SendNotification: {
const data: NotificationData = {
title: 'New page added to your library',
body: filteredPage.title,
image: filteredPage.image || undefined,
}
// case RuleActionType.SendNotification: {
// const data: NotificationData = {
// title: 'New page added to your library',
// body: filteredPage.title,
// image: filteredPage.image || undefined,
// }
const params = action.params
if (params.length > 0) {
const param = JSON.parse(params[0]) as NotificationData
data.body = param.body || data.body
data.title = param.title || data.title
data.image = param.image || data.image
}
// const params = action.params
// if (params.length > 0) {
// const param = JSON.parse(params[0]) as NotificationData
// data.body = param.body || data.body
// data.title = param.title || data.title
// data.image = param.image || data.image
// }
return actionPromises.push(
sendNotification(apiEndpoint, authToken, data)
)
}
// return actionPromises.push(
// sendNotification(apiEndpoint, authToken, data)
// )
// }
}
})
}

2
packages/web/lib/networking/queries/useGetRulesQuery.tsx
View file

@ -11,7 +11,7 @@ export enum RuleActionType {
AddLabel = 'ADD_LABEL',
Archive = 'ARCHIVE',
MarkAsRead = 'MARK_AS_READ',
SendNotification = 'SEND_NOTIFICATION',
// SendNotification = 'SEND_NOTIFICATION',
}
export interface Rule {