mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2026-03-11 08:54:48 +00:00
c7d318236f
Replace a QVector for the wordlist with a QSet. This removes all duplicate entries in a given wordlist. Thus, it hinders a malicious wordlist that has the proper length (>4000 entries) but with repetitions (effectively << 4000 entries) to be used and potentially create weaker passphrases than estimated. Example: List with 4000 items but only 64 unique words would lead to only 48 bit of Entropy instead of ~95 bit!
82 lines
2.9 KiB
C++
82 lines
2.9 KiB
C++
/*
|
|
* Copyright (C) 2019 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "Diceware.h"
|
|
|
|
#include "Utils.h"
|
|
#include "core/Global.h"
|
|
#include "core/PassphraseGenerator.h"
|
|
|
|
#include <QCommandLineParser>
|
|
|
|
const QCommandLineOption Diceware::WordCountOption =
|
|
QCommandLineOption(QStringList() << "W" << "words",
|
|
QObject::tr("Word count for the diceware passphrase."),
|
|
QObject::tr("count", "CLI parameter"));
|
|
|
|
const QCommandLineOption Diceware::WordListOption =
|
|
QCommandLineOption(QStringList() << "w" << "word-list",
|
|
QObject::tr("Wordlist for the diceware generator.\n[Default: EFF English]"),
|
|
QObject::tr("path"));
|
|
|
|
Diceware::Diceware()
|
|
{
|
|
name = QString("diceware");
|
|
description = QObject::tr("Generate a new random diceware passphrase.");
|
|
options.append(Diceware::WordCountOption);
|
|
options.append(Diceware::WordListOption);
|
|
}
|
|
|
|
int Diceware::execute(const QStringList& arguments)
|
|
{
|
|
QSharedPointer<QCommandLineParser> parser = getCommandLineParser(arguments);
|
|
if (parser.isNull()) {
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
auto& out = Utils::STDOUT;
|
|
auto& err = Utils::STDERR;
|
|
|
|
PassphraseGenerator dicewareGenerator;
|
|
|
|
QString wordCount = parser->value(Diceware::WordCountOption);
|
|
if (wordCount.isEmpty()) {
|
|
dicewareGenerator.setWordCount(PassphraseGenerator::DefaultWordCount);
|
|
} else if (wordCount.toInt() <= 0) {
|
|
err << QObject::tr("Invalid word count %1").arg(wordCount) << Qt::endl;
|
|
return EXIT_FAILURE;
|
|
} else {
|
|
dicewareGenerator.setWordCount(wordCount.toInt());
|
|
}
|
|
|
|
QString wordListFile = parser->value(Diceware::WordListOption);
|
|
if (!wordListFile.isEmpty()) {
|
|
dicewareGenerator.setWordList(wordListFile);
|
|
}
|
|
|
|
if (!dicewareGenerator.isValid()) {
|
|
// We already validated the word count input so if the generator is invalid, it
|
|
// must be because the word list is too small.
|
|
err << QObject::tr("Cannot generate valid passphrases because the wordlist is too short") << Qt::endl;
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
QString password = dicewareGenerator.generatePassphrase();
|
|
out << password << Qt::endl;
|
|
|
|
return EXIT_SUCCESS;
|
|
}
|