mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2026-03-11 08:54:48 +00:00
22811471ac
* Entry placeholder resolution: don't overdo it
After resolving placeholders, previously the code would do it all over again if anything had changed, multiple times up to the recursion limit. This would have the effect of applying a much greater recursion limit, which is confusing and unnecessary, and probably undesired.
* Entry tweaks and minor refactoring
- Entry::size(): when computing tag size, use same delimiter set as in other places in the code
- Factor tag delimiter set regex out into global constant
- Placeholder resolution: remove unnecessary special casing for self-referential placeholders (these are taken care of by existing recursion depth limit)
- Placeholder resolution: less wasteful string building loop
- Move some constants from being public static data members of Entry to being local to Entry.cpp (in anonymous namespace)
- Migrate some QRegEx instances to QRegularExpression, the modern alternative
- Miscellanous minor code cleanups
* Entry: fix hitting recursion limit with {braces}
When encountering a {brace-enclosed} substring, the placeholder resolution logic would previously keep recursing until it hit the recursion depth limit (currently 10). This would lead to "Maximum depth of replacement has been reached" messages, and was also wasting CPU cycles.
Fixes #1741
---------
Co-authored-by: Jonathan White <support@dmapps.us>
|
||
|---|---|---|
| .. | ||
| autotype | ||
| browser | ||
| cli | ||
| core | ||
| crypto | ||
| fdosecrets | ||
| format | ||
| gui | ||
| keeshare | ||
| keys | ||
| post_install | ||
| proxy | ||
| qrcode | ||
| sshagent | ||
| streams | ||
| thirdparty | ||
| touchid | ||
| updatecheck | ||
| winhello | ||
| CMakeLists.txt | ||
| config-keepassx.h.cmake | ||
| git-info.h.cmake | ||
| main.cpp | ||