mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2026-03-11 08:54:48 +00:00
The CLI module was lacking unit test coverage and showed some severe coding style violations, which this patch addresses. In addition, all uses of qCritical() with untranslatble raw char* sequences were removed in favor of proper locale strings. These are written to STDERR through QTextStreams and support output redirection for testing purposes. With this change, error messages don't depend on the global Qt logging settings and targets anymore and go directly to the terminal or into a file if needed. This patch also fixes a bug discovered during unit test development, where the extract command would just dump the raw XML contents without decrypting embedded Salsa20-protected values first, making the XML export mostly useless, since passwords are scrambled. Lastly, all CLI commands received a dedicated -h/--help option.
144 lines
5.6 KiB
C++
144 lines
5.6 KiB
C++
/*
|
|
* Copyright (C) 2010 Felix Geyer <debfx@fobos.de>
|
|
* Copyright (C) 2017 KeePassXC Team <team@keepassxc.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <QFile>
|
|
#include <QTextStream>
|
|
#include <QCommandLineParser>
|
|
|
|
#include "config-keepassx.h"
|
|
#include "core/Bootstrap.h"
|
|
#include "core/Tools.h"
|
|
#include "core/Config.h"
|
|
#include "crypto/Crypto.h"
|
|
#include "gui/Application.h"
|
|
#include "gui/MainWindow.h"
|
|
#include "gui/MessageBox.h"
|
|
#include "cli/Utils.h"
|
|
|
|
#if defined(WITH_ASAN) && defined(WITH_LSAN)
|
|
#include <sanitizer/lsan_interface.h>
|
|
#endif
|
|
|
|
#ifdef QT_STATIC
|
|
#include <QtPlugin>
|
|
|
|
#if defined(Q_OS_WIN)
|
|
Q_IMPORT_PLUGIN(QWindowsIntegrationPlugin)
|
|
#elif defined(Q_OS_UNIX) && !defined(Q_OS_MAC)
|
|
Q_IMPORT_PLUGIN(QXcbIntegrationPlugin)
|
|
#endif
|
|
#endif
|
|
|
|
int main(int argc, char** argv)
|
|
{
|
|
Application app(argc, argv);
|
|
Application::setApplicationName("keepassxc");
|
|
Application::setApplicationVersion(KEEPASSX_VERSION);
|
|
// don't set organizationName as that changes the return value of
|
|
// QStandardPaths::writableLocation(QDesktopServices::DataLocation)
|
|
Bootstrap::bootstrapApplication();
|
|
|
|
QCommandLineParser parser;
|
|
parser.setApplicationDescription(QCoreApplication::translate("main", "KeePassXC - cross-platform password manager"));
|
|
parser.addPositionalArgument("filename",
|
|
QCoreApplication::translate("main", "filenames of the password databases to open (*.kdbx)"), "[filename(s)]");
|
|
|
|
QCommandLineOption configOption(
|
|
"config", QCoreApplication::translate("main", "path to a custom config file"), "config");
|
|
QCommandLineOption keyfileOption(
|
|
"keyfile", QCoreApplication::translate("main", "key file of the database"), "keyfile");
|
|
QCommandLineOption pwstdinOption("pw-stdin",
|
|
QCoreApplication::translate("main", "read password of the database from stdin"));
|
|
// This is needed under Windows where clients send --parent-window parameter with Native Messaging connect method
|
|
QCommandLineOption parentWindowOption(
|
|
QStringList() << "pw" << "parent-window", QCoreApplication::translate("main", "Parent window handle"), "handle");
|
|
|
|
QCommandLineOption helpOption = parser.addHelpOption();
|
|
QCommandLineOption versionOption = parser.addVersionOption();
|
|
parser.addOption(configOption);
|
|
parser.addOption(keyfileOption);
|
|
parser.addOption(pwstdinOption);
|
|
parser.addOption(parentWindowOption);
|
|
|
|
parser.process(app);
|
|
|
|
// Don't try and do anything with the application if we're only showing the help / version
|
|
if (parser.isSet(versionOption) || parser.isSet(helpOption)) {
|
|
return 0;
|
|
}
|
|
|
|
const QStringList fileNames = parser.positionalArguments();
|
|
|
|
if (app.isAlreadyRunning() && !parser.isSet(versionOption)) {
|
|
if (!fileNames.isEmpty()) {
|
|
app.sendFileNamesToRunningInstance(fileNames);
|
|
}
|
|
qWarning() << QCoreApplication::translate("Main", "Another instance of KeePassXC is already running.").toUtf8().constData();
|
|
return 0;
|
|
}
|
|
|
|
QApplication::setQuitOnLastWindowClosed(false);
|
|
|
|
if (!Crypto::init()) {
|
|
QString error = QCoreApplication::translate("Main", "Fatal error while testing the cryptographic functions.");
|
|
error.append("\n");
|
|
error.append(Crypto::errorString());
|
|
MessageBox::critical(nullptr, QCoreApplication::translate("Main", "KeePassXC - Error"), error);
|
|
return 1;
|
|
}
|
|
|
|
if (parser.isSet(configOption)) {
|
|
Config::createConfigFromFile(parser.value(configOption));
|
|
}
|
|
|
|
MainWindow mainWindow;
|
|
app.setMainWindow(&mainWindow);
|
|
QObject::connect(&app, SIGNAL(anotherInstanceStarted()), &mainWindow, SLOT(bringToFront()));
|
|
QObject::connect(&app, SIGNAL(applicationActivated()), &mainWindow, SLOT(bringToFront()));
|
|
QObject::connect(&app, SIGNAL(openFile(QString)), &mainWindow, SLOT(openDatabase(QString)));
|
|
QObject::connect(&app, SIGNAL(quitSignalReceived()), &mainWindow, SLOT(appExit()), Qt::DirectConnection);
|
|
|
|
Bootstrap::restoreMainWindowState(mainWindow);
|
|
|
|
const bool pwstdin = parser.isSet(pwstdinOption);
|
|
for (const QString& filename : fileNames) {
|
|
QString password;
|
|
if (pwstdin) {
|
|
// we always need consume a line of STDIN if --pw-stdin is set to clear out the
|
|
// buffer for native messaging, even if the specified file does not exist
|
|
static QTextStream in(stdin, QIODevice::ReadOnly);
|
|
static QTextStream out(stdout, QIODevice::WriteOnly);
|
|
out << QCoreApplication::translate("Main", "Database password: ") << flush;
|
|
password = Utils::getPassword();
|
|
}
|
|
|
|
if (!filename.isEmpty() && QFile::exists(filename) && !filename.endsWith(".json", Qt::CaseInsensitive)) {
|
|
mainWindow.openDatabase(filename, password, parser.value(keyfileOption));
|
|
}
|
|
}
|
|
|
|
int exitCode = Application::exec();
|
|
|
|
#if defined(WITH_ASAN) && defined(WITH_LSAN)
|
|
// do leak check here to prevent massive tail of end-of-process leak errors from third-party libraries
|
|
__lsan_do_leak_check();
|
|
__lsan_disable();
|
|
#endif
|
|
|
|
return exitCode;
|
|
}
|