From ed60a3dcce8402f36a6264b435f4885f72ffc6db Mon Sep 17 00:00:00 2001 From: Balazs Gyurak Date: Thu, 21 Nov 2019 22:14:57 +0000 Subject: [PATCH] HTML encode url in ElidedLabel * Fix #3905 - prevent double quotes and other invalid HTML characters from impeding on display of url in ElidedLabel --- src/gui/widgets/ElidedLabel.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gui/widgets/ElidedLabel.cpp b/src/gui/widgets/ElidedLabel.cpp index bc2771764..187c2fc43 100644 --- a/src/gui/widgets/ElidedLabel.cpp +++ b/src/gui/widgets/ElidedLabel.cpp @@ -105,8 +105,10 @@ void ElidedLabel::updateElidedText() const QFontMetrics metrix(font()); displayText = metrix.elidedText(m_rawText, m_elideMode, width() - 2); } - setText(m_url.isEmpty() ? displayText : htmlLinkTemplate.arg(m_url, displayText)); - setOpenExternalLinks(!m_url.isEmpty()); + + bool hasUrl = !m_url.isEmpty(); + setText(hasUrl ? htmlLinkTemplate.arg(m_url.toHtmlEscaped(), displayText) : displayText); + setOpenExternalLinks(!hasUrl); } void ElidedLabel::resizeEvent(QResizeEvent* event)