From 7a2c02f0df874e92ae8928008d7520c44a7a8674 Mon Sep 17 00:00:00 2001 From: Felix Geyer Date: Thu, 14 May 2015 16:58:53 +0200 Subject: [PATCH] Initialize some instance variables in ctor. Discovered by Coverity. Most likely doesn't fix any actual bug but better be safe. --- src/format/KeePass1Reader.cpp | 7 ++++++- src/format/KeePass2Reader.cpp | 6 +++++- src/format/KeePass2XmlReader.cpp | 1 + src/streams/SymmetricCipherStream.cpp | 1 + 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/format/KeePass1Reader.cpp b/src/format/KeePass1Reader.cpp index a15c832b3..929632bf0 100644 --- a/src/format/KeePass1Reader.cpp +++ b/src/format/KeePass1Reader.cpp @@ -49,7 +49,12 @@ private: KeePass1Reader::KeePass1Reader() - : m_error(false) + : m_db(Q_NULLPTR) + , m_tmpParent(Q_NULLPTR) + , m_device(Q_NULLPTR) + , m_encryptionFlags(0) + , m_transformRounds(0) + , m_error(false) { } diff --git a/src/format/KeePass2Reader.cpp b/src/format/KeePass2Reader.cpp index 20d20d862..2a25001c6 100644 --- a/src/format/KeePass2Reader.cpp +++ b/src/format/KeePass2Reader.cpp @@ -33,8 +33,12 @@ #include "streams/SymmetricCipherStream.h" KeePass2Reader::KeePass2Reader() - : m_error(false) + : m_device(Q_NULLPTR) + , m_headerStream(Q_NULLPTR) + , m_error(false) + , m_headerEnd(false) , m_saveXml(false) + , m_db(Q_NULLPTR) { } diff --git a/src/format/KeePass2XmlReader.cpp b/src/format/KeePass2XmlReader.cpp index ed5715cbe..9af89db77 100644 --- a/src/format/KeePass2XmlReader.cpp +++ b/src/format/KeePass2XmlReader.cpp @@ -34,6 +34,7 @@ KeePass2XmlReader::KeePass2XmlReader() : m_randomStream(Q_NULLPTR) , m_db(Q_NULLPTR) , m_meta(Q_NULLPTR) + , m_tmpParent(Q_NULLPTR) , m_error(false) , m_strictMode(false) { diff --git a/src/streams/SymmetricCipherStream.cpp b/src/streams/SymmetricCipherStream.cpp index 28525b39f..c713e5220 100644 --- a/src/streams/SymmetricCipherStream.cpp +++ b/src/streams/SymmetricCipherStream.cpp @@ -24,6 +24,7 @@ SymmetricCipherStream::SymmetricCipherStream(QIODevice* baseDevice, SymmetricCip , m_bufferPos(0) , m_bufferFilling(false) , m_error(false) + , m_isInitalized(false) { }