prehistoric-systems/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2026-03-11 08:54:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add maximum integer length to ASN1Key.cpp

Browse source 
Values around 2 GB lead to abort() calls within Qt 5.
This commit is contained in:
Tobias Stoeckmann 2025-12-13 15:30:08 +01:00
parent 1ee32857cf
commit 66be8e8545
3 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/sshagent/ASN1Key.cpp
View file

@ -86,7 +86,7 @@ namespace
VALIDATE_RETURN(nextTag(stream, tag, len));
if (tag != TAG_INT) {
if (tag != TAG_INT || len > 1024 * 1024 * 10) {
return false;
}

12
tests/TestOpenSSHKey.cpp
View file

@ -177,6 +177,18 @@ void TestOpenSSHKey::testParseRSA()
QCOMPARE(key.fingerprint(QCryptographicHash::Md5), QString("MD5:c2:26:5b:3d:62:19:56:b0:c3:67:99:7a:a6:4c:66:06"));
}
void TestOpenSSHKey::testParseRSABroken()
{
const QString keyString = QString("-----BEGIN RSA PRIVATE KEY-----\n"
"MAACAQAChH////8=\n"
"-----END RSA PRIVATE KEY-----\n");
const QByteArray keyData = keyString.toLatin1();
OpenSSHKey key;
QVERIFY(!key.parsePKCS1PEM(keyData));
}
void TestOpenSSHKey::testParseRSACompare()
{
const QString oldKeyString = QString("-----BEGIN RSA PRIVATE KEY-----\n"

1
tests/TestOpenSSHKey.h
View file

@ -31,6 +31,7 @@ private slots:
void testParse();
void testParseDSA();
void testParseRSA();
void testParseRSABroken();
void testParseRSACompare();
void testParseECDSA256();
void testParseECDSA384();