prehistoric-systems/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2026-03-11 08:54:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

SSH Agent: Check writeString() return value in OpenSSHKey

Browse source 
Validate `stream.writeString(m_certificateType)` success and set m_error on
failure, consistent with other write*() calls. Prevents partial stream writes
This commit is contained in:
Alexandre Petit 2026-03-09 16:36:13 +01:00
parent 963bbd0c17
commit 3f497f2eed
No known key found for this signature in database
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/sshagent/OpenSSHKey.cpp
View file

@ -724,7 +724,10 @@ bool OpenSSHKey::writeCertificate(BinaryStream& stream, const bool addCertificat
return true;
}
stream.writeString(m_certificateType);
if (!stream.writeString(m_certificateType)) {
m_error = tr("Unexpected EOF when writing certificate");
return false;
}
if (!stream.writeString(m_rawCertificateData)) {
m_error = tr("Unexpected EOF when writing certificate");