From 3d9ef5c4ed6efbfd8a705000e9c8cbe4bd6f3ff3 Mon Sep 17 00:00:00 2001
From: Alexandre Petit <62973006+AlexpFr@users.noreply.github.com>
Date: Mon, 9 Mar 2026 12:25:29 +0100
Subject: [PATCH] SSH Agent: use SSH_MAX_LOCAL_KEY_SIZE define for cert+key
 size checks

- Add #define SSH_MAX_LOCAL_KEY_SIZE (1 MiB) in KeeAgentSettings.h
- Replace magic value "1024 * 1024" with this constant
---
 src/sshagent/KeeAgentSettings.cpp | 4 ++--
 src/sshagent/KeeAgentSettings.h   | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/sshagent/KeeAgentSettings.cpp b/src/sshagent/KeeAgentSettings.cpp
index d6d0e2d6f..355361552 100644
--- a/src/sshagent/KeeAgentSettings.cpp
+++ b/src/sshagent/KeeAgentSettings.cpp
@@ -568,7 +568,7 @@ bool KeeAgentSettings::toOpenSSHKey(const QString& username,
             return false;
         }
 
-        if (localFile.size() > 1024 * 1024) {
+        if (localFile.size() > SSH_MAX_LOCAL_KEY_SIZE) {
             m_error = QCoreApplication::translate("KeeAgentSettings", "File too large to be a private key");
             return false;
         }
@@ -634,7 +634,7 @@ bool KeeAgentSettings::toOpenSSHKey(const QString& username,
                 return false;
             }
 
-            if (localCertificateFile.size() > 1024 * 1024) {
+            if (localCertificateFile.size() > SSH_MAX_LOCAL_KEY_SIZE) {
                 m_error = QCoreApplication::translate("KeeAgentSettings", "File too large to be a certificate");
                 return false;
             }
diff --git a/src/sshagent/KeeAgentSettings.h b/src/sshagent/KeeAgentSettings.h
index 113d4f982..dbe0eedef 100644
--- a/src/sshagent/KeeAgentSettings.h
+++ b/src/sshagent/KeeAgentSettings.h
@@ -21,6 +21,8 @@
 
 #include <QProcessEnvironment>
 
+#define SSH_MAX_LOCAL_KEY_SIZE (1024 * 1024)
+
 class Entry;
 class EntryAttachments;
 class OpenSSHKey;