Copilot feedback

This commit is contained in:
Agoston Szepessy 2025-12-30 16:36:13 -08:00
parent ac1a170cc3
commit 249352a227
4 changed files with 6 additions and 23 deletions

View file

@ -28,14 +28,14 @@ enum class SortProxyModelKind
Healthcheck,
};
class HibpReportSortPoxyModel : public QSortFilterProxyModel
class HibpReportSortProxyModel : public QSortFilterProxyModel
{
public:
HibpReportSortPoxyModel(QObject* parent)
HibpReportSortProxyModel(QObject* parent)
: QSortFilterProxyModel(parent)
{
}
~HibpReportSortPoxyModel() override = default;
~HibpReportSortProxyModel() override = default;
protected:
bool lessThan(const QModelIndex& left, const QModelIndex& right) const override

View file

@ -45,7 +45,7 @@ ReportsWidgetBase::ReportsWidgetBase(QWidget* parent, SortProxyModelKind proxyMo
m_modelProxy.reset(new HealthcheckReportSortProxyModel(this));
break;
case SortProxyModelKind::Hibp:
m_modelProxy.reset(new HibpReportSortPoxyModel(this));
m_modelProxy.reset(new HibpReportSortProxyModel(this));
break;
}
}
@ -111,7 +111,7 @@ QMenu* ReportsWidgetBase::customMenuRequestedBase()
excludeAction->setObjectName("contextMenuExcludeAction");
const auto excludeGroupsAction =
new QAction(icons()->icon("reports-exclude"), tr("Exclude Group(s) from reports"), this);
excludeGroupsAction->setObjectName("contextMenuxcludeGroupAction");
excludeGroupsAction->setObjectName("contextMenuExcludeGroupAction");
bool isExcluded = false;
bool isGroupExcluded = false;
@ -221,19 +221,6 @@ QList<Entry*> ReportsWidgetBase::getSelectedEntries() const
return selectedEntries;
}
QList<Entry*> ReportsWidgetBase::getSelectedEntries()
{
QList<Entry*> selectedEntries;
for (auto index : getTableView()->selectionModel()->selectedRows()) {
auto row = m_modelProxy->mapToSource(index).row();
auto entry = m_rowToEntry[row].second;
if (entry) {
selectedEntries << entry;
}
}
return selectedEntries;
}
void ReportsWidgetBase::expireSelectedEntries()
{
for (auto entry : getSelectedEntries()) {

View file

@ -51,10 +51,9 @@ protected:
virtual void updateWidget() = 0;
QMenu* customMenuRequestedBase();
QList<Entry*> getSelectedEntries() const;
public slots:
QList<Entry*> getSelectedEntries();
QList<Entry*> getSelectedEntries() const;
void expireSelectedEntries();
void deleteSelectedEntries();
void emitEntryActivated(const QModelIndex& index);

View file

@ -46,9 +46,6 @@ protected:
void updateWidget() override;
QTableView* getTableView() const override;
signals:
void entryActivated(Entry*);
public slots:
void calculateBrowserStatistics();
void customMenuRequested(QPoint);