From 1d32695f108b15d75e02cf4a5a1b6ce36c8cd634 Mon Sep 17 00:00:00 2001 From: thez3ro Date: Fri, 17 Mar 2017 00:34:13 +0100 Subject: [PATCH] permit only wordcount > 0 --- src/core/PassphraseGenerator.cpp | 8 +++++++- src/gui/PasswordGeneratorWidget.cpp | 2 +- src/gui/PasswordGeneratorWidget.ui | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/core/PassphraseGenerator.cpp b/src/core/PassphraseGenerator.cpp index 37f90c67f..dca687226 100644 --- a/src/core/PassphraseGenerator.cpp +++ b/src/core/PassphraseGenerator.cpp @@ -45,7 +45,13 @@ double PassphraseGenerator::calculateEntropy(QString passphrase) void PassphraseGenerator::setWordCount(int wordCount) { - m_wordCount = wordCount; + if (wordCount > 0) { + m_wordCount = wordCount; + } else { + // safe default if something goes wrong + m_wordCount = 7; + } + } void PassphraseGenerator::setWordlist(QString path) diff --git a/src/gui/PasswordGeneratorWidget.cpp b/src/gui/PasswordGeneratorWidget.cpp index 2bc528e19..423d6da26 100644 --- a/src/gui/PasswordGeneratorWidget.cpp +++ b/src/gui/PasswordGeneratorWidget.cpp @@ -340,7 +340,7 @@ void PasswordGeneratorWidget::updateGenerator() m_ui->buttonGenerate->setEnabled(false); } } else { - int minWordCount = 0; + int minWordCount = 1; if (m_ui->spinBoxWordCount->value() < minWordCount) { m_updatingSpinBox = true; diff --git a/src/gui/PasswordGeneratorWidget.ui b/src/gui/PasswordGeneratorWidget.ui index 5cd37ad06..87111c0ab 100644 --- a/src/gui/PasswordGeneratorWidget.ui +++ b/src/gui/PasswordGeneratorWidget.ui @@ -204,7 +204,7 @@ QProgressBar::chunk { QTabWidget::Rounded - 1 + 0