prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix retrieving credentials for authenticating against proxies

Browse source 
KeePassXC uses QUrl for matching URLs against entries [1], so
standard-compliant URLs are needed.

[1] 9d2e066aca/src/browser/BrowserService.cpp (L356)
This commit is contained in:
Chih-Hsuan Yen 2020-05-21 22:09:56 +08:00
parent 1ef4543f95
commit f098c5813f
No known key found for this signature in database
GPG key ID: F98EF2A7B0A098AE
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
keepassxc-browser/background/httpauth.js
View file

@ -63,7 +63,11 @@ httpAuth.processPendingCallbacks = async function(details, resolve, reject) {
httpAuth.requests.push(details.requestId);
if (details.challenger) {
details.proxyUrl = details.challenger.host;
// Non-HTTP proxies are possible with PAC scripts, while currently only
// Firefox provides info about the proxy protocol used [1].
// [1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/onAuthRequired
let scheme = details.proxyInfo ? details.proxyInfo.type : 'http';
details.proxyUrl = scheme + '://' + details.challenger.host;
}
details.searchUrl = (details.isProxy && details.proxyUrl) ? details.proxyUrl : details.url;