prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2161 from keepassxreboot/fix/passkeys_alg_string_firefox_version

Browse source 
Parse algorithm type as Number(). Fix required Firefox version.
This commit is contained in:
Sami Vänttinen 2024-03-30 13:18:08 +02:00 committed by GitHub
commit ed63d9a53e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dist/manifest_firefox.json vendored
View file

@ -160,7 +160,7 @@
"applications": {
"gecko": {
"id": "keepassxc-browser@keepassxc.org",
"strict_min_version": "67.0"
"strict_min_version": "96.0"
}
},
"default_locale": "en"

20
keepassxc-browser/content/passkeys-utils.js
View file

@ -72,20 +72,30 @@ kpxcPasskeysUtils.buildCredentialCreationOptions = function(pkOptions, sameOrigi
publicKey.authenticatorSelection = pkOptions?.authenticatorSelection;
publicKey.challenge = arrayBufferToBase64(pkOptions.challenge);
publicKey.extensions = pkOptions?.extensions;
publicKey.pubKeyCredParams = pkOptions?.pubKeyCredParams;
// Make sure integers are used for "alg". Set to reserved if not found.
// https://www.iana.org/assignments/cose/cose.xhtml#algorithms
publicKey.pubKeyCredParams = [];
if (pkOptions.pubKeyCredParams) {
for (const credParam of pkOptions.pubKeyCredParams) {
publicKey.pubKeyCredParams.push({
type: credParam?.type,
alg: credParam.alg ? Number(credParam.alg) : 0
});
}
}
publicKey.rp = pkOptions?.rp;
publicKey.timeout = getTimeout(publicKey?.authenticatorSelection?.userVerification, pkOptions?.timeout);
publicKey.excludeCredentials = [];
if (pkOptions.excludeCredentials && pkOptions.excludeCredentials.length > 0) {
for (const cred of pkOptions.excludeCredentials) {
const arr = {
publicKey.excludeCredentials.push({
id: arrayBufferToBase64(cred.id),
transports: cred.transports,
type: cred.type
};
publicKey.excludeCredentials.push(arr);
});
}
}