prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #780 from keepassxreboot/fix/155_bugs

Browse source 
Fixes for 1.5.5
This commit is contained in:
Sami Vänttinen 2020-02-20 20:07:20 +02:00 committed by GitHub
commit c2cad20dc4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
keepassxc-browser/content/banner.js
View file

@ -29,7 +29,11 @@ kpxcBanner.destroy = function() {
};
kpxcBanner.create = async function(credentials = {}) {
if (!kpxc.settings.showLoginNotifications || kpxcBanner.created) {
const connectedDatabase = await browser.runtime.sendMessage({
action: 'get_connected_database'
});
if (!kpxc.settings.showLoginNotifications || kpxcBanner.created || connectedDatabase.identifier === null) {
return;
}

7
keepassxc-browser/content/keepassxc-browser.js
View file

@ -303,7 +303,7 @@ kpxcFields.isVisible = function(field) {
kpxcFields.isAutocompleteAppropriate = function(field) {
const autocomplete = field.getLowerCaseAttribute('autocomplete');
return !(autocomplete === 'off' || autocomplete === 'new-password');
return autocomplete !== 'new-password';
};
kpxcFields.getAllFields = function() {
@ -334,7 +334,7 @@ kpxcFields.getAllFields = function() {
kpxcFields.prepareVisibleFieldsWithID = function(pattern) {
const patterns = document.querySelectorAll(pattern);
for (const i of patterns) {
if (kpxcFields.isVisible(i) && i.style.visibility !== 'hidden' && i.style.visibility !== 'collapsed') {
if (kpxcFields.isVisible(i)) {
kpxcFields.setUniqueId(i);
}
}
@ -347,7 +347,7 @@ kpxcFields.getAllCombinations = function(inputs) {
for (const i of inputs) {
if (i) {
if (i.getLowerCaseAttribute('type') === 'password') {
const uId = (!uField || uField.length < 1) ? null : uField.getAttribute('data-kpxc-id');
const uId = (!uField || uField.size < 1) ? null : uField.getAttribute('data-kpxc-id');
const combination = {
username: uId,
@ -673,6 +673,7 @@ kpxcObserverHelper.getInputs = function(target) {
let type = i.getLowerCaseAttribute('type');
if (kpxcObserverHelper.inputTypes.includes(type)) {
kpxcFields.setUniqueId(i);
inputs.push(i);
}
}