prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1937 from keepassxreboot/fix/prevent_background_credential_request

Browse source 
Prevent retrieving credentials from background tabs
This commit is contained in:
Sami Vänttinen 2023-07-12 08:06:05 +03:00 committed by GitHub
commit bfd6988240
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
keepassxc-browser/background/page.js
View file

@ -196,17 +196,25 @@ page.createTabEntry = function(tabId) {
// Page reload or tab switch clears the cache.
// If the retrieval is forced (from Credential Banner), get new credentials normally.
page.retrieveCredentials = async function(tab, args = []) {
if (!tab?.active) {
return [];
}
const [ url, submitUrl, force ] = args;
if (page.tabs[tab.id]?.credentials.length > 0 && !force) {
return page.tabs[tab.id].credentials;
}
// Ignore duplicate requests
if (page.currentRequest.url === url && page.currentRequest.submitUrl === submitUrl && !force) {
// Ignore duplicate requests from the same tab
if (page.currentRequest.url === url
&& page.currentRequest.submitUrl === submitUrl
&& page.currentRequest.tabId === tab.id
&& !force) {
return [];
} else {
page.currentRequest.url = url;
page.currentRequest.submitUrl = submitUrl;
page.currentRequest.tabId = tab.id;
}
const credentials = await keepass.retrieveCredentials(tab, args);