prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1294 from keepassxreboot/fix/autocomplete_with_keyboard

Browse source 
Fix autocomplete menu with keyboard
This commit is contained in:
Sami Vänttinen 2021-04-03 07:23:12 +03:00 committed by GitHub
commit ab1d90f9a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
keepassxc-browser/content/autocomplete.js
View file

@ -171,11 +171,12 @@ class Autocomplete {
}
const items = this.getAllItems();
const inputField = e.target;
if (e.key === 'ArrowDown') {
// If the list is not visible, show it
if (items.length === 0) {
this.index = -1;
this.showList(this.input);
this.showList(inputField);
} else {
// Activate next item
++this.index;
@ -185,7 +186,7 @@ class Autocomplete {
--this.index;
this.activateItem(items);
} else if (e.key === 'Enter') {
if (this.input.value === '') {
if (inputField.value === '') {
e.preventDefault();
}
@ -197,23 +198,23 @@ class Autocomplete {
}
} else if (e.key === 'Tab') {
// Return if value is not in the list
if (this.input.value !== '' && !this.elements.some(c => c.value === this.input.value)) {
if (inputField.value !== '' && !this.elements.some(c => c.value === inputField.value)) {
this.closeList();
return;
}
this.index = this.elements.findIndex(c => c.value === this.input.value);
this.index = this.elements.findIndex(c => c.value === inputField.value);
if (this.index >= 0) {
this.fillPassword(this.input.value, this.index, this.elements[this.index].uuid);
this.fillPassword(inputField.value, this.index, this.elements[this.index].uuid);
}
this.closeList();
} else if (e.key === 'Escape') {
this.closeList();
} else if ((e.key === 'Backspace' || e.key === 'Delete') && this.input.value === '') {
} else if ((e.key === 'Backspace' || e.key === 'Delete') && inputField.value === '') {
// Show menu when input field has no value and backspace is pressed
this.index = -1;
this.showList(this.input);
this.showList(inputField);
}
}