From 962b58d8a93388725dcf8d024431c921eecac5cb Mon Sep 17 00:00:00 2001
From: varjolintu <sami.vanttinen@protonmail.com>
Date: Tue, 17 Jul 2018 15:52:56 +0300
Subject: [PATCH] Allow infinite waiting on remember credentials

---
 keepassxc-browser/background/browserAction.js | 6 +++---
 keepassxc-browser/options/options.html        | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/keepassxc-browser/background/browserAction.js b/keepassxc-browser/background/browserAction.js
index 21f1abf..caf095f 100755
--- a/keepassxc-browser/background/browserAction.js
+++ b/keepassxc-browser/background/browserAction.js
@@ -36,7 +36,7 @@ browserAction.update = function(interval) {
 
     let data = page.tabs[page.currentTabId].stack[page.tabs[page.currentTabId].stack.length - 1];
 
-    if (data.visibleForMilliSeconds !== undefined) {
+    if (data.visibleForMilliSeconds !== undefined && data.visibleForMilliSeconds !== -1) {
         if (data.visibleForMilliSeconds <= 0) {
             browserAction.stackPop(page.currentTabId);
             browserAction.show(null, {'id': page.currentTabId});
@@ -215,13 +215,13 @@ browserAction.setRememberPopup = function(tabId, username, password, url, userna
         }
 
         const id = tabId || page.currentTabId;
-        let timeoutMinMillis = Number(getValueOrDefault(settings, 'blinkMinTimeout', BLINK_TIMEOUT_REDIRECT_THRESHOLD_TIME_DEFAULT, 0));
+        let timeoutMinMillis = Number(getValueOrDefault(settings, 'blinkMinTimeout', BLINK_TIMEOUT_REDIRECT_THRESHOLD_TIME_DEFAULT, -1));
 
         if (timeoutMinMillis > 0) {
             timeoutMinMillis += Date.now();
         }
 
-        const blinkTimeout = getValueOrDefault(settings, 'blinkTimeout', BLINK_TIMEOUT_DEFAULT, 0);
+        const blinkTimeout = getValueOrDefault(settings, 'blinkTimeout', BLINK_TIMEOUT_DEFAULT, -1);
         const pageUpdateAllowance = getValueOrDefault(settings, 'allowedRedirect', BLINK_TIMEOUT_REDIRECT_COUNT_DEFAULT, 0);
 
         const stackData = {
diff --git a/keepassxc-browser/options/options.html b/keepassxc-browser/options/options.html
index 397f946..60ba638 100644
--- a/keepassxc-browser/options/options.html
+++ b/keepassxc-browser/options/options.html
@@ -40,14 +40,14 @@
             <label for="blinkTimeout">Blink Time:</label>
             <div class="control-group">
               <div class="input-append">
-                <input type="number" id="blinkTimeout" placeholder="7500" value="7500" min="0"/>
+                <input type="number" id="blinkTimeout" placeholder="7500" value="7500" min="-1"/>
                 <button class="btn btn-sm btn-primary" id="blinkTimeoutButton" type="button"><span class="glyphicon glyphicon-floppy-disk"></span> Save</button>
               </div>
             </div>
             <span class="help-inline">
               What is the maximum time (ms) the icon should blink after detecting new credentials
               <br />
-              Default: 7500
+              Default: 7500, Infinite: -1
             </span>
           </div>
         </p>