Code cleaning, global functions moved

CHANGELOG

@@ -1,3 +1,7 @@
+0.2.9 (2017-??-??)
+=========================
+- Code cleaning, global functions
+
 0.2.8 (2017-08-08)
 =========================
 - Changed Firefox's minimum version to 55.0

keepassxc-browser/background/browserAction.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 var browserAction = {};
 
 const BLINK_TIMEOUT_DEFAULT = 7500;

keepassxc-browser/background/event.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 var event = {};
 
 event.onMessage = function(request, sender, callback) {

keepassxc-browser/background/init.js

@@ -7,8 +7,6 @@ keepass.changePublicKeys(null, (pkRes) => {
 	keepass.getDatabaseHash((gdRes) => {}, null);
 });
 
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 // Set initial tab-ID
 //browser.tabs.query({'active': true, 'windowId': browser.windows.WINDOW_ID_CURRENT}, (tabs) => {
 browser.tabs.query({"active": true, "currentWindow": true}, (tabs) => {

keepassxc-browser/background/keepass.js

@@ -20,8 +20,6 @@ keepass.keyRing = (typeof(localStorage.keyRing) === 'undefined') ? {} : JSON.par
 keepass.keyId = 'keepassxc-browser-cryptokey-name';
 keepass.keyBody = 'keepassxc-browser-key';
 
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 const kpActions = {
 	SET_LOGIN: 'set-login',
 	GET_LOGINS: 'get-logins',

keepassxc-browser/background/page.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 const defaultSettings = {
 	checkUpdateKeePassXC: 3,
 	autoCompleteUsernames: true,

keepassxc-browser/keepassxc-browser.js

@@ -1,10 +1,3 @@
-var isFirefox = false;
-if (typeof browser !== 'undefined') {
-	isFirefox = true;
-}
-
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 // Initialize autocomplete feature
 $(this.target).find('input').autocomplete();
 
@@ -804,6 +797,7 @@ cipFields.prepareId = function(id) {
 
 cipFields.getAllFields = function() {
 	let fields = [];
+
 	// get all input fields which are text, email or password and visible
 	jQuery(cipFields.inputQueryPattern).each(function() {
 		if (jQuery(this).is(':visible') && jQuery(this).css('visibility') !== 'hidden' && jQuery(this).css('visibility') !== 'collapsed') {

keepassxc-browser/manifest.json

@@ -1,7 +1,7 @@
 {
 	"manifest_version": 2,
 	"name": "keepassxc-browser",
-	"version": "0.2.8",
+	"version": "0.2.9",
 	"description": "KeePassXC integration for modern web browsers",
 	"author": "Sami Vänttinen",
 	"icons": {
@@ -24,6 +24,7 @@
 	},
 	"background": {
 		"scripts": [
+			"global.js",
 			"background/nacl.min.js",
 			"background/nacl-util.min.js",
 			"background/keepass.js",
@@ -41,6 +42,7 @@
 				"https://*/*"
 			],
 			"js": [ 
+				"global.js",
 				"jquery-3.2.1.min.js",
 				"jquery-ui.min.js",
 				"keepassxc-browser.js"

keepassxc-browser/options/options.html

@@ -5,6 +5,7 @@
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="bootstrap.min.css" />
 		<link rel="stylesheet" href="options.css" />
+		<script type="text/javascript" src="../global.js"></script>
 		<script type="text/javascript" src="../jquery-3.2.1.min.js"></script>
 		<script type="text/javascript" src="bootstrap.min.js"></script>
 		<script type="text/javascript" src="options.js"></script>

keepassxc-browser/options/options.js

@@ -1,10 +1,3 @@
-var isFirefox = false;
-if (typeof browser !== 'undefined') {
-	isFirefox = true;
-}
-
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 if (jQuery) {
 	var $ = jQuery.noConflict(true);
 }

keepassxc-browser/popups/popup.html

@@ -4,6 +4,7 @@
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="popup.css" />
 		<link rel="stylesheet" href="../options/bootstrap.min.css" />
+		<script type="text/javascript" src="../global.js"></script>
 		<script type="text/javascript" src="../jquery-3.2.1.min.js"></script>
 		<script type="text/javascript" src="../options/bootstrap.min.js" /></script>
 		<script type="text/javascript" src="popup_functions.js" /></script>

keepassxc-browser/popups/popup.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 function status_response(r) {
 	$('#initial-state').hide();
 	$('#error-encountered').hide();

keepassxc-browser/popups/popup_functions.js

@@ -1,8 +1,5 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 var $ = jQuery.noConflict(true);
 var _settings = typeof(localStorage.settings) ==='undefined' ? {} : JSON.parse(localStorage.settings);
-//var global = browser.runtime.getBackgroundPage();
 
 function updateAvailableResponse(available) {
 	if (available) {

keepassxc-browser/popups/popup_httpauth.html

@@ -4,6 +4,7 @@
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="popup.css" />
 		<link rel="stylesheet" href="../options/bootstrap.min.css" />
+		<script type="text/javascript" src="../global.js"></script>
 		<script type="text/javascript" src="../jquery-3.2.1.min.js"></script>
 		<script type="text/javascript" src="../options/bootstrap.min.js" /></script>
 		<script type="text/javascript" src="popup_functions.js"></script>

keepassxc-browser/popups/popup_httpauth.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 $(function() {
 	browser.runtime.getBackgroundPage(function(global) {
 		browser.tabs.query({"active": true, "currentWindow": true}, (tab) => {

keepassxc-browser/popups/popup_login.html

@@ -4,6 +4,7 @@
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="popup.css" />
 		<link rel="stylesheet" href="../options/bootstrap.min.css" />
+		<script type="text/javascript" src="../global.js"></script>
 		<script type="text/javascript" src="../jquery-3.2.1.min.js"></script>
 		<script type="text/javascript" src="../options/bootstrap.min.js" /></script>
 		<script type="text/javascript" src="popup_functions.js"></script>

keepassxc-browser/popups/popup_login.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 $(function() {
 	browser.runtime.getBackgroundPage(function(global) {
 		browser.tabs.query({"active": true, "currentWindow": true}, (tabs) => {

keepassxc-browser/popups/popup_multiple-fields.html

@@ -4,6 +4,7 @@
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="popup.css" />
 		<link rel="stylesheet" href="../options/bootstrap.min.css" />
+		<script type="text/javascript" src="../global.js"></script>
 		<script type="text/javascript" src="../jquery-3.2.1.min.js"></script>
 		<script type="text/javascript" src="../options/bootstrap.min.js" /></script>
 		<script type="text/javascript" src="popup_functions.js"></script>

keepassxc-browser/popups/popup_remember.html

@@ -4,6 +4,7 @@
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="popup.css" />
 		<link rel="stylesheet" href="../options/bootstrap.min.css" />
+		<script type="text/javascript" src="../global.js"></script>
 		<script type="text/javascript" src="../jquery-3.2.1.min.js"></script>
 		<script type="text/javascript" src="../options/bootstrap.min.js" /></script>
 		<script type="text/javascript" src="popup_functions.js"></script>

keepassxc-browser/popups/popup_remember.js

@@ -1,5 +1,3 @@
-window.browser = (function () { return window.msBrowser || window.browser || window.chrome; })();
-
 var _tab;
 
 function _initialize(tab) {