prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2641 from keepassxreboot/fix/opacity_checks

Browse source 
Fix opacity checks
This commit is contained in:
Sami Vänttinen 2025-08-19 14:18:29 +03:00 committed by GitHub
commit 80fa181487
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
keepassxc-browser/content/fields.js
View file

@ -413,6 +413,12 @@ kpxcFields.isSearchField = function(target) {
// Returns true if element is visible on the page // Returns true if element is visible on the page
kpxcFields.isVisible = function(elem) { kpxcFields.isVisible = function(elem) {
// Returns true if opacity is not set, otherwise check the limits
const isOpacityAllowed = (opacity) => {
const opac = Number(opacity);
return opacity === '' || (opac >= MIN_OPACITY && opac <= MAX_OPACITY);
};
// Check element position and size // Check element position and size
const rect = elem.getBoundingClientRect(); const rect = elem.getBoundingClientRect();
if (rect.x < 0 if (rect.x < 0
@ -426,16 +432,15 @@ kpxcFields.isVisible = function(elem) {
// Check CSS visibility // Check CSS visibility
const elemStyle = getComputedStyle(elem); const elemStyle = getComputedStyle(elem);
const opacity = Number(elemStyle.opacity);
if (elemStyle.visibility && (elemStyle.visibility === 'hidden' || elemStyle.visibility === 'collapse') if (elemStyle.visibility && (elemStyle.visibility === 'hidden' || elemStyle.visibility === 'collapse')
|| (opacity < MIN_OPACITY || opacity > MAX_OPACITY) || !isOpacityAllowed(elemStyle.opacity)
|| parseInt(elemStyle.width, 10) <= MIN_INPUT_FIELD_WIDTH_PX || parseInt(elemStyle.width, 10) <= MIN_INPUT_FIELD_WIDTH_PX
|| parseInt(elemStyle.height, 10) <= MIN_INPUT_FIELD_WIDTH_PX) { || parseInt(elemStyle.height, 10) <= MIN_INPUT_FIELD_WIDTH_PX) {
return false; return false;
} }
// Check for parent opacity // Check for parent opacity
if (kpxcFields.traverseParents(elem, f => f.style.opacity === '0')) { if (kpxcFields.traverseParents(elem, f => !isOpacityAllowed(f.style.opacity))) {
return false; return false;
} }