prehistoric-systems/keepassxc-browser
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc-browser.git synced 2026-03-11 08:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Protect against form overlays (#2676)

Browse source 
Protect against form overlays
This commit is contained in:
Sami Vänttinen 2025-09-06 14:34:39 +03:00 committed by GitHub
parent 5f4133e8a3
commit 77a1f62979
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
keepassxc-browser/content/fields.js
View file

@ -439,11 +439,19 @@ kpxcFields.isTopElement = function(elem, rect) {
}
// Check for popup overlays
const overlays = document.querySelectorAll(':popover-open');
for (const overlay of overlays) {
const overlayRect = overlay?.getBoundingClientRect();
if (overlayRect && elementsOverlap(rect, overlayRect)) {
return false;
try {
// :popover-open selector is supported only with Firefox >= 125 and Chrome >= 114
const overlays = document.querySelectorAll(':popover-open, [popover]');
for (const overlay of overlays) {
const overlayRect = overlay?.getBoundingClientRect();
if (overlayRect && elementsOverlap(rect, overlayRect)) {
return false;
}
}
} catch (e) {
// Ignore SyntaxError (e.g., unsupported selector)
if (!(e instanceof SyntaxError)) {
logError(e);
}
}