From 990e94252e0b46c949093f42d206623484513409 Mon Sep 17 00:00:00 2001 From: varjolintu Date: Mon, 3 Feb 2020 10:18:44 +0200 Subject: [PATCH 1/2] Show Credential banner only in the main page --- keepassxc-browser/content/banner.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keepassxc-browser/content/banner.js b/keepassxc-browser/content/banner.js index 45a3f43..589c8ac 100644 --- a/keepassxc-browser/content/banner.js +++ b/keepassxc-browser/content/banner.js @@ -118,7 +118,7 @@ kpxcBanner.create = async function(credentials = {}) { banner.appendMultiple(bannerInfo, bannerButtons); initColorTheme(banner); - document.body.appendChild(banner); + window.parent.document.body.appendChild(banner); }; kpxcBanner.saveNewCredentials = async function(credentials = {}) { From f94711cb1a8cc6e8b0fe68bb115e434770e30ef2 Mon Sep 17 00:00:00 2001 From: varjolintu Date: Mon, 3 Feb 2020 10:24:36 +0200 Subject: [PATCH 2/2] Do not create a duplicate --- keepassxc-browser/content/banner.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/keepassxc-browser/content/banner.js b/keepassxc-browser/content/banner.js index 589c8ac..eb331c7 100644 --- a/keepassxc-browser/content/banner.js +++ b/keepassxc-browser/content/banner.js @@ -118,7 +118,11 @@ kpxcBanner.create = async function(credentials = {}) { banner.appendMultiple(bannerInfo, bannerButtons); initColorTheme(banner); - window.parent.document.body.appendChild(banner); + + const existingBanner = window.parent.document.body.querySelector('.kpxc-banner'); + if (existingBanner === null) { + window.parent.document.body.appendChild(banner); + } }; kpxcBanner.saveNewCredentials = async function(credentials = {}) {